On Fri, 5 Apr 2024 06:31:16 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations in
On Fri, 5 Apr 2024 06:31:16 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations in
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Sun, 21 Jan 2024 07:23:37 GMT, Julian Waters wrote:
> The previous fix was a bit too hacky for my liking, so I decided to rework it
> by fixing the order in which the labels are defined instead.
Please don't. #15996 was needed to keep the compiler happy, this one is not
needed. Exiting a me
On Fri, 19 Jan 2024 19:42:20 GMT, Daniel Jeliński wrote:
> AFAICT these changes are not necessary.
>
> ### C++11 §6.7/3:
> > [...] A program that jumps from a point where a variable with automatic
> > storage duration is not in scope to a point where it is in scope is
> > ill-formed **unless t
On Fri, 19 Jan 2024 18:43:39 GMT, Weijun Wang wrote:
> The permissive- option you mentioned in the previous PR.
Ah, it goes here:
> The permissive- option you mentioned in the previous PR.
Ah, alright. That goes here:
https://github.com/openjdk/jdk/blob/cbfbaee6eb8d8303a10128cb23ea5021cb8385
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Fri, 19 Jan 2024 01:37:18 GMT, Julian Waters wrote:
>> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 422:
>>
>>> 420: gss_name_struct* name = new gss_name_struct;
>>> 421: if (name == nullptr) {
>>> 422: goto err;
>>
>> Go back? This looks more evil to me
On Fri, 19 Jan 2024 17:31:27 GMT, Weijun Wang wrote:
> The code change looks better. Can you show me where I can add this compiler
> switch so that I can try it myself a little?
Hm? I'm not too sure what compiler switch you are referring to
-
PR Comment: https://git.openjdk.org/jd
On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
On Tue, 16 Jan 2024 17:42:43 GMT, Weijun Wang wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix the remaining case in sspi.cpp
>
> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 580:
>
>> 57
On Tue, 16 Jan 2024 17:36:20 GMT, Weijun Wang wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix the remaining case in sspi.cpp
>
> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 422:
>
>> 42
On Wed, 10 Jan 2024 12:53:48 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Wed, 10 Jan 2024 12:53:48 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
On Mon, 4 Dec 2023 09:26:57 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations in
On Tue, 5 Dec 2023 15:07:15 GMT, Weijun Wang wrote:
> I still don't like this solution:
>
> 1. Duplicated lines.
> 2. There are other `goto`s in this file. I know they happen to be unaffected,
> but if `goto` is not recommended in C++ it looks unfair to remove some and
> keep some.
>
> Can we
On Mon, 4 Dec 2023 09:26:57 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations in
On Mon, 4 Dec 2023 14:49:24 GMT, Weijun Wang wrote:
> I don't like all those duplicated lines. Why do you think the previous fix is
> a hack? I would guess the C++ designers are also not happy of this
> restriction so they provide us a way to avoid it. Maybe they will enhance it
> again someti
On Mon, 4 Dec 2023 09:26:57 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations in
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
> sspi were jumped over by gotos to a certain label. I changed the
> initializations into split declarations and assignments in
> https://github.c
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Fri, 17 Nov 2023 15:44:52 GMT, Thomas Stuefe wrote:
> > > > > Can you please describe the problem you are trying to solve, and why
> > > > > you think it is worth solving. You describe the thought process you
> > > > > went through while doing the patch and possibly some other, older
> > >
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, where initialization of locals in
>> sspi were jumped over by gotos to a certain label. I changed the
>> initializations i
On Fri, 17 Nov 2023 14:13:58 GMT, Thomas Stuefe wrote:
> > > Can you please describe the problem you are trying to solve, and why you
> > > think it is worth solving. You describe the thought process you went
> > > through while doing the patch and possibly some other, older patch. As it
> > >
On Fri, 17 Nov 2023 14:04:07 GMT, Julian Waters wrote:
> > Can you please describe the problem you are trying to solve, and why you
> > think it is worth solving. You describe the thought process you went
> > through while doing the patch and possibly some other, older patch. As it
> > is, rea
On Fri, 17 Nov 2023 13:49:22 GMT, Thomas Stuefe wrote:
> Can you please describe the problem you are trying to solve, and why you
> think it is worth solving. You describe the thought process you went through
> while doing the patch and possibly some other, older patch. As it is, reading
> the
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues
>> with them properly this time, by simply deleting the labels and duplicating
>> the code w
On Thu, 16 Nov 2023 04:40:53 GMT, Julian Waters wrote:
>> I regret not actually addressing the issues with the goto labels in
>> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues
>> with them properly this time, by simply deleting the labels and duplicating
>> the code w
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues with
> them properly this time, by simply deleting the labels and duplicating the
> code where they're used. As mentioned, this unfortunately does incr
> I regret not actually addressing the issues with the goto labels in
> https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues with
> them properly this time, by simply deleting the labels and duplicating the
> code where they're used. As mentioned, this unfortunately does incr
I regret not actually addressing the issues with the goto labels in
https://github.com/openjdk/jdk/pull/15996, I've as such fixed the issues with
them properly this time, by simply deleting the labels and duplicating the code
where they're used. As mentioned, this unfortunately does increase dup
43 matches
Mail list logo
