Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v5]

On Mon, 20 Nov 2023 23:26:44 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > update comment Looks good to me. Thanks~ ---

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v5]

> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: update comment - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - new: https://git.

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > minimize code changes OK, I will remove the ` = (

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > minimize code changes Changes look fine. The syno

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

On Mon, 20 Nov 2023 13:57:58 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > minimize code changes Nice! - PR Co

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v3]

On Fri, 17 Nov 2023 00:05:59 GMT, Weijun Wang wrote: >> When blocksize is less than digest output length, call `keccak` more. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > add comment for squeezeOffset New commit pushed.

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v4]

> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: minimize code changes - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - new: https

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v3]

> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: add comment for squeezeOffset - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - ne

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137 [v2]

> When blocksize is less than digest output length, call `keccak` more. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: fix wording - Changes: - all: https://git.openjdk.org/jdk/pull/16698/files - new: https://git.ope

Re: RFR: 8320192: SHAKE256 does not work correctly if n >= 137

On Thu, 16 Nov 2023 20:45:29 GMT, Weijun Wang wrote: > When blocksize is less than digest output length, call `keccak` more. Looks good. I only found trivial things. A comment describing `squeezeOffset` would help. src/java.base/share/classes/sun/security/provider/DigestBase.java line 144: >

RFR: 8320192: SHAKE256 does not work correctly if n >= 137

When blocksize is less than digest output length, call `keccak` more. - Commit messages: - initial change Changes: https://git.openjdk.org/jdk/pull/16698/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16698&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320192 Sta