Re: RFR: 8319673: Few security tests ignore VM flags [v5]

2024-02-28 Thread Rajan Halade
On Tue, 27 Feb 2024 13:06:57 GMT, Matthew Donovan wrote: > > Nit: Copyright year of IterationCount.java would need to be changed. > > That is a Red Hat copyright; should I add an Oracle copyright? The file isn't > significantly changed. AFAIK, no need to update with Oracle copyright for this u

Re: RFR: 8319673: Few security tests ignore VM flags [v5]

2024-02-27 Thread Matthew Donovan
On Mon, 26 Feb 2024 18:04:18 GMT, Hai-May Chao wrote: > Nit: Copyright year of IterationCount.java would need to be changed. That is a Red Hat copyright; should I add an Oracle copyright? The file isn't significantly changed. - PR Comment: https://git.openjdk.org/jdk/pull/17877#is

Re: RFR: 8319673: Few security tests ignore VM flags [v5]

2024-02-26 Thread Hai-May Chao
On Thu, 22 Feb 2024 12:52:19 GMT, Matthew Donovan wrote: >> In this PR I updated the tests to use the newer >> ProcessTools.createTestJavaProcessBuilder() methods to launch child >> processes. This method ensures that VM options are passed to subprocesses. > > Matthew Donovan has updated the pu

Re: RFR: 8319673: Few security tests ignore VM flags [v5]

2024-02-22 Thread Weijun Wang
On Thu, 22 Feb 2024 12:52:19 GMT, Matthew Donovan wrote: >> In this PR I updated the tests to use the newer >> ProcessTools.createTestJavaProcessBuilder() methods to launch child >> processes. This method ensures that VM options are passed to subprocesses. > > Matthew Donovan has updated the pu

Re: RFR: 8319673: Few security tests ignore VM flags [v5]

2024-02-22 Thread Matthew Donovan
> In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder() methods to launch child > processes. This method ensures that VM options are passed to subprocesses. Matthew Donovan has updated the pull request incrementally with one additional commit since the la

Re: RFR: 8319673: Few security tests ignore VM flags [v4]

2024-02-21 Thread Weijun Wang
On Fri, 16 Feb 2024 15:11:06 GMT, Matthew Donovan wrote: >> In this PR I updated the tests to use the newer >> ProcessTools.createTestJavaProcessBuilder() methods to launch child >> processes. This method ensures that VM options are passed to subprocesses. > > Matthew Donovan has updated the pu

Re: RFR: 8319673: Few security tests ignore VM flags [v4]

2024-02-16 Thread Matthew Donovan
> In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder() methods to launch child > processes. This method ensures that VM options are passed to subprocesses. Matthew Donovan has updated the pull request incrementally with one additional commit since the la

Re: RFR: 8319673: Few security tests ignore VM flags [v3]

2024-02-16 Thread Matthew Donovan
On Fri, 16 Feb 2024 13:53:06 GMT, Weijun Wang wrote: > The tests that used to call `createLimitedTestJavaProcessBuilder` > intentionally avoid copying all the VM options so they can provide their own. > Are you sure they should be modified? I reverted two tests that used `createLimitedTestJava

Re: RFR: 8319673: Few security tests ignore VM flags [v3]

2024-02-16 Thread Weijun Wang
On Fri, 16 Feb 2024 13:13:05 GMT, Matthew Donovan wrote: >> In this PR I updated the tests to use the newer >> ProcessTools.createTestJavaProcessBuilder() methods to launch child >> processes. This method ensures that VM options are passed to subprocesses. > > Matthew Donovan has updated the pu

Re: RFR: 8319673: Few security tests ignore VM flags [v2]

2024-02-16 Thread Matthew Donovan
On Thu, 15 Feb 2024 19:03:57 GMT, Hai-May Chao wrote: > Test sun/security/tools/jarsigner/compatibility/SignTwice.java is listed as > test needs to be updated in the bug, but not in the webrev? SignTwice.java just invokes `Compatibility.main()`. I updated Compatibility.java to pass VM options

Re: RFR: 8319673: Few security tests ignore VM flags [v3]

2024-02-16 Thread Matthew Donovan
> In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder() methods to launch child > processes. This method ensures that VM options are passed to subprocesses. Matthew Donovan has updated the pull request incrementally with one additional commit since the la

Re: RFR: 8319673: Few security tests ignore VM flags [v2]

2024-02-15 Thread Hai-May Chao
On Thu, 15 Feb 2024 18:28:08 GMT, Matthew Donovan wrote: >> In this PR I updated the tests to use the newer >> ProcessTools.createTestJavaProcessBuilder() methods to launch child >> processes. This method ensures that VM options are passed to subprocesses. > > Matthew Donovan has updated the pu

Re: RFR: 8319673: Few security tests ignore VM flags [v2]

2024-02-15 Thread Matthew Donovan
> In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder() methods to launch child > processes. This method ensures that VM options are passed to subprocesses. Matthew Donovan has updated the pull request incrementally with one additional commit since the la

RFR: 8319673: Few security tests ignore VM flags

2024-02-15 Thread Matthew Donovan
In this PR I updated the tests to use the newer ProcessTools.createTestJavaProcessBuilder() methods to launch child processes. This method ensures that VM options are passed to subprocesses. - Commit messages: - 8319673: Few security tests ignore VM flags Changes: https://git.open