Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v3]

2023-10-18 Thread Andrey Turbanov
On Wed, 18 Oct 2023 06:28:01 GMT, Andrey Turbanov wrote: >> A few classes in `com.sun.crypto.provider` package have non-final fields >> which could easily be marked `final`. > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request no

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v3]

2023-10-17 Thread Andrey Turbanov
> A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge remote-tracking branch 'origin/

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v2]

2023-10-12 Thread Valerie Peng
On Wed, 11 Oct 2023 08:16:00 GMT, Andrey Turbanov wrote: >> A few classes in `com.sun.crypto.provider` package have non-final fields >> which could easily be marked `final`. > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request no

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package [v2]

2023-10-11 Thread Andrey Turbanov
> A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge remote-tracking branch 'origin

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-11 Thread Andrey Turbanov
On Tue, 10 Oct 2023 04:17:47 GMT, Valerie Peng wrote: >> A few classes in `com.sun.crypto.provider` package have non-final fields >> which could easily be marked `final`. > > src/java.base/share/classes/com/sun/crypto/provider/EncryptedPrivateKeyInfo.java > line 1: > >> 1: /* > > Hmm, there i

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-10 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/TlsMasterSecretGenerator.java line 165: > 163: private static

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-10 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line 127: > 125: // Use the cleaner to zero

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-10 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java line 102: > 100: * Hash entries are keyed by ali

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-09 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 109: > 107: int tagLenBytes = DEFAULT

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-09 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/EncryptedPrivateKeyInfo.java line 1: > 1: /* Hmm, there is also sun/

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-09 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 276: > 274: } > 275: > 276: private vo

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-09 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java line 61: > 59: > 60: // the key bytes, without

Re: RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-10-09 Thread Valerie Peng
On Thu, 24 Aug 2023 08:53:53 GMT, Andrey Turbanov wrote: > A few classes in `com.sun.crypto.provider` package have non-final fields > which could easily be marked `final`. I'll take a look. - PR Comment: https://git.openjdk.org/jdk/pull/15412#issuecomment-1753872702

RFR: 8315974: Make fields final in 'com.sun.crypto.provider' package

2023-09-10 Thread Andrey Turbanov
A few classes in `com.sun.crypto.provider` package have non-final fields which could easily be marked `final`. - Commit messages: - [PATCH]: Make fields final in com.sun.crypto.provider package Changes: https://git.openjdk.org/jdk/pull/15412/files Webrev: https://webrevs.openjdk.o