Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-29 Thread Mat Carter
On Tue, 29 Oct 2024 15:34:37 GMT, Mat Carter wrote: >> @wangweij, please see the release note above. > >> @rebarbora-mckvak I've added the release note as >> https://bugs.openjdk.org/browse/JDK-8340661 last month. >> >> I didn't approve because of Mat's Aug 14 comment: >> >> > I think there's

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-29 Thread christophvw
On Tue, 29 Oct 2024 15:34:37 GMT, Mat Carter wrote: >> @wangweij, please see the release note above. > >> @rebarbora-mckvak I've added the release note as >> https://bugs.openjdk.org/browse/JDK-8340661 last month. >> >> I didn't approve because of Mat's Aug 14 comment: >> >> > I think there's

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-29 Thread Mat Carter
On Tue, 15 Oct 2024 08:29:28 GMT, rebarbora-mckvak wrote: >> @rebarbora-mckvak Please put the release note here and I can create it. >> Thanks. > > @wangweij, please see the release note above. > @rebarbora-mckvak I've added the release note as > https://bugs.openjdk.org/browse/JDK-8340661 las

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-15 Thread Weijun Wang
On Tue, 15 Oct 2024 08:29:28 GMT, rebarbora-mckvak wrote: >> @rebarbora-mckvak Please put the release note here and I can create it. >> Thanks. > > @wangweij, please see the release note above. @rebarbora-mckvak I've added the release note as https://bugs.openjdk.org/browse/JDK-8340661 last mo

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-15 Thread rebarbora-mckvak
On Wed, 14 Aug 2024 21:53:52 GMT, Weijun Wang wrote: >> I tried to follow the instructions to write a release note, but since this >> is my first contribution, I do not have an account on JBS. > > @rebarbora-mckvak Please put the release note here and I can create it. > Thanks. @wangweij, plea

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-09-16 Thread rebarbora-mckvak
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-08-14 Thread Weijun Wang
On Wed, 14 Aug 2024 21:50:37 GMT, rebarbora-mckvak wrote: >> rebarbora-mckvak has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313367: copyright updated > > I tried to follow the instructions to write a release note, but since this is >

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-08-14 Thread rebarbora-mckvak
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-11 Thread Bernd
On Thu, 11 Apr 2024 13:01:36 GMT, Weijun Wang wrote: > [One of the > test](https://github.com/openjdk/jdk/blob/master/test/jdk/sun/security/mscapi/VeryLongAlias.java) good link, thanks. Didn’t know the type is even visible for an assert. - PR Comment: https://git.openjdk.org/jdk/

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-11 Thread Weijun Wang
On Thu, 11 Apr 2024 07:57:12 GMT, Bernd wrote: >> rebarbora-mckvak has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313367: copyright updated > > Did you test with CNG keys as well? Using the new providers is much more > important since

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-11 Thread Bernd
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-10 Thread Weijun Wang
On Wed, 10 Apr 2024 21:10:16 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-04-10 Thread rebarbora-mckvak
> This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a certificate in a local machine store > must be granted - in a m