Re: RFR: 8312259: StatusResponseManager unused code clean up [v4]

2023-08-07 Thread Jamil Nimeh
On Mon, 31 Jul 2023 19:09:53 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have the code cleanup update reviewed? With this update, the unused >> code in StatusResponseManager.java will be removed. >> >> Thanks, >> Xuelei > > Xue-Lei Andrew Fan has updated the pull request incrementally w

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-08-02 Thread Jamil Nimeh
On Wed, 2 Aug 2023 00:45:36 GMT, Xue-Lei Andrew Fan wrote: >> I think @jnimeh should review this, as I think these methods were added when >> implementing OCSP Stapling, and it would be good for him to make sure they >> are no longer needed.. > >> I think @jnimeh should review this, as I think

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-08-01 Thread Xue-Lei Andrew Fan
On Mon, 31 Jul 2023 18:03:22 GMT, Sean Mullan wrote: > I think @jnimeh should review this, as I think these methods were added when > implementing OCSP Stapling, and it would be good for him to make sure they > are no longer needed.. @jnimeh Did you have a chance to have a look at this update?

Re: RFR: 8312259: StatusResponseManager unused code clean up [v4]

2023-07-31 Thread Xue-Lei Andrew Fan
> Hi, > > May I have the code cleanup update reviewed? With this update, the unused > code in StatusResponseManager.java will be removed. > > Thanks, > Xuelei Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: remove unintended

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-07-31 Thread Xue-Lei Andrew Fan
On Mon, 31 Jul 2023 17:46:22 GMT, Mark Powers wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> revise test case > > test/jdk/sun/security/ssl/Stapling/java.base/sun/security/ssl/StatusResponseManagerTests.java

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-07-31 Thread Sean Mullan
On Wed, 19 Jul 2023 04:35:56 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have the code cleanup update reviewed? With this update, the unused >> code in StatusResponseManager.java will be removed. >> >> Thanks, >> Xuelei > > Xue-Lei Andrew Fan has updated the pull request incrementally w

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-07-31 Thread Mark Powers
On Wed, 19 Jul 2023 04:35:56 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have the code cleanup update reviewed? With this update, the unused >> code in StatusResponseManager.java will be removed. >> >> Thanks, >> Xuelei > > Xue-Lei Andrew Fan has updated the pull request incrementally w

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-07-31 Thread Mark Powers
On Wed, 19 Jul 2023 04:35:56 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have the code cleanup update reviewed? With this update, the unused >> code in StatusResponseManager.java will be removed. >> >> Thanks, >> Xuelei > > Xue-Lei Andrew Fan has updated the pull request incrementally w

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-07-31 Thread Xue-Lei Andrew Fan
On Wed, 19 Jul 2023 04:35:56 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have the code cleanup update reviewed? With this update, the unused >> code in StatusResponseManager.java will be removed. >> >> Thanks, >> Xuelei > > Xue-Lei Andrew Fan has updated the pull request incrementally w

Re: RFR: 8312259: StatusResponseManager unused code clean up [v3]

2023-07-18 Thread Xue-Lei Andrew Fan
> Hi, > > May I have the code cleanup update reviewed? With this update, the unused > code in StatusResponseManager.java will be removed. > > Thanks, > Xuelei Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: revise test case

Re: RFR: 8312259: StatusResponseManager unused code clean up [v2]

2023-07-18 Thread Xue-Lei Andrew Fan
On Tue, 18 Jul 2023 21:54:07 GMT, Mark Powers wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add final keyword back > > src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java line > 584: >

Re: RFR: 8312259: StatusResponseManager unused code clean up [v2]

2023-07-18 Thread Xue-Lei Andrew Fan
> Hi, > > May I have the code cleanup update reviewed? With this update, the unused > code in StatusResponseManager.java will be removed. > > Thanks, > Xuelei Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: add final keyword

Re: RFR: 8312259: StatusResponseManager unused code clean up

2023-07-18 Thread Xue-Lei Andrew Fan
On Tue, 18 Jul 2023 21:54:07 GMT, Mark Powers wrote: >> Hi, >> >> May I have the code cleanup update reviewed? With this update, the unused >> code in StatusResponseManager.java will be removed. >> >> Thanks, >> Xuelei > > src/java.base/share/classes/sun/security/ssl/StatusResponseManager.jav

Re: RFR: 8312259: StatusResponseManager unused code clean up

2023-07-18 Thread Mark Powers
On Tue, 18 Jul 2023 17:43:42 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have the code cleanup update reviewed? With this update, the unused > code in StatusResponseManager.java will be removed. > > Thanks, > Xuelei src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java l

RFR: 8312259: StatusResponseManager unused code clean up

2023-07-18 Thread Xue-Lei Andrew Fan
Hi, May I have the code cleanup update reviewed? With this update, the unused code in StatusResponseManager.java will be removed. Thanks, Xuelei - Commit messages: - 8312259: StatusResponseManager unused code clean up Changes: https://git.openjdk.org/jdk/pull/14924/files Webrev