On Tue, 15 Aug 2023 10:48:29 GMT, Glavo wrote:
>> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
>
> Glavo has updated the pull request with a new target base due to a merge or a
> rebase. The pull request now contains four commits:
>
> - Merge remote-tracking branch 'origin
On Tue, 15 Aug 2023 10:48:29 GMT, Glavo wrote:
>> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
>
> Glavo has updated the pull request with a new target base due to a merge or a
> rebase. The pull request now contains four commits:
>
> - Merge remote-tracking branch 'origin
On Tue, 15 Aug 2023 10:48:29 GMT, Glavo wrote:
>> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
>
> Glavo has updated the pull request with a new target base due to a merge or a
> rebase. The pull request now contains four commits:
>
> - Merge remote-tracking branch 'origin
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
Glavo has updated the pull request with a new target base due to a merge or a
rebase. The pull request now contains four commits:
- Merge remote-tracking branch 'origin/master' into case-conversion-java-base
- Revert StreamTok
On Wed, 12 Jul 2023 15:06:36 GMT, Glavo wrote:
>> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
>
> Glavo has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Revert StreamTokenizer.java
Now that the incompatible change to S
- Original Message -
> From: "Uwe Schindler"
> To: "core-libs-dev" , net-...@openjdk.org,
> nio-...@openjdk.org, security-dev@openjdk.org
> Sent: Wednesday, July 12, 2023 6:08:17 PM
> Subject: Re: RFR: 8311943: Cleanup usages of toLowerCase() and toUpp
On Fri, 14 Jul 2023 13:01:46 GMT, Glavo wrote:
>>> However, while I think this corrects the behavior, this caused a change in
>>> the behavior of the API, so a CSR may be required. I don't want to debate
>>> this in this PR, so I'll revert this change and open a new PR in the future.
>>
>> Str
On Fri, 14 Jul 2023 10:24:47 GMT, Alan Bateman wrote:
> It might be that the conclusion is that it's just too risky to change, in
> which case Uwe's suggestion is good and would avoid it showing up on
> someone's else radar in the future.
Until we're sure we want to normalize a usage of `toLow
On Wed, 12 Jul 2023 16:17:49 GMT, Glavo wrote:
>> Maybe a small suggestion to make it clear whats wanted here. In other
>> projects I am involved in (Apache Lucene/Solr, Apache TIKA, PostgresSQL
>> JDBC, Checkstyle itsself, Elasticserach/Opensearch), which use the
>> [forbiddenapis Maven/Gradl
On Wed, 12 Jul 2023 16:05:03 GMT, Uwe Schindler wrote:
> Maybe a small suggestion to make it clear whats wanted here. In other
> projects I am involved in (Apache Lucene/Solr, Apache TIKA, PostgresSQL JDBC,
> Checkstyle itsself, Elasticserach/Opensearch), which use the [forbiddenapis
> Maven/G
On Wed, 12 Jul 2023 14:31:53 GMT, Glavo wrote:
>> src/java.base/share/classes/java/io/StreamTokenizer.java line 632:
>>
>>> 630: sval = String.copyValueOf(buf, 0, i);
>>> 631: if (forceLower)
>>> 632: sval = sval.toLowerCase(Locale.ROOT);
>>
>> I suspect
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
Glavo has updated the pull request incrementally with one additional commit
since the last revision:
Revert StreamTokenizer.java
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14763/files
- new: https://g
On Wed, 12 Jul 2023 13:26:03 GMT, Alan Bateman wrote:
> I suspect this change to StreamTokenizer needs eyes. I think long standing
> behavior of the lowerCaseMode(true) has been to use the rules for the default
> locale so we need to be careful.
I investigated some usage of this method on GitH
On Mon, 3 Jul 2023 20:53:34 GMT, Glavo wrote:
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
src/java.base/share/classes/java/io/StreamTokenizer.java line 632:
> 630: sval = String.copyValueOf(buf, 0, i);
> 631: if (forceLower)
> 632:
On Mon, 3 Jul 2023 20:53:34 GMT, Glavo wrote:
> Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
Hello Glavo, I've created https://bugs.openjdk.org/browse/JDK-8311943 to track
this change. Please update the title to this PR to `8311943: Cleanup usages of
toLowerCase() and toUp
Clean up misuses of `toLowerCase()`/`toUpperCase()` in java.base.
-
Commit messages:
- Update DateTimeFormatterBuilder
- Avoid locale-sensitive case conversions in java.base
Changes: https://git.openjdk.org/jdk/pull/14763/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=1476
16 matches
Mail list logo
