On Wed, 19 Jul 2023 17:51:20 GMT, Valerie Peng wrote:
> 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
/Integrate
-
PR Comment: https://git.openjdk.org/jdk21/pull/139#issuecomment-1642849132
On Wed, 19 Jul 2023 21:02:56 GMT, Xue-Lei Andrew Fan wrote:
>> 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
>
> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line
> 274:
>
>> 272: }
>> 273:
>> 274: SecretKey that = (
On Wed, 19 Jul 2023 17:51:20 GMT, Valerie Peng wrote:
> 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
Marked as reviewed by xuelei (Reviewer).
src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line 274:
> 272: }
> 273:
> 274:
On Wed, 19 Jul 2023 17:51:20 GMT, Valerie Peng wrote:
> 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
Marked as reviewed by ascarpino (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/139#pullrequestreview-1537839835
On Wed, 19 Jul 2023 17:51:20 GMT, Valerie Peng wrote:
> 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
Marked as reviewed by mullan (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/139#pullrequestreview-1537771538
8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
-
Commit messages:
- Backport 28c4d196cff8576b69cf115cda538ab1dad978d2
Changes: https://git.openjdk.org/jdk21/pull/139/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=139&range=00
Issue: https://bu
On Fri, 14 Jul 2023 21:57:32 GMT, Valerie Peng wrote:
>> This change adds back the Reference.ReachabilityFence(Object) call removed
>> by [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>>
>> Please help review.
>> Thanks!
>> Valerie
>
> Valerie Peng has updated the pull request inc
On Fri, 14 Jul 2023 21:57:32 GMT, Valerie Peng wrote:
>> This change adds back the Reference.ReachabilityFence(Object) call removed
>> by [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>>
>> Please help review.
>> Thanks!
>> Valerie
>
> Valerie Peng has updated the pull request inc
On Fri, 14 Jul 2023 21:57:32 GMT, Valerie Peng wrote:
>> This change adds back the Reference.ReachabilityFence(Object) call removed
>> by [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>>
>> Please help review.
>> Thanks!
>> Valerie
>
> Valerie Peng has updated the pull request inc
> This change adds back the Reference.ReachabilityFence(Object) call removed by
> [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>
> Please help review.
> Thanks!
> Valerie
Valerie Peng has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 14 Jul 2023 03:04:13 GMT, Xue-Lei Andrew Fan wrote:
> > > > It looks good to me to rollback to previous behaviors. I was just
> > > > wondering, if the use of key in other methods, like
> > > > hashCode()/equals(), has the similar issue? Thanks!
> > >
> > >
> > > For the usage of hash
On Fri, 14 Jul 2023 02:37:09 GMT, Xue-Lei Andrew Fan wrote:
> > > It looks good to me to rollback to previous behaviors. I was just
> > > wondering, if the use of key in other methods, like hashCode()/equals(),
> > > has the similar issue? Thanks!
> >
> >
> > For the usage of hashCode()/equal
On Thu, 13 Jul 2023 21:01:06 GMT, Valerie Peng wrote:
> > It looks good to me to rollback to previous behaviors. I was just
> > wondering, if the use of key in other methods, like hashCode()/equals(),
> > has the similar issue? Thanks!
>
> For the usage of hashCode()/equals(), there should be
On Thu, 13 Jul 2023 20:58:45 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line
>> 1:
>>
>>> 1: /*
>>
>> I also think the change which moved the registering of the `Cleaner` outside
>> the `finally` block in the constructor is not correct,
On Thu, 13 Jul 2023 18:27:08 GMT, Sean Mullan wrote:
>> This change adds back the Reference.ReachabilityFence(Object) call removed
>> by [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>>
>> Please help review.
>> Thanks!
>> Valerie
>
> src/java.base/share/classes/com/sun/crypto/pro
On Thu, 13 Jul 2023 04:15:54 GMT, Xue-Lei Andrew Fan wrote:
> It looks good to me to rollback to previous behaviors. I was just wondering,
> if the use of key in other methods, like hashCode()/equals(), has the similar
> issue? Thanks!
For the usage of hashCode()/equals(), there should be stro
On Thu, 13 Jul 2023 18:16:21 GMT, Sean Mullan wrote:
>> This change adds back the Reference.ReachabilityFence(Object) call removed
>> by [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>>
>> Please help review.
>> Thanks!
>> Valerie
>
> src/java.base/share/classes/com/sun/crypto/pro
On Thu, 13 Jul 2023 02:46:10 GMT, Valerie Peng wrote:
> This change adds back the Reference.ReachabilityFence(Object) call removed by
> [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>
> Please help review.
> Thanks!
> Valerie
src/java.base/share/classes/com/sun/crypto/provider/PB
On Thu, 13 Jul 2023 02:46:10 GMT, Valerie Peng wrote:
> This change adds back the Reference.ReachabilityFence(Object) call removed by
> [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>
> Please help review.
> Thanks!
> Valerie
src/java.base/share/classes/com/sun/crypto/provider/PB
On Thu, 13 Jul 2023 02:46:10 GMT, Valerie Peng wrote:
> This change adds back the Reference.ReachabilityFence(Object) call removed by
> [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>
> Please help review.
> Thanks!
> Valerie
It looks good to me to rollback to previous behaviors.
On Thu, 13 Jul 2023 02:46:10 GMT, Valerie Peng wrote:
> This change adds back the Reference.ReachabilityFence(Object) call removed by
> [JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
>
> Please help review.
> Thanks!
> Valerie
Looks good to me
-
Marked as reviewed by
This change adds back the Reference.ReachabilityFence(Object) call removed by
[JDK-8301553](https://bugs.openjdk.org/browse/JDK-8301553).
Please help review.
Thanks!
Valerie
-
Commit messages:
- 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
Changes: htt
22 matches
Mail list logo
