Re: [jdk21] RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Iris Clark
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote: > Hi all, > > This pull request contains a backport of commit > [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk21] RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
On Tue, 4 Jul 2023 19:05:58 GMT, Pavel Rappo wrote: > Hi all, > > This pull request contains a backport of commit > [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk21] RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
Hi all, This pull request contains a backport of commit [7b3c2dc5](https://github.com/openjdk/jdk/commit/7b3c2dc5f45afc3646ff5cdc0f6efd68e0b70ea5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Pavel Rappo on 4 Jul 2023 and was revie

Re: RFR: 8311122: Fix typos in java.base

2023-07-04 Thread Pavel Rappo
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Alright, I think all the areas that this PR touches have been reviewed by area experts. - PR Comment: https://git.openjdk.org/jdk/pull/14718#issueco

Re: RFR: 8311122: Fix typos in java.base

2023-07-03 Thread Sean Mullan
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. The changes in the security classes look fine to me. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14718#pu

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Hamlin Li
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Marked as reviewed by mli (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506596503

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Pavel Rappo
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Our CI tests are fine with this change. That said, I'll wait for security-dev to complete the review, and then wait for a few more days so that others could also

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Iris Clark
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506190678

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Mandy Chung
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Marked as reviewed by mchung (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506186255

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Naoto Sato
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. LGTM - Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14718#pullrequestreview-1506183994

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Pavel Rappo
On Thu, 29 Jun 2023 21:28:39 GMT, Joe Darcy wrote: > Looks fine, but please give some time for others reviewers before pushing. Absolutely! Also, this PR contains a code change (a typo in an error message), which, technically speaking, disqualifies the bug from being "noreg-doc" and requires

Re: RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Joe Darcy
On Thu, 29 Jun 2023 21:17:49 GMT, Pavel Rappo wrote: > Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. Looks fine, but please give some time for others reviewers before pushing. - Marked as reviewed by darcy (Reviewer). PR Review: https://git.openjdk.

RFR: 8311122: Fix typos in java.base

2023-06-29 Thread Pavel Rappo
Please review this IDE-assisted typo hunt, which I plan to backport to jdk21. - Commit messages: - Fix copyright years - Initial commit Changes: https://git.openjdk.org/jdk/pull/14718/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14718&range=00 Issue: https://bugs.openj