Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v5]

2024-09-27 Thread Weijun Wang
On Fri, 27 Sep 2024 14:17:54 GMT, Sean Mullan wrote: >> Actually, I see the output will also contain the message "Re-run with the >> -verbose and -certs options for more details." so I take back my comment >> above. > > For this summary message, I suggest we be a bit more descriptive like in >

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v5]

2024-09-27 Thread Sean Mullan
On Fri, 27 Sep 2024 14:01:18 GMT, Sean Mullan wrote: >> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java >> line 182: >> >>> 180: {"key.bit.eccurve.disabled", "%1$d-bit %2$s key (disabled)"}, >>> 181: {"unknown.size", "unknown size"}, >>> 182: {"

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v5]

2024-09-27 Thread Sean Mullan
On Fri, 27 Sep 2024 13:49:57 GMT, Sean Mullan wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> expected result should be the 1st argument > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v5]

2024-09-27 Thread Sean Mullan
On Thu, 19 Sep 2024 12:06:57 GMT, Weijun Wang wrote: >> There ~are two~ is one change~s~: >> >> 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and >> print them out as >> >> Warning: nonexistent signed entries detected: [a] >> >> ~2. In `JarSigner::sign0`, when creat

Re: RFR: 8309841: Jarsigner should print a warning if an entry is removed [v5]

2024-09-19 Thread Weijun Wang
> There ~are two~ is one change~s~: > > 1. In `jarsigner -verify`, check a .SF file contains un-existing entries and > print them out as > > Warning: nonexistent signed entries detected: [a] > > ~2. In `JarSigner::sign0`, when creating a new .SF file, only include signed > file entries.~ > >