Re: [jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Weijun Wang
On Fri, 23 Jun 2023 18:35:25 GMT, Xue-Lei Andrew Fan wrote: > Looks good to me. I was just wondering, if the /backport tag could work from > the original PR for backporting. It looks Jamil did use the `/backport` command from the original commit. Or are you wondering why a review is still need

Re: [jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Hai-May Chao
On Fri, 23 Jun 2023 14:55:45 GMT, Jamil Nimeh wrote: > This is a backport of the test fixes comprising JDK-8309740. Marked as reviewed by hchao (Committer). - PR Review: https://git.openjdk.org/jdk21/pull/58#pullrequestreview-1495731841

Re: [jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Xue-Lei Andrew Fan
On Fri, 23 Jun 2023 14:55:45 GMT, Jamil Nimeh wrote: > This is a backport of the test fixes comprising JDK-8309740. Looks good to me. I was just wondering, if the /backport tag could work from the original PR for backporting. - Marked as reviewed by xuelei (Reviewer). PR Review:

[jdk21] RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Jamil Nimeh
This is a backport of the test fixes comprising JDK-8309740. - Commit messages: - Backport 5ca4cdd2caceba9dad8025e5a8851740a3961921 Changes: https://git.openjdk.org/jdk21/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=58&range=00 Issue: https://bugs.openjdk.org/

Re: RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Jamil Nimeh
On Fri, 16 Jun 2023 18:42:32 GMT, Xue-Lei Andrew Fan wrote: >> This PR is for tests that were modified/added in JDK-8179502. The timeout >> windows for those tests were a little too short on some test systems, >> especially when the system is under heavy load. After a few iterations >> tryin

Re: RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-23 Thread Matthias Baesken
On Fri, 16 Jun 2023 18:19:45 GMT, Jamil Nimeh wrote: > This PR is for tests that were modified/added in JDK-8179502. The timeout > windows for those tests were a little too short on some test systems, > especially when the system is under heavy load. After a few iterations > trying out vario

Re: RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-16 Thread Xue-Lei Andrew Fan
On Fri, 16 Jun 2023 18:19:45 GMT, Jamil Nimeh wrote: > This PR is for tests that were modified/added in JDK-8179502. The timeout > windows for those tests were a little too short on some test systems, > especially when the system is under heavy load. After a few iterations > trying out vario

RFR: 8309740: Expand timeout windows for tests in JDK-8179502

2023-06-16 Thread Jamil Nimeh
This PR is for tests that were modified/added in JDK-8179502. The timeout windows for those tests were a little too short on some test systems, especially when the system is under heavy load. After a few iterations trying out various longer time windows I have a set that should not run into is