Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-29 Thread Weijun Wang
On Fri, 29 Sep 2023 19:03:35 GMT, Sean Mullan wrote: > > @seanjmullan I've created a release-note at > > https://bugs.openjdk.org/browse/JDK-8317325. Please take a look. TIA. > > I would note the previous behavior, ex: "Prior to this change, the files were > read in no specific order." Thanks

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-29 Thread Sean Mullan
On Thu, 28 Sep 2023 19:19:36 GMT, Sean Mullan wrote: >>> Is there any potential compatibility issue by reading the files in a >>> different order? >> >> There is a behavior change, but I doubt if anyone is using this feature. I'm >> following what MIT krb5 has fixed. I can add a release note i

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-29 Thread Weijun Wang
On Thu, 28 Sep 2023 19:19:36 GMT, Sean Mullan wrote: >>> Is there any potential compatibility issue by reading the files in a >>> different order? >> >> There is a behavior change, but I doubt if anyone is using this feature. I'm >> following what MIT krb5 has fixed. I can add a release note i

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-28 Thread Sean Mullan
On Thu, 28 Sep 2023 18:28:13 GMT, Weijun Wang wrote: > > Is there any potential compatibility issue by reading the files in a > > different order? > > There is a behavior change, but I doubt if anyone is using this feature. I'm > following what MIT krb5 has fixed. I can add a release note if n

Re: RFR: 8309356: Read files in includedir in alphanumeric order [v2]

2023-09-28 Thread Sean Mullan
On Thu, 28 Sep 2023 18:49:15 GMT, Weijun Wang wrote: >> Read files in `includedir` in alphanumerical order. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > typo in comment Marked as reviewed by mullan (Reviewer). -

Re: RFR: 8309356: Read files in includedir in alphanumeric order [v2]

2023-09-28 Thread Weijun Wang
> Read files in `includedir` in alphanumerical order. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: typo in comment - Changes: - all: https://git.openjdk.org/jdk/pull/15889/files - new: https://git.openjdk.org/jdk/p

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-28 Thread Weijun Wang
On Thu, 28 Sep 2023 13:21:57 GMT, Sean Mullan wrote: > Is there any potential compatibility issue by reading the files in a > different order? There is a behavior change, but I doubt if anyone is using this feature. I'm following what MIT krb5 has fixed. I can add a release note if necessary.

Re: RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-28 Thread Sean Mullan
On Fri, 22 Sep 2023 14:00:34 GMT, Weijun Wang wrote: > Read files in `includedir` in alphanumerical order. Is there any potential compatibility issue by reading the files in a different order? test/jdk/sun/security/krb5/config/IncludeDirOrder.java line 61: > 59: write(xdir, i); >

RFR: 8309356: Read files in includedir in alphanumeric order

2023-09-25 Thread Weijun Wang
Read files in `includedir` in alphanumerical order. - Commit messages: - remove x bits - the fix Changes: https://git.openjdk.org/jdk/pull/15889/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15889&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309356 Stats: 77 l