Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v5]

2023-06-15 Thread Sean Mullan
On Thu, 15 Jun 2023 20:57:44 GMT, Ben Perez wrote: >> Changed `getEncoded` for both EC and RSA to return a copy of the internal >> key array to avoid mutability issues. > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > fixed co

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v5]

2023-06-15 Thread Ben Perez
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. Ben Perez has updated the pull request incrementally with one additional commit since the last revision: fixed copyrite date - Changes: - all: https://git.openjd

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v4]

2023-06-15 Thread Sean Mullan
On Thu, 15 Jun 2023 19:13:37 GMT, Ben Perez wrote: >> Changed `getEncoded` for both EC and RSA to return a copy of the internal >> key array to avoid mutability issues. > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > added co

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v4]

2023-06-15 Thread Ben Perez
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. Ben Perez has updated the pull request incrementally with one additional commit since the last revision: added copyrite to test - Changes: - all: https://git.ope

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v3]

2023-06-15 Thread Sean Mullan
On Thu, 15 Jun 2023 17:22:53 GMT, Ben Perez wrote: >> Changed `getEncoded` for both EC and RSA to return a copy of the internal >> key array to avoid mutability issues. > > Ben Perez has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v3]

2023-06-15 Thread Ben Perez
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. Ben Perez has updated the pull request incrementally with two additional commits since the last revision: - Removed unnecessary imports - Removed unnecessary module in test. Cat

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v2]

2023-06-15 Thread Sean Mullan
On Wed, 14 Jun 2023 20:38:18 GMT, Ben Perez wrote: >> Changed `getEncoded` for both EC and RSA to return a copy of the internal >> key array to avoid mutability issues. > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Changed

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v2]

2023-06-14 Thread Ben Perez
On Wed, 14 Jun 2023 20:28:15 GMT, Sean Mullan wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changed array copy to be more compact > > src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java > line

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array [v2]

2023-06-14 Thread Ben Perez
> Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Changed array copy to be more compact - Changes: - all:

Re: RFR: 8308808: SunMSCAPI public keys returns internal key array

2023-06-14 Thread Sean Mullan
On Mon, 12 Jun 2023 18:49:59 GMT, Ben Perez wrote: > Changed `getEncoded` for both EC and RSA to return a copy of the internal key > array to avoid mutability issues. src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java line 99: > 97: byte[] safeEncoding = new

RFR: 8308808: SunMSCAPI public keys returns internal key array

2023-06-12 Thread Ben Perez
Changed `getEncoded` for both EC and RSA to return a copy of the internal key array to avoid mutability issues. - Commit messages: - updated copywrite - Fixed getEncoded for CRSAPublicKey - Fixed imports and formatting - Modify getEncoded to return copy of encoding. Added test.