> Additional Tests for KEM API.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
Comment added
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14113/files
- new: https://git.openjdk.org/jdk/pull/14113/files/f70d
On Thu, 1 Jun 2023 14:44:53 GMT, Sibabrata Sahoo wrote:
>> test/jdk/javax/crypto/KEM/KemTest.java line 138:
>>
>>> 136:
>>> decT.decapsulate(enc.encapsulation()).getEncoded().length);
>>> 137:
>>> Asserts.assertEQ(decT.decapsulate(enc.encapsulation()).ge
On Thu, 1 Jun 2023 14:16:23 GMT, Weijun Wang wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comments addressed
>
> test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 79:
>
>> 77: sk.getEn
On Thu, 1 Jun 2023 07:37:38 GMT, Sibabrata Sahoo wrote:
>> Additional Tests for KEM API.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Comments addressed
Looks good to me. Thanks!
-
Marked as reviewed by
On Thu, 1 Jun 2023 07:37:38 GMT, Sibabrata Sahoo wrote:
>> Additional Tests for KEM API.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Comments addressed
test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 79:
>
On Wed, 31 May 2023 13:00:15 GMT, Weijun Wang wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308711: Comment addressed
>
> test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 45:
>
>> 43: * X448 pro
> Additional Tests for KEM API.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
Comments addressed
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14113/files
- new: https://git.openjdk.org/jdk/pull/14113/files
On Wed, 31 May 2023 06:27:09 GMT, Sibabrata Sahoo wrote:
>> Additional Tests for KEM API.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8308711: Comment addressed
test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java li
On Wed, 24 May 2023 13:00:40 GMT, Weijun Wang wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8308711: Comment addressed
>
> test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 1:
>
>> 1: /*
>
> 1. `testX
> Additional Tests for KEM API.
Sibabrata Sahoo has updated the pull request incrementally with one additional
commit since the last revision:
8308711: Comment addressed
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14113/files
- new: https://git.openjdk.org/jdk/pull/141
> Additional Tests for KEM API.
Sibabrata Sahoo has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains two additional
commits since the last revision:
- Mer
On Wed, 24 May 2023 07:02:55 GMT, Sibabrata Sahoo wrote:
> Additional Tests for KEM API.
test/jdk/javax/crypto/KEM/GenLargeNumberOfKeys.java line 1:
> 1: /*
1. `testXDH` and `testEC` are mostly identical. Maybe you can write a single
method with 2 extra arguments.
2. According to the spec, mu
Additional Tests for KEM API.
-
Commit messages:
- 8308711: Develop additional Tests for KEM implementation
Changes: https://git.openjdk.org/jdk/pull/14113/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14113&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8308711
S
13 matches
Mail list logo
