Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-03-26 Thread Brian Goetz
Since LMF goes through Lookup::defineHiddenClass, does this mean that they will be potentially dumped twice, once through Lookup, and once through LMF? Now that there is a shared implementation, perhaps we should migrate use in LMF to something more like -Djava.lang.invoke.MethodHandle.DU

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API [v2]

2023-03-24 Thread Mandy Chung
> This implements a shared utility to dump generated classes defined as > normal/hidden classes via `Lookup` API. This replaces the implementation in > `LambdaMetaFactory` and method handle implementation that dumps the hidden > class bytes on disk for debugging. > > For classes defined vi

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API [v2]

2023-03-24 Thread Mandy Chung
On Fri, 24 Mar 2023 20:54:25 GMT, Chen Liang wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> avoid another map lookup > > src/java.base/share/classes/java/lang/invoke/ClassFileDumper.java line 88: > >> 86:

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-03-24 Thread Chen Liang
On Fri, 24 Mar 2023 20:41:41 GMT, Mandy Chung wrote: > This implements a shared utility to dump generated classes defined as > normal/hidden classes via `Lookup` API. This replaces the implementation in > `LambdaMetaFactory` and method handle implementation that dumps the hidden > class byte

RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API

2023-03-24 Thread Mandy Chung
This implements a shared utility to dump generated classes defined as normal/hidden classes via `Lookup` API. This replaces the implementation in `LambdaMetaFactory` and method handle implementation that dumps the hidden class bytes on disk for debugging. For classes defined via `Lookup::d