On Mon, 6 Feb 2023 09:16:45 GMT, Eirik Bjorsnos wrote:
>> test/jdk/java/util/jar/JarFile/VerifySignedJar.java line 76:
>>
>>> 74: // Read entry by name
>>> 75: ZipEntry ze =
>>> Objects.requireNonNull(jf.getEntry("getprop.class"));
>>> 76: JarEntry je =
>>>
On Mon, 6 Feb 2023 09:21:29 GMT, Eirik Bjorsnos wrote:
>> This PR resurrects VerifySignedJar which currently tests nothing.
>>
>> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
>> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
>> the J
On Mon, 6 Feb 2023 04:09:29 GMT, Weijun Wang wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace after "if"
>>
>> Co-authored-by: Andrey Turbanov
>
> test/jdk/java/util/jar/JarFile/VerifySignedJa
> This PR resurrects VerifySignedJar which currently tests nothing.
>
> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
> the JAR is treated as unsigned so the test doesn't really test anyt
On Fri, 3 Feb 2023 08:01:21 GMT, Eirik Bjorsnos wrote:
>> This PR resurrects VerifySignedJar which currently tests nothing.
>>
>> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
>> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
>> the J
> This PR resurrects VerifySignedJar which currently tests nothing.
>
> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
> the JAR is treated as unsigned so the test doesn't really test anyt
On Wed, 25 Jan 2023 17:38:13 GMT, Eirik Bjorsnos wrote:
> This PR resurrects VerifySignedJar which currently tests nothing.
>
> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
> the JAR i
On Wed, 25 Jan 2023 17:38:13 GMT, Eirik Bjorsnos wrote:
> This PR resurrects VerifySignedJar which currently tests nothing.
>
> VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
> back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
> the JAR i
This PR resurrects VerifySignedJar which currently tests nothing.
VerifySignedJar currently verifies a binary JAR which was signed with SHA-1
back in April 2000. Because SHA-1 signed JARs has been disabled for a while,
the JAR is treated as unsigned so the test doesn't really test anything as of
