Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v4]

2023-01-31 Thread Rajan Halade
On Tue, 31 Jan 2023 18:35:47 GMT, Matthew Donovan wrote: >> * updated test for new TLS protocols and ciphersuites >> * code cleanup > > Matthew Donovan has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains seven commits: > > - fixed Pro

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v4]

2023-01-31 Thread Matthew Donovan
> * updated test for new TLS protocols and ciphersuites > * code cleanup Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - fixed ProblemList - Merge branch 'master' into test-all-suites - removed trai

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v3]

2023-01-31 Thread Rajan Halade
On Tue, 31 Jan 2023 12:42:26 GMT, Matthew Donovan wrote: >> * updated test for new TLS protocols and ciphersuites >> * code cleanup > > Matthew Donovan has updated the pull request incrementally with one > additional commit since the last revision: > > addressed comments test/jdk/ProblemList

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v3]

2023-01-31 Thread Matthew Donovan
> * updated test for new TLS protocols and ciphersuites > * code cleanup Matthew Donovan has updated the pull request incrementally with one additional commit since the last revision: addressed comments - Changes: - all: https://git.openjdk.org/jdk/pull/11780/files - new: htt

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

2023-01-30 Thread Rajan Halade
On Mon, 30 Jan 2023 12:17:10 GMT, Matthew Donovan wrote: >> * updated test for new TLS protocols and ciphersuites >> * code cleanup > > Matthew Donovan has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains three commits: > > - incorpora

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

2023-01-30 Thread Matthew Donovan
On Fri, 27 Jan 2023 21:33:13 GMT, Rajan Halade wrote: >> The test verifies the handshake negotiation for each ciphersuite/protocol >> combination. The `getSupportedCipherSuites()` and `getEnabledCipherSuites()` >> are independent of the enabled protocols. In other words, if you called >> `engi

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 [v2]

2023-01-30 Thread Matthew Donovan
> * updated test for new TLS protocols and ciphersuites > * code cleanup Matthew Donovan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - incorporated Rajan's patch - Merge branch 'master' into test-all-suites - 829

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2023-01-27 Thread Rajan Halade
On Fri, 27 Jan 2023 01:30:59 GMT, Matthew Donovan wrote: >> test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 333: >> >>> 331: >>> 332: enum SupportedCipherSuites { >>> 333: TLSv11("TLSv1.1", new String []{ >> >> Instead of this can we not continue with old approach of using

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2023-01-26 Thread Matthew Donovan
On Thu, 26 Jan 2023 18:33:38 GMT, Rajan Halade wrote: >> * updated test for new TLS protocols and ciphersuites >> * code cleanup > > test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 333: > >> 331: >> 332: enum SupportedCipherSuites { >> 333: TLSv11("TLSv1.1", new String []{

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2023-01-26 Thread Rajan Halade
On Fri, 23 Dec 2022 17:08:03 GMT, Matthew Donovan wrote: > * updated test for new TLS protocols and ciphersuites > * code cleanup test/jdk/javax/net/ssl/SSLEngine/TestAllSuites.java line 2: > 1: /* > 2: * Copyright (c) 2003, 2022, Oracle and/or its affiliates. All rights > reserved. update t

Re: RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2023-01-24 Thread Matthew Donovan
On Fri, 23 Dec 2022 17:08:03 GMT, Matthew Donovan wrote: > * updated test for new TLS protocols and ciphersuites > * code cleanup Can someone take a look at this? Thanks! - PR: https://git.openjdk.org/jdk/pull/11780

RFR: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3

2022-12-23 Thread Matthew Donovan
* updated test for new TLS protocols and ciphersuites * code cleanup - Commit messages: - 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3 Changes: https://git.openjdk.org/jdk/pull/11780/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11780&range=00 Issue: https://b