Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v8]

2024-10-31 Thread Mark Powers
On Mon, 21 Oct 2024 20:42:14 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/provider/ML_DSA.java line 1: >> >>> 1: /* >> >> Does this class need to be public? Many methods are also public - do they >> need to be? > > No need, but Mark's test might be using it. Benchmarks

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v8]

2024-10-21 Thread Weijun Wang
On Mon, 21 Oct 2024 20:07:10 GMT, Sean Mullan wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert "ML-DSA for jarsigner" >> >> This reverts commit cc231109513d0f3a939f0bff92a890ff921d94e0. > > src/java.base/sh

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v8]

2024-10-21 Thread Sean Mullan
On Mon, 21 Oct 2024 15:28:47 GMT, Ben Perez wrote: >> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme >> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on >> https://github.com/openjdk/jdk/pull/21167 > > Ben Perez has updated the pull request increme

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v8]

2024-10-21 Thread Ben Perez
> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme > https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on > https://github.com/openjdk/jdk/pull/21167 Ben Perez has updated the pull request incrementally with one additional commit since the last revision: