Re: RFR: 8298108: Add a regression test for JDK-8297684 [v6]

2022-12-07 Thread Sean Mullan
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v6]

2022-12-07 Thread Severin Gehwolf
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v6]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 17:48:21 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Severin Gehwolf
On Tue, 6 Dec 2022 17:29:40 GMT, Severin Gehwolf wrote: >> test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.java >> line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights >>> reserved. >> >> Did you copy th

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v6]

2022-12-06 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Severin Gehwolf
On Tue, 6 Dec 2022 15:09:25 GMT, Sean Mullan wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust test setup > > test/jdk/java/security/SignedJar/spi-calendar-provider/provider/baz/CalendarDataProviderImpl.jav

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Sean Mullan
On Tue, 6 Dec 2022 11:13:29 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v4]

2022-12-06 Thread Severin Gehwolf
On Tue, 6 Dec 2022 10:50:30 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v5]

2022-12-06 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v4]

2022-12-06 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v3]

2022-12-06 Thread Severin Gehwolf
On Mon, 5 Dec 2022 21:07:20 GMT, Sean Mullan wrote: > Since this is a different way of testing the same underlying issue and the > problem shows up in more than one way, I agree it is a good idea to add > another regression test. However, I would put in the same test directory as > 8280890: te

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v3]

2022-12-05 Thread Sean Mullan
On Mon, 5 Dec 2022 17:56:49 GMT, Severin Gehwolf wrote: >> Please review this test addition as it would have helped discover a >> regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced >> and subsequently backported. What's more, it might help discover similar >> issues goi

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v3]

2022-12-05 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

Re: RFR: 8298108: Add a regression test for JDK-8297684 [v2]

2022-12-05 Thread Severin Gehwolf
> Please review this test addition as it would have helped discover a > regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced > and subsequently backported. What's more, it might help discover similar > issues going forward. Thoughts? > > Testing: Manually produced a build

RFR: 8298108: Add a regression test for JDK-8297684

2022-12-05 Thread Severin Gehwolf
Please review this test addition as it would have helped discover a regression when https://bugs.openjdk.org/browse/JDK-8269039 got introduced and subsequently backported. What's more, it might help discover similar issues going forward. Thoughts? Testing: Manually produced a build without [JD