> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> * Making certain fields final
> * Using enhanced switch
On Wed, 30 Nov 2022 09:22:00 GMT, Per Minborg wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>>
>> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
>> improvement areas were identified including:
>>
>> * Replacing duplicate code segments
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> * Making certain fields final
> * Using enhanced switch
On Tue, 29 Nov 2022 20:25:19 GMT, Alan Bateman wrote:
>> src/jdk.sctp/macosx/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 44:
>>
>>> 42: * Unimplemented.
>>> 43: */
>>> 44: public class SctpChannelImpl extends SctpChannel {
>>
>> Going a bit beyond just updating syntax; but that's a diff
On Tue, 29 Nov 2022 17:17:12 GMT, Daniel Fuchs wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>>
>> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
>> improvement areas were identified including:
>>
>> * Replacing duplicate code segment
On Tue, 29 Nov 2022 17:08:50 GMT, Daniel Fuchs wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>>
>> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
>> improvement areas were identified including:
>>
>> * Replacing duplicate code segment
On Tue, 29 Nov 2022 17:44:18 GMT, Daniel Fuchs wrote:
> It is a bit unusual to use a local class as a holder class (the typical
> manner is to a have a private static final nested class) but we didn't have
> local classes until recently - so maybe that's OK. I assume there's only one
> version
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Tue, 29 Nov 2022 19:24:14 GMT, Roger Riggs wrote:
> There could be more sharing of the unsupported implementation if SctpChannel
> was not abstract and its method bodies threw the exception. There would less
> duplication for unsupported platforms.
I think this is accident of history. As I
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
On Tue, 29 Nov 2022 16:46:43 GMT, Per Minborg wrote:
> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>
> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
> improvement areas were identified including:
>
> * Replacing duplicate code segments
> *
This PR proposes a variety of modernisations to the `jdk.sctp` module.
During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
improvement areas were identified including:
* Replacing duplicate code segments
* Making certain fields final
* Using enhanced switch
* Using records
13 matches
Mail list logo
