Re: RFR: 8297519: Improve expressions and modernise code in PKCS [v3]

2022-11-30 Thread Weijun Wang
On Wed, 30 Nov 2022 08:03:50 GMT, Per Minborg wrote: >> During the work of another PR (https://github.com/openjdk/jdk/pull/11260), >> several improvement areas were identified. These are now adressed in this >> separate PR proposing the use of more modern Java constructs as well as >> simplify

Re: RFR: 8297519: Improve expressions and modernise code [v3]

2022-11-30 Thread Roger Riggs
On Wed, 30 Nov 2022 08:03:50 GMT, Per Minborg wrote: >> During the work of another PR (https://github.com/openjdk/jdk/pull/11260), >> several improvement areas were identified. These are now adressed in this >> separate PR proposing the use of more modern Java constructs as well as >> simplify

Re: RFR: 8297519: Improve expressions and modernise code [v3]

2022-11-30 Thread Weijun Wang
On Wed, 30 Nov 2022 08:03:50 GMT, Per Minborg wrote: >> During the work of another PR (https://github.com/openjdk/jdk/pull/11260), >> several improvement areas were identified. These are now adressed in this >> separate PR proposing the use of more modern Java constructs as well as >> simplify

Re: RFR: 8297519: Improve expressions and modernise code [v3]

2022-11-30 Thread Per Minborg
> During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying a large number of logical expressions that were previou

Re: RFR: 8297519: Improve expressions and modernise code [v2]

2022-11-29 Thread Per Minborg
On Tue, 29 Nov 2022 16:12:11 GMT, Weijun Wang wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update from the first round of comments > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11AEADCipher.java

Re: RFR: 8297519: Improve expressions and modernise code [v2]

2022-11-29 Thread Weijun Wang
On Mon, 28 Nov 2022 11:59:56 GMT, Per Minborg wrote: >> During the work of another PR (https://github.com/openjdk/jdk/pull/11260), >> several improvement areas were identified. These are now adressed in this >> separate PR proposing the use of more modern Java constructs as well as >> simplify

Re: RFR: 8297519: Improve expressions and modernise code [v2]

2022-11-28 Thread Per Minborg
> During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying a large number of logical expressions that were previou

Re: RFR: 8297519: Improve expressions and modernise code

2022-11-27 Thread ExE Boss
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote: > During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying

Re: RFR: 8297519: Improve expressions and modernise code

2022-11-24 Thread Andrey Turbanov
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote: > During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying

Re: RFR: 8297519: Improve expressions and modernise code

2022-11-24 Thread Per Minborg
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote: > During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying

RFR: 8297519: Improve expressions and modernise code

2022-11-24 Thread Per Minborg
During the work of another PR (https://github.com/openjdk/jdk/pull/11260), several improvement areas were identified. These are now adressed in this separate PR proposing the use of more modern Java constructs as well as simplifying a large number of logical expressions that were previously non

Re: RFR: 8297519: Improve expressions and modernise code

2022-11-24 Thread Per Minborg
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote: > During the work of another PR (https://github.com/openjdk/jdk/pull/11260), > several improvement areas were identified. These are now adressed in this > separate PR proposing the use of more modern Java constructs as well as > simplifying