Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-29 Thread Valerie Peng
On Sun, 27 Nov 2022 16:31:22 GMT, Weijun Wang wrote: >> src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java line >> 99: >> >>> 97: } >>> 98: >>> 99: private void makeEncoding(byte[] s) throws InvalidKeyException { >> >> No need for the InvalidKeyException? > > `ECPar

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v4]

2022-11-29 Thread Valerie Peng
On Mon, 28 Nov 2022 22:09:49 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-28 Thread Valerie Peng
On Sun, 27 Nov 2022 16:25:55 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 300: >> >>> 298: * @exception CRLException on encoding errors. >>> 299: */ >>> 300: public byte[] encodeInfo() throws CRLException { >> >> "throw

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v3]

2022-11-28 Thread Weijun Wang
On Mon, 28 Nov 2022 13:40:15 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v4]

2022-11-28 Thread Weijun Wang
> This is mostly cleanup. Everything around `DerOutputStream` no longer throws > an `IOException`. This includes: > > - Remove unnecessary `throws IOException` in code and spec > - Remove `catch (IOException ioe)` blocks. If new exception is thrown, remove > further `throws` in code and spec > -

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v3]

2022-11-28 Thread Sean Mullan
On Mon, 28 Nov 2022 13:40:15 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v3]

2022-11-28 Thread Weijun Wang
On Mon, 28 Nov 2022 13:40:15 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v3]

2022-11-28 Thread Weijun Wang
> This is mostly cleanup. Everything around `DerOutputStream` no longer throws > an `IOException`. This includes: > > - Remove unnecessary `throws IOException` in code and spec > - Remove `catch (IOException ioe)` blocks. If new exception is thrown, remove > further `throws` in code and spec > -

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Weijun Wang
On Sun, 27 Nov 2022 07:57:35 GMT, Valerie Peng wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> one more > > src/java.base/share/classes/sun/security/x509/X509CRLImpl.java line 300: > >> 298: * @exception C

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-27 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-26 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-26 Thread Valerie Peng
On Wed, 23 Nov 2022 19:48:48 GMT, Weijun Wang wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions [v2]

2022-11-23 Thread Weijun Wang
> This is mostly cleanup. Everything around `DerOutputStream` no longer throws > an `IOException`. This includes: > > - Remove unnecessary `throws IOException` in code and spec > - Remove `catch (IOException ioe)` blocks. If new exception is thrown, remove > further `throws` in code and spec > -

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions

2022-11-23 Thread Weijun Wang
On Wed, 23 Nov 2022 12:40:45 GMT, Weijun Wang wrote: >> src/java.base/share/classes/sun/security/x509/CRLExtensions.java line 151: >> >>> 149: >>> 150: DerOutputStream tmp = new DerOutputStream(); >>> 151: if (isExplicit) >> >> Use curley braces. > > I'll do. This is new code.

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions

2022-11-23 Thread Weijun Wang
On Wed, 23 Nov 2022 04:19:42 GMT, Mark Powers wrote: >> src/java.base/share/classes/sun/security/x509/IssuingDistributionPointExtension.java >> line 121: >> >>> 119: boolean hasOnlyUserCerts, boolean hasOnlyCACerts, >>> 120: boolean hasOnlyAttributeCerts, boolean isIndirectCRL)

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions

2022-11-23 Thread Weijun Wang
On Wed, 23 Nov 2022 02:28:44 GMT, Mark Powers wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions

2022-11-22 Thread Mark Powers
On Wed, 23 Nov 2022 03:55:11 GMT, Mark Powers wrote: >> This is mostly cleanup. Everything around `DerOutputStream` no longer throws >> an `IOException`. This includes: >> >> - Remove unnecessary `throws IOException` in code and spec >> - Remove `catch (IOException ioe)` blocks. If new exceptio

Re: RFR: 8297065: DerOutputStream operations should not throw IOExceptions

2022-11-22 Thread Mark Powers
On Tue, 22 Nov 2022 22:29:24 GMT, Weijun Wang wrote: > This is mostly cleanup. Everything around `DerOutputStream` no longer throws > an `IOException`. This includes: > > - Remove unnecessary `throws IOException` in code and spec > - Remove `catch (IOException ioe)` blocks. If new exception is

RFR: 8297065: DerOutputStream operations should not throw IOExceptions

2022-11-22 Thread Weijun Wang
This is mostly cleanup. Everything around `DerOutputStream` no longer throws an `IOException`. This includes: - Remove unnecessary `throws IOException` in code and spec - Remove `catch (IOException ioe)` blocks. If new exception is thrown, remove further `throws` in code and spec - More classes