Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-07 Thread Valerie Peng
On Tue, 6 Sep 2022 22:50:47 GMT, zzambers wrote: >> Thanks for the suggested fix. I share your opinion about the potential race >> condition regarding demoting object session. Will take a look. > > @valeriepeng, Thank you for your review > @zzambers Your change (at version > [713f617](https://

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager [v2]

2022-09-07 Thread Valerie Peng
On Wed, 7 Sep 2022 00:18:00 GMT, zzambers wrote: >> There is a race condition in JDK's SessionManager, which can lead to random >> exceptions. >> >> **Exception:** >> >> javax.net.ssl.SSLException: Internal error: close session with active objects >> at java.base/sun.security.ssl.Alert.cr

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager [v2]

2022-09-06 Thread zzambers
> There is a race condition in JDK's SessionManager, which can lead to random > exceptions. > > **Exception:** > > javax.net.ssl.SSLException: Internal error: close session with active objects > at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:133) > at > java.base/

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-06 Thread zzambers
On Tue, 6 Sep 2022 20:25:13 GMT, Valerie Peng wrote: >> There is a race condition in JDK's SessionManager, which can lead to random >> exceptions. >> >> **Exception:** >> >> javax.net.ssl.SSLException: Internal error: close session with active objects >> at java.base/sun.security.ssl.Aler

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-06 Thread Valerie Peng
On Thu, 1 Sep 2022 17:28:40 GMT, zzambers wrote: > There is a race condition in JDK's SessionManager, which can lead to random > exceptions. > > **Exception:** > > javax.net.ssl.SSLException: Internal error: close session with active objects > at java.base/sun.security.ssl.Alert.createSS

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-06 Thread Valerie Peng
On Tue, 6 Sep 2022 22:16:57 GMT, zzambers wrote: >> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SessionManager.java >> line 210: >> >>> 208: return; >>> 209: } >>> 210: releaseSession(session); >> >> With the described race condition, have you tried fi

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-06 Thread zzambers
On Tue, 6 Sep 2022 21:02:50 GMT, Valerie Peng wrote: >> There is a race condition in JDK's SessionManager, which can lead to random >> exceptions. >> >> **Exception:** >> >> javax.net.ssl.SSLException: Internal error: close session with active objects >> at java.base/sun.security.ssl.Aler

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-06 Thread Valerie Peng
On Thu, 1 Sep 2022 17:28:40 GMT, zzambers wrote: > There is a race condition in JDK's SessionManager, which can lead to random > exceptions. > > **Exception:** > > javax.net.ssl.SSLException: Internal error: close session with active objects > at java.base/sun.security.ssl.Alert.createSS

Re: RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-06 Thread Valerie Peng
On Thu, 1 Sep 2022 17:28:40 GMT, zzambers wrote: > There is a race condition in JDK's SessionManager, which can lead to random > exceptions. > > **Exception:** > > javax.net.ssl.SSLException: Internal error: close session with active objects > at java.base/sun.security.ssl.Alert.createSS

RFR: 8293232: Fix race condition in pkcs11 SessionManager

2022-09-01 Thread zzambers
There is a race condition in JDK's SessionManager, which can lead to random exceptions. **Exception:** javax.net.ssl.SSLException: Internal error: close session with active objects at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:133) at java.base/sun.security.s