Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v4]

2022-07-22 Thread jquanC
On Fri, 22 Jul 2022 17:39:20 GMT, Weijun Wang wrote: > Two comments: > > 1. You reverted the `s/i/buf/` change in `putInteger`. > 2. The other constructor also uses `an DER output steam`. Since you already > fixed one, please take care of this one as well. Got it, I will take care of that. --

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v4]

2022-07-22 Thread Weijun Wang
On Fri, 22 Jul 2022 16:29:55 GMT, jquanC wrote: >> There are some doc errors in sun.security.util.DerOutputStream, like the >> followings, >> >> >> /** >> * Private helper routine for writing DER encoded string values. >> * @param s the string to write >> * @param stringTag one of the DER s

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v4]

2022-07-22 Thread jquanC
> There are some doc errors in sun.security.util.DerOutputStream, like the > followings, > > > /** > * Private helper routine for writing DER encoded string values. > * @param s the string to write > * @param stringTag one of the DER string tags that indicate which > * encoding should be use