Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v3]

2022-07-22 Thread jquanC
On Fri, 22 Jul 2022 17:37:40 GMT, Weijun Wang wrote: > A spec for an argument should be a noun. You can add attributes to describe > it in more detail, which can be an adjective, or even a clause. This is > what's shown in the 2nd line (I cannot call it a sentence because it's just a > noun wi

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v3]

2022-07-22 Thread Weijun Wang
On Fri, 22 Jul 2022 15:56:58 GMT, jquanC wrote: >> src/java.base/share/classes/sun/security/util/DerOutputStream.java line 464: >> >>> 462: * @param stringTag one of the DER string tags that indicate which >>> 463: * encoding should be used to write the string out. >>> 464: * @par

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v3]

2022-07-22 Thread jquanC
On Fri, 22 Jul 2022 15:11:43 GMT, Xue-Lei Andrew Fan wrote: >> jquanC has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8290775: Some doc errors in DerOutputStream.java Update:correct the tense >> problem of expression > > src/java.base/

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v3]

2022-07-22 Thread Xue-Lei Andrew Fan
On Fri, 22 Jul 2022 14:56:34 GMT, jquanC wrote: >> There are some doc errors in sun.security.util.DerOutputStream, like the >> followings, >> >> >> /** >> * Private helper routine for writing DER encoded string values. >> * @param s the string to write >> * @param stringTag one of the DER s

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v3]

2022-07-22 Thread jquanC
> There are some doc errors in sun.security.util.DerOutputStream, like the > followings, > > > /** > * Private helper routine for writing DER encoded string values. > * @param s the string to write > * @param stringTag one of the DER string tags that indicate which > * encoding should be use