Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v2]

2022-07-22 Thread jquanC
On Fri, 22 Jul 2022 12:44:54 GMT, Weijun Wang wrote: > `s/is should used/should be used/`. Thanks for your advice! Yes, the passive voice should be used. I may offer an update like: @param charset the charset should be used corresponding to the above tag. - PR: https://git.openjdk

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v2]

2022-07-22 Thread Weijun Wang
On Fri, 22 Jul 2022 08:27:38 GMT, jquanC wrote: >> There are some doc errors in sun.security.util.DerOutputStream, like the >> followings, >> >> >> /** >> * Private helper routine for writing DER encoded string values. >> * @param s the string to write >> * @param stringTag one of the DER s

Re: RFR: 8290775: Some doc errors in DerOutputStream.java [v2]

2022-07-22 Thread jquanC
> There are some doc errors in sun.security.util.DerOutputStream, like the > followings, > > > /** > * Private helper routine for writing DER encoded string values. > * @param s the string to write > * @param stringTag one of the DER string tags that indicate which > * encoding should be use