Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Thu, 26 Jan 2023 17:39:34 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update with Max's comment > > Yeah, this is a little tricky. My feeling is that if you disable an algorithm > like "RC2

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment Mar

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Thu, 26 Jan 2023 12:30:25 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update with Max's comment > > I said "one solution is to add RC2_40 and RC2_128" but now I'm not sure if > it's the rig

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment Yea

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment I s

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment Yes

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment I t

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

On Fri, 20 Jan 2023 22:03:29 GMT, Hai-May Chao wrote: >> Please review the fix to address the problem in keytool -genseckey and >> -importpass. > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Max's comment Mar

Re: RFR: 8286907: keytool should warn about weak PBE algorithms [v2]

> Please review the fix to address the problem in keytool -genseckey and > -importpass. Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision: Update with Max's comment - Changes: - all: https://git.openjdk.org/jdk/pull/1205

Re: RFR: 8286907: keytool should warn about weak PBE algorithms

On Tue, 17 Jan 2023 23:25:42 GMT, Hai-May Chao wrote: > Please review the fix to address the problem in keytool -genseckey and > -importpass. src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1840: > 1838: } > 1839: > 1840: String[] weakAlgs = new S

RFR: 8286907: keytool should warn about weak PBE algorithms

Please review the fix to address the problem in keytool -genseckey and -importpass. - Commit messages: - 8286907: keytool should warn about weak PBE algorithms Changes: https://git.openjdk.org/jdk/pull/12056/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12056&range=00 I