On Fri, 13 Jan 2023 17:18:41 GMT, Eirik Bjorsnos wrote:
>> Please review this trivial PR which updates javadoc sample code in
>> jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of
>> the now considered weak algorithms SHA-1, SHA1withDSA.
>>
>> The sample code is also upd
On Fri, 13 Jan 2023 17:08:01 GMT, Sean Mullan wrote:
>> This might also be a good opportunity to use the new javadoc @snippet tag
>> (see [JEP 413](url)) which I think has some features to handle the
>> indentation in a consistent manner.
>
> Oh, cool, missed that.
>
> Eirik, this issue is cur
On Fri, 13 Jan 2023 17:18:41 GMT, Eirik Bjorsnos wrote:
>> Please review this trivial PR which updates javadoc sample code in
>> jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of
>> the now considered weak algorithms SHA-1, SHA1withDSA.
>>
>> The sample code is also upd
On Fri, 13 Jan 2023 17:08:01 GMT, Sean Mullan wrote:
>> This might also be a good opportunity to use the new javadoc @snippet tag
>> (see [JEP 413](url)) which I think has some features to handle the
>> indentation in a consistent manner.
>
> Oh, cool, missed that.
>
> Eirik, this issue is cur
> Please review this trivial PR which updates javadoc sample code in
> jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of the
> now considered weak algorithms SHA-1, SHA1withDSA.
>
> The sample code is also updated to use the new snippet syntax.
Eirik Bjorsnos has updated
On Fri, 13 Jan 2023 16:57:36 GMT, Sean Mullan wrote:
>> src/jdk.jartool/share/classes/jdk/security/jarsigner/JarSigner.java line 88:
>>
>>> 86: * signer.sign(in, out);
>>> 87: * }
>>> 88: * }
>>
>> You can probably indent the code so that the last 2 lines do not look
>> strange.
>
> Thi
On Fri, 13 Jan 2023 16:40:03 GMT, Weijun Wang wrote:
>> Please review this trivial PR which updates javadoc sample code in
>> jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of
>> the now considered weak algorithms SHA-1, SHA1withDSA.
>>
>> The sample code is also update
On Fri, 13 Jan 2023 16:23:13 GMT, Eirik Bjorsnos wrote:
> Please review this trivial PR which updates javadoc sample code in
> jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of the
> now considered weak algorithms SHA-1, SHA1withDSA.
>
> The sample code is also updated
Please review this trivial PR which updates javadoc sample code in
jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of the
now considered weak algorithms SHA-1, SHA1withDSA.
The sample code is also updated to use the new snippet syntax.
-
Commit messages:
- R
