On Wed, 24 Aug 2022 05:39:37 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment
-
On Tue, 23 Aug 2022 13:06:12 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comment for import statements
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas
On Tue, 23 Aug 2022 06:39:44 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment for im
On Mon, 22 Aug 2022 19:47:01 GMT, Weijun Wang wrote:
> Approved.
>
> Some tiny comments (sorry for more):
>
> 1. No need to import `Configuration` class now.
>
> 2. No need to import `Paths` class now, or, you can change it to `Path`
> and simplify its reference on line 52.
>
>
> No
On Mon, 22 Aug 2022 18:39:14 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 18:44:21 GMT, Weijun Wang wrote:
> I've submitted the change to our test servers. Will approve the change once
> the job is finished.
Sure thank you!
-
PR: https://git.openjdk.org/jdk/pull/9159
On Mon, 22 Aug 2022 18:39:14 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 18:22:48 GMT, Weijun Wang wrote:
> Please update the copyright line of the test to "Copyright (c) 2022, Red Hat,
> Inc." since this is a new test. No other comment. Thanks for the patience.
Done :)
In fact I have to thank you a lot for such patience to guide me throughout.
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment to upd
On Mon, 22 Aug 2022 18:15:14 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address jcheck space errors a
On Mon, 22 Aug 2022 18:05:11 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
On Mon, 22 Aug 2022 18:05:26 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address jcheck space errors
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Mon, 22 Aug 2022 17:08:09 GMT, Jayashree Huttanagoudar
wrote:
> So the patch should look like :
> ...
Yes. If you decide to print out `s` no matter if success or not, you can move
it out of the if block.
> I tried to execute the test case with this change and I don't see anything
> change
On Mon, 22 Aug 2022 16:07:49 GMT, Weijun Wang wrote:
> Just to clarify, I might have confused the stack trace of the exception
> thrown by the test and the newly printed one thrown inside `LoginContext`. I
> meant the latter, which is captured in `s` and this bug is about its content.
So the p
On Mon, 22 Aug 2022 15:58:49 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Mon, 22 Aug 2022 15:15:07 GMT, Weijun Wang wrote:
> The new `setErr` is good.
>
> You still haven't printed out the stack trace when the test fails. I know
> this has not effect on whether the test fails or not. The benefit of it is
> for diagnosis once the test fails. Has I seen a failure,
On Mon, 22 Aug 2022 14:56:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 22 Aug 2022 08:33:54 GMT, Jayashree Huttanagoudar
wrote:
>> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
>> line 69:
>>
>>> 67: ByteArrayOutputStream stream = new ByteArrayOutputStream();
>>> 68: PrintStream ps = new PrintStream(strea
On Fri, 19 Aug 2022 21:47:00 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
On Fri, 19 Aug 2022 21:35:17 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Fri, 19 Aug 2022 20:29:18 GMT, Jayashree Huttanagoudar
wrote:
> I have included your suggestions for the test case.
> Since we are using `PrintStream` the `flush` is automatically called itseems
> so I didn't see any exception trace in the .jtr file when the test case fails.
This is because
On Fri, 19 Aug 2022 20:33:23 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Thu, 18 Aug 2022 13:18:15 GMT, Jayashree Huttanagoudar
wrote:
>> test/jdk/javax/security/auth/login/LoginContext/OptionalJaas/UnixNTPlatform.java
>> line 85:
>>
>>> 83: byte[] byes = stream.toByteArray();
>>> 84: String s = new String(byes);
>>> 85: System.out.printf
On Thu, 18 Aug 2022 11:48:01 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request with a new target base
>
On Thu, 18 Aug 2022 11:48:01 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request with a new target base
>
On Wed, 17 Aug 2022 17:31:50 GMT, Weijun Wang wrote:
> The test should ensure the stack trace is included in the debug output.
> Please check the content of `s`. Make sure this test succeeds after the code
> change and fails before it.
I have made an attempt to include what you suggested. I di
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains 14 commits:
- M
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address errors by bot to the
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment
-
On Wed, 17 Aug 2022 12:50:37 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address whitespace error by j
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address whitespace error by j
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment to add
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment to rev
On Tue, 16 Aug 2022 14:57:06 GMT, Jayashree Huttanagoudar
wrote:
> That means in the source code here:
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/javax/security/auth/login/LoginContext.java#L881
> ?
Yes.
-
PR: https://git.openjdk.org/jdk/pull/9159
On Tue, 16 Aug 2022 14:50:11 GMT, Weijun Wang wrote:
> > Ok. But the change what I had for LoginContext.java in this commit was not
> > appropriate :
> > [13a51a6](https://github.com/openjdk/jdk/commit/13a51a6d2e026225ec8ac9f1516c7f709c72ce08)
> > right?
>
> No. If you only put the reason ins
On Tue, 16 Aug 2022 13:49:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Tue, 16 Aug 2022 14:32:46 GMT, Weijun Wang wrote:
> The original "cross-platform" case is exactly what this bug is about. The
> overall login succeeds but the reason of the optional login module failure is
> not logged in the debug output. You need to update the source code of
> `LoginConte
On Tue, 16 Aug 2022 13:49:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Tue, 16 Aug 2022 14:17:43 GMT, Weijun Wang wrote:
> Why the new change? The bug is about an optional LoginModule failure not
> logged, and it only happens when there are multiple login modules and the
> overall login succeeds.
Hmm then I misunderstood your previous comment :
>In the "cross-
On Tue, 16 Aug 2022 13:49:34 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment for cr
On Tue, 16 Aug 2022 08:44:03 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 8 Aug 2022 17:34:59 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment for te
On Mon, 15 Aug 2022 15:58:50 GMT, Weijun Wang wrote:
> System.setErr
Looks like call stack info of the exception is not produced for OPTIONAL login
module when debug is on. Here :
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/javax/security/auth/login/LoginContext.java
On Mon, 8 Aug 2022 17:34:59 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Mon, 8 Aug 2022 08:42:11 GMT, Jayashree Huttanagoudar
wrote:
> > BTW, have you reverted your change on `LoginContext.java`. I remembered we
> > agreed that this bug is all about debug info instead of updating the
> > exception thrown.
>
> Actually here:
> https://bugs.openjdk.org/browse/J
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Added test case using {Unix,N
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comments
On Thu, 4 Aug 2022 01:40:36 GMT, Weijun Wang wrote:
> BTW, have you reverted your change on `LoginContext.java`. I remembered we
> agreed that this bug is all about debug info instead of updating the
> exception thrown.
Actually here:
https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%
On Tue, 2 Aug 2022 05:54:13 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Sat, 16 Jul 2022 13:32:44 GMT, Weijun Wang wrote:
>> Jayashree Huttanagoudar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add test case to verify the patch
>
> There are quite some JAAS tests inside `test/jdk/javax/security/auth/lo
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Address review comment to cha
On Sat, 16 Jul 2022 13:32:44 GMT, Weijun Wang wrote:
> There are quite some JAAS tests inside `test/jdk/javax/security/auth/login`
> where you can copy. The one you found has a very old copyright header and
> invalid format (like trailing spaces...). Also, I don't think it's worth
> implementi
On Fri, 15 Jul 2022 13:05:38 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Fri, 15 Jul 2022 13:05:38 GMT, Jayashree Huttanagoudar
wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one
>
On Fri, 8 Jul 2022 13:12:23 GMT, Weijun Wang wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> `SmartLoginModule.java` is a class used by a test, itself is not one since
> there's no `ma
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Jayashree Huttanagoudar has updated the pull request incrementally with one
additional commit since the last revision:
Add test case to verify the p
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
`SmartLoginModule.java` is a class used by a test, itself is not one since
there's
On Fri, 8 Jul 2022 13:12:23 GMT, Weijun Wang wrote:
> `SmartLoginModule.java` is a class used by a test, itself is not one since
> there's no `main()` method.
>
You are right.
> Your new test needs to be a regression test, which means before the fix it
> fails and after the fix it succeeds. Al
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Looks like already the test cases which serve our purpose to test our patch are
alr
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Yes, or you can write an individual test.
-
PR: https://git.openjdk.or
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
Ok. So the steps what I followed to confirm the patch can be converted to test
case
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
It will be nice if the test itself can confirm the correctness since this is
not a
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
I verified the changes with sample example here:
https://web.mit.edu/java_v1.5.0_22
On Wed, 22 Jun 2022 15:18:31 GMT, Weijun Wang wrote:
>> There are several builtin `LoginModule` implementations inside OpenJDK. For
>> example, you can configure both `NTLoginModule` and `UnixLoginModule` as
>> OPTIONAL in your JAAS login configuration file. No matter if you run on
>> Windows
On Wed, 22 Jun 2022 15:10:50 GMT, Weijun Wang wrote:
>> Thanks you both for taking a look at this PR.
>> I will investigate further for suitable suggested changes.
>> Could you please suggest me how I can quickly check whether the changes I
>> made are reflecting properly as expected ?
>
> There
On Wed, 22 Jun 2022 14:12:34 GMT, Jayashree Huttanagoudar
wrote:
>> I have the same suggestion as Sean. In JAAS, login could succeed even if one
>> optional LoginModule failed, and in this case the reason for that failure is
>> lost (even with your current fix). Logging it somewhere might help
On Wed, 22 Jun 2022 13:52:13 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/javax/security/auth/login/LoginContext.java line
>> 887:
>>
>>> 885: (new java.io.PrintWriter(sw));
>>> 886: sw.flush();
>>> 887: le = new Logi
On Wed, 22 Jun 2022 13:10:24 GMT, Sean Mullan wrote:
>> Could you please review the changes?
>> This patch is to address :
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> src/java.base/share/classes/javax/security/auth/login/LoginContext.java line
> 887:
>
>>
On Tue, 14 Jun 2022 19:07:24 GMT, Jayashree Huttanagoudar
wrote:
> Could you please review the changes?
> This patch is to address :
> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
src/java.base/share/classes/javax/security/auth/login/LoginContext.java line
887:
Could you please review the changes?
This patch is to address :
https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
-
Commit messages:
- 8215916: Print out more information as a part of failure reason of an
optional JAAS LoginModule
Changes: https://git.open
89 matches
Mail list logo
