On Thu, 1 May 2025 18:08:40 GMT, Mikhail Yankelevich
wrote:
>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changed file format and throwing
On Thu, 1 May 2025 10:31:20 GMT, Mikhail Yankelevich
wrote:
>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changed file creation to use Uti
On Thu, 1 May 2025 15:34:11 GMT, Rajan Halade wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed file creation to use Utils.createTempFile
>
> test/jdk/sun/security/pkcs12/P12SecretKey.java line 88:
>
On Thu, 1 May 2025 18:08:40 GMT, Mikhail Yankelevich
wrote:
>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changed file format and throwing
> * Changed the test to use scratch directory
> * Cleaned up the imports
Mikhail Yankelevich has updated the pull request incrementally with one
additional commit since the last revision:
changed file format and throwing an exception in case of the failure
-
Changes:
- all: htt
On Thu, 1 May 2025 10:31:20 GMT, Mikhail Yankelevich
wrote:
>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changed file creation to use Uti
On Thu, 1 May 2025 15:25:46 GMT, Weijun Wang wrote:
> LGTM. Or, you can just create files named `algName-keySize.ks`. There is no
> need to be random here.
+1. This would be a good enhancement to include.
-
PR Comment: https://git.openjdk.org/jdk/pull/24718#issuecomment-2845087042
On Thu, 1 May 2025 10:31:20 GMT, Mikhail Yankelevich
wrote:
>> * Changed the test to use scratch directory
>> * Cleaned up the imports
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changed file creation to use Uti
> * Changed the test to use scratch directory
> * Cleaned up the imports
Mikhail Yankelevich has updated the pull request incrementally with one
additional commit since the last revision:
changed file creation to use Utils.createTempFile
-
Changes:
- all: https://git.openjdk.or
On Thu, 1 May 2025 05:00:13 GMT, Rajan Halade wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed file creation to use Utils.createTempFile
>
> test/jdk/sun/security/pkcs12/P12SecretKey.java line 68:
>
On Thu, 17 Apr 2025 09:51:40 GMT, Mikhail Yankelevich
wrote:
> * Changed the test to use scratch directory
> * Cleaned up the imports
test/jdk/sun/security/pkcs12/P12SecretKey.java line 68:
> 66:
> 67: // temporary files are created in scratch directory
> 68: final File ksFile
* Changed the test to use scratch directory
* Cleaned up the imports
-
Commit messages:
- JDK-8183348: Better cleanup for
jdk/test/sun/security/pkcs12/P12SecretKey.java
Changes: https://git.openjdk.org/jdk/pull/24718/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24718&ra
12 matches
Mail list logo
