On Thu, 9 Feb 2023 22:15:07 GMT, Kevin Driver wrote:
>> Updated this `template` file to not fail silently on `canUseProvider` check
>> in debug mode to provide additional information to aid in debugging.
>>
>> See: https://bugs.openjdk.org/browse/JDK-8178806
>
> Kevin Driver has updated the pul
On Thu, 9 Feb 2023 22:16:49 GMT, Valerie Peng wrote:
>> resolved
>
> Also, may just rely on the toString() impl instead of separate handling of
> getClass() and getMessage()?
That change was already in the previous commit.
-
PR: https://git.openjdk.org/jdk/pull/12504
On Thu, 9 Feb 2023 22:10:31 GMT, Kevin Driver wrote:
>> I thought about this, but logically they are not related...
>>
>> I can definitely combine, but I made this choice for readability. What do
>> you think?
>
> resolved
Also, may just rely on the toString() impl instead of separate handlin
On Thu, 9 Feb 2023 21:47:17 GMT, Kevin Driver wrote:
>> src/java.base/share/classes/javax/crypto/JceSecurity.java.template line 240:
>>
>>> 238: Exception e = getVerificationResult(p);
>>> 239: if (debug != null) {
>>> 240: if(e != null) {
>>
>> line 239 and 240 can
> Updated this `template` file to not fail silently on `canUseProvider` check
> in debug mode to provide additional information to aid in debugging.
>
> See: https://bugs.openjdk.org/browse/JDK-8178806
Kevin Driver has updated the pull request incrementally with one additional
commit since the
On Thu, 9 Feb 2023 21:45:35 GMT, Valerie Peng wrote:
>> Updated this `template` file to not fail silently on `canUseProvider` check
>> in debug mode to provide additional information to aid in debugging.
>>
>> See: https://bugs.openjdk.org/browse/JDK-8178806
>
> src/java.base/share/classes/java
On Thu, 9 Feb 2023 21:26:50 GMT, Kevin Driver wrote:
> Updated this `template` file to not fail silently on `canUseProvider` check
> in debug mode to provide additional information to aid in debugging.
>
> See: https://bugs.openjdk.org/browse/JDK-8178806
src/java.base/share/classes/javax/crypt
Updated this `template` file to not fail silently on `canUseProvider` check in
debug mode to provide additional information to aid in debugging.
See: https://bugs.openjdk.org/browse/JDK-8178806
-
Commit messages:
- 8178806: Better exception logging in crypto code
Changes: https://
