Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-20 Thread Sean Coffey
On Tue, 19 Nov 2024 20:56:13 GMT, Bradford Wetmore wrote: >> `sslexpandhandshakeverbose` works in the new implementation. >> >> the `sslOn `boolean is a fast path helper. We fall back to matching per >> debug option if required. >> >> I'm going to suggest that we shouldn't have to accept >>

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-19 Thread Bradford Wetmore
On Tue, 19 Nov 2024 12:38:48 GMT, Sean Coffey wrote: >> With the current definition in the JSSE docs, `sslexpandhandshakeverbose` is >> an acceptable value, as are the tokens in any order. e.g. >> `sslverbosehandshakeexpand` or >> `ssl|moohaha|handshake2354432verbose@#%^%SeanWasHere,keygen`.

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-19 Thread Bradford Wetmore
On Tue, 19 Nov 2024 21:11:41 GMT, Bradford Wetmore wrote: >> thanks for reminder. I've fixed up some lines that had gone a few chars over >> the 80 limit. I thought we'd become a bit more lenient on this advice. It >> got me curious about the current state of src code in the the security base.

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-19 Thread Bradford Wetmore
On Tue, 19 Nov 2024 12:09:07 GMT, Sean Coffey wrote: >> src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java line 1075: >> >>> 1073: if (!isDesired) { >>> 1074: // Too old to use, discard this retransmitted >>> record >>> 1075:

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-19 Thread Sean Coffey
On Fri, 15 Nov 2024 01:12:55 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 90: >> >>> 88: && property.length() == 10 >>> 89: && >>> !Character.isLetterOrDigit(property.charAt(3)) >>> 90:

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-19 Thread Sean Coffey
On Thu, 14 Nov 2024 01:54:03 GMT, Bradford Wetmore wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> keep expand option and add test coverage > > src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java line

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-19 Thread Sean Coffey
On Tue, 12 Nov 2024 11:49:25 GMT, Sean Coffey wrote: >> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation >> was introduced many years ago. >> >> Where "ssl" was previously a value to obtain all TLS debug traces (except >> network type dumps, verbose data), it now pr

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-14 Thread Bradford Wetmore
On Tue, 12 Nov 2024 11:49:25 GMT, Sean Coffey wrote: >> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation >> was introduced many years ago. >> >> Where "ssl" was previously a value to obtain all TLS debug traces (except >> network type dumps, verbose data), it now pr

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-14 Thread Bradford Wetmore
On Thu, 14 Nov 2024 00:20:06 GMT, Bradford Wetmore wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> keep expand option and add test coverage > > src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 90: >

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-13 Thread Bradford Wetmore
On Tue, 12 Nov 2024 11:44:48 GMT, Sean Coffey wrote: >> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 91: >> >>> 89: System.err.println(); >>> 90: System.err.println("help print the help messages"); >>> 91: System.err.println("expand e

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-13 Thread Bradford Wetmore
On Tue, 12 Nov 2024 11:49:25 GMT, Sean Coffey wrote: >> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation >> was introduced many years ago. >> >> Where "ssl" was previously a value to obtain all TLS debug traces (except >> network type dumps, verbose data), it now pr

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-12 Thread Sean Coffey
On Sat, 9 Nov 2024 02:07:03 GMT, Bradford Wetmore wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> keep expand option and add test coverage > > src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 91: >

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v8]

2024-11-12 Thread Sean Coffey
> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation > was introduced many years ago. > > Where "ssl" was previously a value to obtain all TLS debug traces (except > network type dumps, verbose data), it now prints only a few lines for a > standard client TLS connectio