Re: RFR: 8009550: PlatformPCSC should load versioned so [v2]

2023-10-30 Thread Andrew John Hughes
On Tue, 5 Sep 2023 10:17:31 GMT, Andrew John Hughes wrote: >> There is a long standing limitation in the UNIX smartcardio implementation >> which means it will only look for the `pcsclite` library in two locations; >> `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned >>

Re: RFR: 8009550: PlatformPCSC should load versioned so [v2]

2023-10-26 Thread Thomas Stuefe
On Thu, 26 Oct 2023 14:19:32 GMT, Andrew John Hughes wrote: >>> > Hi @gnu-andrew, >>> > in your last example, why does it look for both arm and x64 packages? And >>> > why for kFreeBsd? I see you have both hardcoded, why? >>> > I would expect it only to attempt and pick up the architecture and O

Re: RFR: 8009550: PlatformPCSC should load versioned so [v2]

2023-10-26 Thread Andrew John Hughes
On Wed, 30 Aug 2023 06:25:44 GMT, Thomas Stuefe wrote: >>> Changes look fine. I submitted a mach5 test job just in case. Will approve >>> once the test job passes. BTW, I added a noreg-other label since there is >>> no regression test for this change. >> >> Thanks. Yes, I don't see how we can

Re: RFR: 8009550: PlatformPCSC should load versioned so [v2]

2023-09-05 Thread Andrew John Hughes
On Wed, 30 Aug 2023 06:25:44 GMT, Thomas Stuefe wrote: >>> Changes look fine. I submitted a mach5 test job just in case. Will approve >>> once the test job passes. BTW, I added a noreg-other label since there is >>> no regression test for this change. >> >> Thanks. Yes, I don't see how we can

Re: RFR: 8009550: PlatformPCSC should load versioned so [v2]

2023-09-05 Thread Andrew John Hughes
On Wed, 30 Aug 2023 06:25:44 GMT, Thomas Stuefe wrote: > Yes, that's a bit tricky. I was concerned about the JVM picking up the wrong > library on a mulitarch system, since having multiple of these directories is > the point of multiarch. > If the architecture is not 32-bit arm and the librar

Re: RFR: 8009550: PlatformPCSC should load versioned so [v2]

2023-09-05 Thread Andrew John Hughes
> There is a long standing limitation in the UNIX smartcardio implementation > which means it will only look for the `pcsclite` library in two locations; > `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned > library. > > On systems that separate libraries from developmen

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Thomas Stuefe
On Wed, 30 Aug 2023 01:06:01 GMT, Andrew John Hughes wrote: >> Changes look fine. I submitted a mach5 test job just in case. Will approve >> once the test job passes. >> BTW, I added a noreg-other label since there is no regression test for this >> change. > >> Changes look fine. I submitted a

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Thomas Stuefe
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote: > There is a long standing limitation in the UNIX smartcardio implementation > which means it will only look for the `pcsclite` library in two locations; > `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned > li

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Andrew John Hughes
On Fri, 25 Aug 2023 00:39:14 GMT, Valerie Peng wrote: > Changes look fine. I submitted a mach5 test job just in case. Will approve > once the test job passes. BTW, I added a noreg-other label since there is no > regression test for this change. Thanks. Yes, I don't see how we can have a regres

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-29 Thread Andrew John Hughes
On Fri, 25 Aug 2023 05:39:39 GMT, Thomas Stuefe wrote: > Hi @gnu-andrew, > > in your last example, why does it look for both arm and x64 packages? And why > for kFreeBsd? I see you have both hardcoded, why? > > I would expect it only to attempt and pick up the architecture and OS the VM > was

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-24 Thread Thomas Stuefe
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote: > There is a long standing limitation in the UNIX smartcardio implementation > which means it will only look for the `pcsclite` library in two locations; > `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned > li

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-24 Thread Valerie Peng
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote: > There is a long standing limitation in the UNIX smartcardio implementation > which means it will only look for the `pcsclite` library in two locations; > `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned > li

Re: RFR: 8009550: PlatformPCSC should load versioned so

2023-08-24 Thread Valerie Peng
On Thu, 24 Aug 2023 00:53:03 GMT, Andrew John Hughes wrote: > There is a long standing limitation in the UNIX smartcardio implementation > which means it will only look for the `pcsclite` library in two locations; > `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned > li

RFR: 8009550: PlatformPCSC should load versioned so

2023-08-23 Thread Andrew John Hughes
There is a long standing limitation in the UNIX smartcardio implementation which means it will only look for the `pcsclite` library in two locations; `/usr/lib` and `/usr/local/lib`. It also only searches for an unversioned library. On systems that separate libraries from development headers in