Re: RFR: 4936767: Parameters for MessageDigest [v6]

2024-12-05 Thread Weijun Wang
On Mon, 20 Nov 2023 17:08:15 GMT, Weijun Wang wrote: >> Weijun Wang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - more spec change, restruct SHAKE256.java >> - Revert "throw iape" >> >>This reverts commit d01bf93999d85081734

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2024-12-05 Thread Kevin Driver
On Mon, 20 Nov 2023 17:08:15 GMT, Weijun Wang wrote: >> Weijun Wang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - more spec change, restruct SHAKE256.java >> - Revert "throw iape" >> >>This reverts commit d01bf93999d85081734

Re: RFR: 4936767: Parameters for MessageDigest [v8]

2023-11-21 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce new `MessageDigest` > algorithms 'SHAKE128-LEN` and `SHAKE256-LEN` with an integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: useless imports - Changes:

Re: RFR: 4936767: Parameters for MessageDigest [v7]

2023-11-20 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contai

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2023-11-20 Thread Weijun Wang
On Mon, 20 Nov 2023 17:07:12 GMT, Weijun Wang wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > Weijun Wang has updated the pull request incrementally with two additional > commits since the last revision: > > - more spec change, restru

Re: RFR: 4936767: Parameters for MessageDigest [v6]

2023-11-20 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with two additional commits since the last revision: - more spec change, restruct SHAKE256.java - Revert "throw iape" This reverts commit

Re: RFR: 4936767: Parameters for MessageDigest [v5]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: no len no params - Changes: - all: https://git.openjdk.org/jdk/pull/16660/fi

Re: RFR: 4936767: Parameters for MessageDigest [v3]

2023-11-17 Thread Weijun Wang
On Fri, 17 Nov 2023 20:22:49 GMT, Kevin Driver wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> cite resources > > src/java.base/share/classes/sun/security/provider/SHAKE256.java line 27: > >> 25: package sun.securi

Re: RFR: 4936767: Parameters for MessageDigest [v4]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: full imports - Changes: - all: https://git.openjdk.org/jdk/pull/16660/files

Re: RFR: 4936767: Parameters for MessageDigest [v3]

2023-11-17 Thread Kevin Driver
On Fri, 17 Nov 2023 15:49:56 GMT, Weijun Wang wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > cite resources src/java.b

Re: RFR: 4936767: Parameters for MessageDigest [v2]

2023-11-17 Thread Weijun Wang
On Fri, 17 Nov 2023 15:28:53 GMT, Weijun Wang wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > throw iape New commits pu

Re: RFR: 4936767: Parameters for MessageDigest [v3]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: cite resources - Changes: - all: https://git.openjdk.org/jdk/pull/16660/file

Re: RFR: 4936767: Parameters for MessageDigest [v2]

2023-11-17 Thread Weijun Wang
> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: throw iape - Changes: - all: https://git.openjdk.org/jdk/pull/16660/files

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-17 Thread Weijun Wang
On Wed, 15 Nov 2023 21:40:10 GMT, Kevin Driver wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > src/java.base/share/classes/sun/security/ec/ed/EdDSASignature.java line 31: > >> 29: >> 30: import java.io.ByteArrayOutputStream; >> 31: imp

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-17 Thread Weijun Wang
On Wed, 15 Nov 2023 22:24:00 GMT, Sean Mullan wrote: >> This is following the `SecureRandom` style where there are both >> `getInstance` methods that has or has not the parameters argument. If you >> think IAPE is better I can also throw it. `CertStore` does this way and it >> has a dedicated

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Sean Mullan
On Wed, 15 Nov 2023 20:46:27 GMT, Weijun Wang wrote: >> src/java.base/share/classes/java/security/MessageDigest.java line 436: >> >>> 434: * {@code MessageDigestSpi} implementation for the >>> 435: * specified algorithm and parameters >>> 436: * >> >> Is there a r

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Kevin Driver
On Tue, 14 Nov 2023 17:21:53 GMT, Weijun Wang wrote: > Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. src/java.base/share/classes/sun/security/ec/ed/EdDSASignature.java line 31: > 29: > 30: import java.io.ByteArrayOutputStream; > 31: import java.se

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Weijun Wang
On Tue, 14 Nov 2023 17:21:53 GMT, Weijun Wang wrote: > Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. There are multiple places where `MessageDigest` claims it has a fixed length digest output. We can discuss more on whether we can provide the XOF f

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Weijun Wang
On Wed, 15 Nov 2023 18:56:11 GMT, Sean Mullan wrote: >> Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an >> integer parameter. > > src/java.base/share/classes/java/security/MessageDigest.java line 436: > >> 434: * {@code MessageDigestSpi} implementation for th

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Ferenc Rakoczi
On Tue, 14 Nov 2023 17:21:53 GMT, Weijun Wang wrote: > Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. SHAKE is also an eXtensible Output Function, and Kyber is using it that way. In my preliminary Kyber implementation I just added a squeeze() method

Re: RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Sean Mullan
On Tue, 14 Nov 2023 17:21:53 GMT, Weijun Wang wrote: > Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an > integer parameter. src/java.base/share/classes/java/security/MessageDigest.java line 436: > 434: * {@code MessageDigestSpi} implementation for the > 435:

RFR: 4936767: Parameters for MessageDigest

2023-11-15 Thread Weijun Wang
Add parameters to `MessageDigest` and introduce `SHAKE256-LEN` with an integer parameter. - Commit messages: - new class spec - more changes - initial change Changes: https://git.openjdk.org/jdk/pull/16660/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16660&range=00 I