Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v40]

2024-09-17 Thread Viktor Klang
On Tue, 17 Sep 2024 07:06:14 GMT, Viktor Klang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> IDE formatting broke snippet > > src/java.base/share/classes/com/sun/crypto/provider/HKD

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v40]

2024-09-17 Thread Viktor Klang
On Mon, 16 Sep 2024 19:21:13 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8299419: Thread.sleep(millis) may throw OOME

2024-09-10 Thread Viktor Klang
On Mon, 9 Sep 2024 20:40:22 GMT, Viktor Klang wrote: > This PR applies @AlanBateman's patch from the JBS issue. @DougLea @AlanBateman This patch seems to side-step the issues we saw with OOME-on-sleep. Which coincidentally should also harden TestDisposerRace.java so if we get th

RFR: 8299419: Thread.sleep(millis) may throw OOME

2024-09-10 Thread Viktor Klang
This PR applies @AlanBateman's patch from the JBS issue. - Commit messages: - Hardening Thread::beforeSleep to not be able to throw OOME as per Alan Batemans ThreadSleepEvent.patch Changes: https://git.openjdk.org/jdk/pull/20923/files Webrev: https://webrevs.openjdk.org/?repo=jdk

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 17:50:19 GMT, Kevin Driver wrote: >> I'd recommend documenting above this line what function the lock is >> intending to serve, and by each of the members that it guards accesses to. >> Something like "//guarded by 'lock'". >> >> Also, ook into whether the members guarded by

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v24]

2024-09-06 Thread Viktor Klang
On Thu, 5 Sep 2024 23:17:32 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

2024-09-05 Thread Viktor Klang
On Fri, 30 Aug 2024 23:26:12 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-09-05 Thread Viktor Klang
On Tue, 3 Sep 2024 20:16:23 GMT, Valerie Peng wrote: >> @valeriepeng: >> >> I did some research. Based upon what I have seen, no `volatile` keyword is >> required here. This is also consistent with the `Cipher` API, for example. >> >> @ascarpino: >> >> I looked up `ReentrantLock`s, and I’m n

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

2024-09-05 Thread Viktor Klang
On Fri, 30 Aug 2024 23:26:12 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

2024-09-05 Thread Viktor Klang
On Fri, 30 Aug 2024 23:26:12 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-09-05 Thread Viktor Klang
On Fri, 16 Aug 2024 18:25:19 GMT, Kevin Driver wrote: >> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java >> line 144: >> >>> 142: salt = consolidateKeyMaterial(salts); >>> 143: } catch (InvalidKeyException ike) { >>> 144: th

Re: RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

2023-01-19 Thread Viktor Klang
On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad wrote: >> Went through the jdk and found a few more places where >> `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc >> methods could be replaced with a plain call to `java.util.Arrays` >> equivalents. This patch addresses