On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> merge or a rebase. The incremen
On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 7 May 2025 18:33:11 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 10 Mar 2025 19:45:53 GMT, Chen Liang wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> src/hotspot/share/ci/ciField.cpp line 255:
>
>> 253: static bool trust_final_non_static_fields_of_type(Symbol* signature) {
>> 254: return signature == vmSymbols::java_lang_Sta
On Tue, 11 Mar 2025 19:04:39 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/StableValue.java line 344:
>>
>>> 342: * {@linkplain java.lang.ref##reachability reachable} stable values
>>> will hold their set
>>> 343: * content perpetually.
>>> 344: *
>>
>> Should the origina
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 246 commits:
- Merge branch 'master' into implement-jep502
- Clean up exception messag
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Clean up exception messages and fix comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename field
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- new: https://git.op
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename method and fix comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- n
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rework reenterant logic
-
Changes:
- all: https://git.openjdk.org/jdk/pull/23972/files
- n
On Tue, 11 Mar 2025 07:50:38 GMT, Quan Anh Mai wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> src/java.base/share/classes/java/util/ImmutableCollections.java line 777:
>
>> 775: private final IntFunction mapper;
>> 776: @Stable
>> 777: private fi
On Wed, 12 Mar 2025 14:38:28 GMT, Luca Kellermann wrote:
>> This is something we experimented with a bit in the past. It isn't easy to
>> do in the general case. There are pros (the function and its resources that
>> can be collected) and cons (e.g., mutability, visibility, complexity, etc.)
>
On Tue, 11 Mar 2025 08:44:51 GMT, Per Minborg wrote:
>> What if instead you had a `@Stable` array of Object of the appropriate size,
>> and populated each cell with a StableValue if the corresponding index was in
>> the set, otherwise used a sentinel value. Then on the loo
On Wed, 12 Mar 2025 14:14:59 GMT, Per Minborg wrote:
>> You can probably use `acquire` only for the first `get` as it is in the fast
>> path. For other I guess `volatile` is fine.
>
> Yeah. Maybe that could strike a balance.
On an M1 Mac:
Volatile:
StableValueBenchmark.
On Tue, 11 Mar 2025 00:40:31 GMT, Johannes Graham wrote:
>> Indeed, a bit set predicate can be used to check input validity if it is
>> necessary - I think for enums, using a `StableFunction.ofEnum` dedicated API
>> might be better just because `StableValue` can access
>> `Class.getEnumConstan
On Wed, 12 Mar 2025 13:28:12 GMT, Maurizio Cimadamore
wrote:
>> What would be the difference between `@Stable StableValueImpl[] backing`
>> and `@Stable Object[] backing`?
>
> It's true that the storage can be flatter here -- that said, this can also be
> done as a later refactoring. One advan
On Tue, 11 Mar 2025 16:15:10 GMT, Quan Anh Mai wrote:
>> Can you please elaborate a bit more on your proposal @merykitty?
>
> If you have an `@Stable Object[]`, then the elements are also considered
> `@Stable`. Then you can do something like:
>
> ReentrantLock[] locks;
>
> T get(int i
On Tue, 11 Mar 2025 01:20:16 GMT, Johannes Graham wrote:
>> Implement JEP 502.
>>
>> The PR passes tier1-tier3 tests.
>
> src/java.base/share/classes/java/util/ImmutableCollections.java line 772:
>
>> 770:
>> 771: @jdk.internal.ValueBased
>> 772: static final class StableList extends A
On Mon, 10 Mar 2025 18:11:23 GMT, Per Minborg wrote:
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
Here are the current benchmarks for Mac M1:
Benchmark Mode Cnt Score Error Units
StableFunctionBenchmark.function
Implement JEP 502.
The PR passes tier1-tier3 tests.
-
Commit messages:
- Use acquire semantics for reading rather than volatile semantics
- Add missing null check
- Simplify handling of sentinel, wrap, and unwrap
- Fix JavaDoc issues
- Fix members in StableEnumFunction
- Addres
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote:
> This PR proposes to use `StaticProperty.javaHome()` instead of
> `System.getPropoerty("java.home")` in some internal classes.
This pull request has now been integrated.
Changeset: fc2da15b
Author:Per Minborg
U
This PR proposes to use `StaticProperty.javaHome()` instead of
`System.getPropoerty("java.home")` in some internal classes.
-
Commit messages:
- Update copyright year
- Move imports
- Revert erroneous revert
- Remove trailing spaces
- Revert line break
- Revert changes to Java
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote:
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
Could we add some tests also?
-
PR Comment: https://git.openjdk.org/jdk/pull/22339#issuecomment-249708
On Thu, 24 Nov 2022 08:13:58 GMT, Per Minborg wrote:
> This PR proposes declaring some fields as `final` to potentially unlock
> performance optimisations and improve thread visibility (e.g. for GC
> threads). The PR also fixes a "synchronising on a non-final field"
> an
On Wed, 7 Dec 2022 21:55:43 GMT, Per Minborg wrote:
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
This pull request has been
On Thu, 8 Dec 2022 08:17:44 GMT, Per Minborg wrote:
>> This PR suggests renaming various names from "session" to "scope" in
>> accordance with https://openjdk.org/jeps/434
>>
>> The PRs contains changes for several sub-components.
>
> Per Minbo
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
Per Minborg has updated the pull request incrementally with one additional
commit si
This PR suggests renaming various names from "session" to "scope" in accordance
with https://openjdk.org/jeps/434
The PRs contains changes for several sub-components.
-
Commit messages:
- Rename session to scope
Changes: https://git.openjdk.org/jdk/pull/11573/files
Webrev: https:
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote:
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
> a
be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now co
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote:
> During the work of another PR (https://github.com/openjdk/jdk/pull/11260),
> several improvement areas were identified. These are now adressed in this
> separate PR proposing the use of more modern Java constructs as well as
>
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances t
* Using enhanced switch
> * Using records
> * Fixing typos
> * Marking fields participating in serialisation with `@Serial`
> * Modernizing toString() implementations
> * Using pattern matching
> * Using diamond operators
Per Minborg has updated the pull request increment
* Using enhanced switch
> * Using records
> * Fixing typos
> * Marking fields participating in serialisation with `@Serial`
> * Modernizing toString() implementations
> * Using pattern matching
> * Using diamond operators
Per Minborg has updated the pull request increment
On Tue, 29 Nov 2022 20:25:19 GMT, Alan Bateman wrote:
>> src/jdk.sctp/macosx/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 44:
>>
>>> 42: * Unimplemented.
>>> 43: */
>>> 44: public class SctpChannelImpl extends SctpChannel {
>>
>> Going a bit beyond just updating syntax; but that's a diff
On Tue, 29 Nov 2022 17:17:12 GMT, Daniel Fuchs wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>>
>> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
>> improvement areas were identified including:
>>
>> * Replacing duplicate code segment
On Tue, 29 Nov 2022 17:08:50 GMT, Daniel Fuchs wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>>
>> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
>> improvement areas were identified including:
>>
>> * Replacing duplicate code segment
On Tue, 29 Nov 2022 17:44:18 GMT, Daniel Fuchs wrote:
> It is a bit unusual to use a local class as a holder class (the typical
> manner is to a have a private static final nested class) but we didn't have
> local classes until recently - so maybe that's OK. I assume there's only one
> version
ns that were previously
> non-normative.
>
>
> This branch has been tested and passed tier1-4 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove switch and use pattern matching
-
Changes:
- all: htt
On Tue, 29 Nov 2022 16:12:11 GMT, Weijun Wang wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update from the first round of comments
>
> src/jdk.crypto.cryptoki/share/classes/sun/secu
On Thu, 24 Nov 2022 08:19:17 GMT, Per Minborg wrote:
> This PR proposes adding `@Serial` annotations to certain fields participating
> in serialisation.
This pull request has now been integrated.
Changeset: f05bfb15
Author: Per Minborg
Committer: Julian Waters
URL:
This PR proposes a variety of modernisations to the `jdk.sctp` module.
During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several
improvement areas were identified including:
* Replacing duplicate code segments
* Making certain fields final
* Using enhanced switch
* Using records
be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rem
On Mon, 28 Nov 2022 19:35:24 GMT, Paul Sandoz wrote:
> I prefer methods that do not expose the scope implementation so access is
> limited to just to the acquire/release methods, but i am unsure of the
> performance implications. These methods might not reliably inline, and we may
> need to en
ns that were previously
> non-normative.
>
>
> This branch has been tested and passed tier1-4 tests.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update from the first round of comments
-
Changes:
- all: htt
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incre
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increm
On Thu, 24 Nov 2022 16:21:42 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances t
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremen
On Thu, 24 Nov 2022 12:06:44 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundant method
>
> src/java.base/share/classes/sun/nio/ch/IOUtil.java l
On Thu, 24 Nov 2022 11:58:12 GMT, Maurizio Cimadamore
wrote:
>> Separately, also (optional) stylistic: the indenting on this and following
>> class is a bit odd. There is a certain tendency to compress lines - e.g. to
>> reach for one-liners, when in reality the body is not that trivial. If I
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increme
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote:
> During the work of another PR (https://github.com/openjdk/jdk/pull/11260),
> several improvement areas were identified. These are now adressed in this
> separate PR proposing the use of more modern Java constructs as well as
>
During the work of another PR (https://github.com/openjdk/jdk/pull/11260),
several improvement areas were identified. These are now adressed in this
separate PR proposing the use of more modern Java constructs as well as
simplifying a large number of logical expressions that were previously
non
On Thu, 24 Nov 2022 08:24:37 GMT, Per Minborg wrote:
> During the work of another PR (https://github.com/openjdk/jdk/pull/11260),
> several improvement areas were identified. These are now adressed in this
> separate PR proposing the use of more modern Java constructs as well as
>
This PR proposes adding `@Serial` annotations to certain fields participating
in serialisation.
-
Commit messages:
- Annotate serailzation fields with @Serial
Changes: https://git.openjdk.org/jdk/pull/11347/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11347&range=00
Is
This PR proposes declaring some fields as `final` to potentially unlock
performance optimisations and improve thread visibility (e.g. for GC threads).
The PR also fixes a "synchronising on a non-final field" anti-pattern.
-
Commit messages:
- Declare fields and classes final
Chang
On Wed, 23 Nov 2022 16:14:52 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup
>
> src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java li
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull reques
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremen
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
On Tue, 22 Nov 2022 09:23:40 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rework Acquisition
>
> src/java.base/share/classes/com/sun/crypto/provider/Galo
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
On Mon, 21 Nov 2022 20:06:20 GMT, Alan Bateman wrote:
>>> > Although this looks much simpler and concise, it means "a new object is
>>> > created for each invocation"
>>>
>>> My comment was actually to see if DirectBuffer could extend AutoCloseable
>>> so that the acquire returns "this" for th
On Mon, 21 Nov 2022 14:07:38 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/java/util/zip/Adler32.java line 105:
&g
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
On Mon, 21 Nov 2022 14:14:14 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java
>>
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has refreshed the contents of this p
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incr
On Mon, 21 Nov 2022 13:32:43 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/sun/nio/ch/DirectBuffer.java line 41:
&g
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request inc
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incre
On Mon, 21 Nov 2022 12:19:21 GMT, Alan Bateman wrote:
>> maybe just `bufferLock` and and just `acquireBuffer` ?
>
> Would it be possible to re-examine acquireSession returning Runnable and
> acquireSessionAsAutoCloseable returning AutoCloseable. The naming is bit
> awkward at most of the use si
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increm
ress` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
On Mon, 21 Nov 2022 11:32:35 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed b
On Mon, 21 Nov 2022 11:29:07 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed b
This PR proposes the introduction of **guarding** of the use of
`DirectBuffer::address` within the JDK. With the introduction of the Foreign
Function and Memory access, it is possible to derive Buffer instances that are
backed by native memory that, in turn, can be closed asynchronously by the u
78 matches
Mail list logo
