On Fri, 23 May 2025 14:59:07 GMT, Nizar Benalla wrote:
>> Please review this patch to fix some `javadoc` bugs in `java.base`.
>> Certain `@link` tags used to refer to private fields instead of public APIs.
>>
>> A couple of `@see` tags in the [serialization
>> p
On Sat, 17 May 2025 19:42:39 GMT, Nizar Benalla wrote:
> Please review this patch to fix some `javadoc` bugs in `java.base`.
> Certain `@link` tags used to refer to private fields instead of public APIs.
>
> A couple of `@see` tags in the [serialization
> page](https://downloa
lized-form.html#java.lang.invoke.MethodType)
> referred to private methods, I updated the javadoc in a way to not change
> the way it is displayed to users but also remove `@link` tags to non-included
> types.
>
> TIA
Nizar Benalla has updated the pull request incrementally with one add
lized-form.html#java.lang.invoke.MethodType)
> referred to private methods, I updated the javadoc in a way to not change
> the way it is displayed to users but also remove `@link` tags to non-included
> types.
>
> TIA
Nizar Benalla has updated the pull request incrementally with one add
On Mon, 19 May 2025 20:41:13 GMT, Joe Darcy wrote:
>> They are documented in [this
>> page](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.lang.invoke.MethodType)
>
> Okay -- if there is some link to the private serial-related methods even in a
> public jav
Please review this patch to fix some `javadoc` bugs in `java.base`.
Certain `@link` tags used to refer to private fields instead of public APIs.
A couple of `@see` tags in the [serialization
page](https://download.java.net/java/early_access/jdk25/docs/api/serialized-form.html#java.lang.invoke.Met
On Sun, 18 May 2025 02:18:24 GMT, Chen Liang wrote:
>> Please review this patch to fix some `javadoc` bugs in `java.base`.
>> Certain `@link` tags used to refer to private fields instead of public APIs.
>>
>> A couple of `@see` tags in the [serialization
>> page](https://download.java.net/java/
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to mostly add missing `@serial` javadoc
>> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the
>> javadoc `-serialwarn` option in the JDK doc build, which has been disabled
>> since
On Fri, 8 Nov 2024 15:22:43 GMT, Nizar Benalla wrote:
> Can I please get a review for this PR that add tests to verify the value of
> `@since` tags to the Serviceability area modules. The test is described in
> this
> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October
On Thu, 14 Nov 2024 01:35:10 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Serviceability area modules. The test is described in
>> this
>> [email](https://mail.openjdk.org/pipermail/jdk
hether it's a missing `@since` or something else)
>
> TIA
Nizar Benalla has updated the pull request incrementally with two additional
commits since the last revision:
- fix a couple mistakes in jtreg comment
- Revert "remove backticks"
This reverts commit 496ca
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It
On Sat, 20 Jul 2024 15:10:10 GMT, Alan Bateman wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/classes/java/lang/foreign/MemorySegment.java
>>
>
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 13:08:06 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
> If using `{@docroot}` isn't ideal I can change it.
>
>
On Fri, 19 Jul 2024 12:44:47 GMT, Daniel Jeliński wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove docroot based on review
>
> src/java.base/share/classes/java/util/concu
Can I get a review for this change that fixes some broken links in javadoc
comments? The new docs are hosted
[here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
It's mostly fixing some relative links.
If using `{@docroot}` isn't ideal I can change it.
Here is the res
On Sat, 11 May 2024 16:01:34 GMT, Nizar Benalla wrote:
> Code cleanup. The package was added back in
> [8056174](https://bugs.openjdk.org/browse/JDK-8056174).
> Thanks to anyone reviewing this change. I split my changes into 1 PR per
> module to make reviewing simpler.
This pull
On Sat, 11 May 2024 16:01:34 GMT, Nizar Benalla wrote:
> Code cleanup. The package was added back in
> [8056174](https://bugs.openjdk.org/browse/JDK-8056174).
> Thanks to anyone reviewing this change. I split my changes into 1 PR per
> module to make reviewing simpler.
Yo
On Sat, 11 May 2024 15:46:20 GMT, Nizar Benalla wrote:
> Simple code cleanup. I split my changes into 1 PR per module to make
> reviewing simpler.
> This was added back in [JDK
> 13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040)
> and should
On Sat, 11 May 2024 15:46:20 GMT, Nizar Benalla wrote:
> Simple code cleanup. I split my changes into 1 PR per module to make
> reviewing simpler.
> This was added back in [JDK
> 13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040)
> and should
Code cleanup. The package was added back in
[8056174](https://bugs.openjdk.org/browse/JDK-8056174).
Thanks to anyone reviewing this change.
-
Commit messages:
- add an `@since` and modify Copyright header
Changes: https://git.openjdk.org/jdk/pull/19191/files
Webrev: https://webre
Simple code cleanup.
This was added back in [JDK
13](https://github.com/openjdk/jdk/commit/71825293eb83d7c9ac122c11a12465c2acbec040)
and should have an `@since`
-
Commit messages:
- add an `@since` and modify Copyright header
Changes: https://git.openjdk.org/jdk/pull/19190/files
On Tue, 19 Mar 2024 11:15:56 GMT, Nizar Benalla wrote:
> For context, I am writing tests to check for accurate use of `@since` tags in
> documentation comments in source code.
> We're following these rules for now:
>
> ### Rule 1: Introduction of New Elements
>
> - I
java.security.interfaces.XECPrivateKey
> java.security.interfaces.EdECPrivateKey
> java.security.interfaces.ECPublicKey
> java.security.interfaces.EdECPublicKey
> javax.crypto.interfaces.DHPrivateKey
> javax.crypto.interfaces.DHPublicKey
> java.security.interfaces.RSAPublicKey
> java.security.interfaces.RS
java.security.interfaces.XECPrivateKey
> java.security.interfaces.EdECPrivateKey
> java.security.interfaces.ECPublicKey
> java.security.interfaces.EdECPublicKey
> javax.crypto.interfaces.DHPrivateKey
> javax.crypto.interfaces.DHPublicKey
> java.security.interfaces.RSAPublicKey
> java.security.interfaces.R
ocs somewhere if that is needed.
>
> src="https://github.com/openjdk/jdk/assets/96922791/89b92288-9b5e-48ed-8fa1-9342ea43e043";>
>
> src="https://github.com/openjdk/jdk/assets/96922791/9aef08ff-5030-4189-a996-582a7eef849b";>
>
> src="htt
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@sin
On Mon, 29 Apr 2024 17:26:53 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 345:
>>
>>> 343: * @throwsIllegalArgumentException {@inheritDoc}
>>> 344: * @throwsIOException {@inheritDoc}
>>> 345: * @throwsOutOfMemoryError {@inheri
On Fri, 26 Apr 2024 14:52:08 GMT, Chen Liang wrote:
> > We will effectively enforce javadoc comment for some method overrides with
> > the checker
>
> Those overriding methods don't even appear on the javadoc output. If you go
> to search for `CompletableFuture.resultNow` on
> https://docs.or
On Thu, 25 Apr 2024 14:29:27 GMT, Nizar Benalla wrote:
> Please review this PR that aims to add all the remaining needed `@since` tags
> in `java.base`, and group them into a single fix.
> This is related to #18934 and my work around the `@since` checker feature.
> Explicit `@sin
On Thu, 25 Apr 2024 16:43:50 GMT, Chen Liang wrote:
> I think your changes mostly group in these categories:
>
> 1. New API methods provided in superclasses/superinterfaces, this class
> provides a more concrete implementation:
>Examples being `CompletableFuture`, `FileInputStream`, `DelayQ
Please review this PR that aims to add all the remaining needed `@since` tags
in `java.base`, and group them into a single fix.
This is related to #18934 and my work around the `@since` checker feature.
Explicit `@since` tags are needed for some overriding methods for the purpose
of the checker.
java.security.interfaces.XECPrivateKey
> java.security.interfaces.EdECPrivateKey
> java.security.interfaces.ECPublicKey
> java.security.interfaces.EdECPublicKey
> javax.crypto.interfaces.DHPrivateKey
> javax.crypto.interfaces.DHPublicKey
> java.security.interfaces.RSAPublicKey
> java.security.interfaces.RSAPri
java.security.interfaces.XECPrivateKey
> java.security.interfaces.EdECPrivateKey
> java.security.interfaces.ECPublicKey
> java.security.interfaces.EdECPublicKey
> javax.crypto.interfaces.DHPrivateKey
> javax.crypto.interfaces.DHPublicKey
> java.security.interfaces.RSAPublicKey
> java.security.interfaces.R
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote:
>> For context, I am writing tests to check for accurate use of `@since` tags
>> in documentation comments in source code.
>> We're following these rules for now:
>>
>> ### Rule 1: Introduction of New Ele
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote:
>> For context, I am writing tests to check for accurate use of `@since` tags
>> in documentation comments in source code.
>> We're following these rules for now:
>>
>> ### Rule 1: Introduction of New Ele
On Mon, 25 Mar 2024 22:51:48 GMT, Nizar Benalla wrote:
>> For context, I am writing tests to check for accurate use of `@since` tags
>> in documentation comments in source code.
>> We're following these rules for now:
>>
>> ### Rule 1: Introduction of New Ele
gt; java.security.interfaces.ECPrivateKey
> java.security.interfaces.XECPrivateKey
> java.security.interfaces.EdECPrivateKey
> java.security.interfaces.ECPublicKey
> java.security.interfaces.EdECPublicKey
> javax.crypto.interfaces.DHPrivateKey
> javax.crypto.interfaces.DHPublicKey
&g
interfaces.XECPrivateKey
> java.security.interfaces.EdECPrivateKey
> java.security.interfaces.ECPublicKey
> java.security.interfaces.EdECPublicKey
> javax.crypto.interfaces.DHPrivateKey
> javax.crypto.interfaces.DHPublicKey
> java.security.interfaces.RSAPublicKey
> jav
The override of `getParams` in these interfaces has an `@since 22`, but the
method has been inherited to these interfaces for a long times,
As pointed out by my mentor Jan,
import javax.crypto.interfaces.DHPublicKey;
public class DhkeyTest {
public static void main(DHPublicKey key) {
45 matches
Mail list logo
