On Mon, 21 Apr 2025 18:42:55 GMT, Matthew Donovan wrote:
> In this PR, I updated the default `serverAddress` field to use the loopback
> interface. I also removed some unnecessary logic around creating the server
> interface and the client connecting code.
This pull request has
In this PR, I updated the default `serverAddress` field to use the loopback
interface. I also removed some unnecessary logic around creating the server
interface and the client connecting code.
-
Commit messages:
- 8354235: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed w
On Fri, 18 Apr 2025 15:38:02 GMT, Artur Barashev wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 10 commits:
>>
>> - expanded wildcard imports
>> - Merge branch 'm
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 10 commits:
- expa
On Thu, 3 Apr 2025 20:30:33 GMT, Artur Barashev wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - reversed order of DN strings when making certificates.
&g
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich
wrote:
>> Moved the sh file logic to jtreg java test.
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor: space at the end
test/jdk/sun/security/pkcs11/Provi
On Thu, 3 Apr 2025 14:48:20 GMT, Sean Mullan wrote:
> Looks ok, but I am wondering ... how did these tests pass in the first place
> if the `allowSmartActionArgs` property was false?
The underlying code uses `PropertyExpander.expand()` which looks for and
expands `${}` values.
-
On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich
wrote:
> 8351566: Consolidate third party artifacts used in tests
test/lib/jdk/test/lib/security/NSSArtifactFetcher.java line 44:
> 42: final Class nssLibClass = getNssLibClass(osId);
> 43: if(nssLibClass == null){
> 44:
On Tue, 1 Apr 2025 20:53:01 GMT, Artur Barashev wrote:
> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate
> signatures).
> https://www.rfc-editor.org/rfc/rfc9155.html
test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureDTLS12.java
line 34:
> 32:
On Mon, 17 Mar 2025 13:19:55 GMT, Fernando Guallini
wrote:
> The test `javax/net/ssl/DTLS/PacketLossRetransmission` takes about ~2 to
> complete. The reason is that, in multiple scenarios, the server/client socket
> times out after 10 seconds waiting to receive a DatagramPacket that has been
On Fri, 21 Feb 2025 13:47:59 GMT, Matthew Donovan wrote:
> The similarity between the certificate pairs is impressive! Just curious -
> why the change in issuer and owner names?
After looking into this some more, I found that `X500Name(String dname)` is
expecting the string to be in th
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains seven commits:
- rev
On Thu, 6 Mar 2025 12:28:19 GMT, Fernando Guallini
wrote:
>> The following tests are marked with @ignore (not running):
>>
>> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting
>> the clientMode after the handshake has begun is not permitted, but this was
>> failing i
On Tue, 11 Mar 2025 15:21:09 GMT, Matthew Donovan wrote:
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
This pull request has now been integrated.
Changeset: e62becc6
Author:Matthew Donovan
URL:
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
fixed imports and copyright year
-
Changes:
On Wed, 12 Mar 2025 16:39:41 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed ArtifactResolver.fetchOne() to throw a skipped exception
>
> test/jdk/sun/s
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
updated code to remove extraneous null
On Wed, 12 Mar 2025 16:05:12 GMT, Weijun Wang wrote:
>> Do you mean to just assume `artifact` is never null and let the NPE be
>> thrown if it is?
>
> Yes.
I updated the code to reflect that.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991893033
On Wed, 12 Mar 2025 13:27:49 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>> test
&g
On Wed, 12 Mar 2025 13:29:08 GMT, Weijun Wang wrote:
>> It encapsulates all of the logic involved in getting the tests.
>> Specifically, what to do if the tests can't be fetched. It could be done in
>> `main()` but this is a little cleaner.
>
> I'd rather just let `ArtifactResolver.fetchOne` th
On Wed, 12 Mar 2025 13:31:56 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>>
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
Changed ArtifactResolver.fetchOne() to throw a skipped exc
> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
> consolidate duplicate code across tests.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
Changed exception message in Artifact resolver and fixed lo
On Tue, 11 Mar 2025 15:39:17 GMT, Mikhail Yankelevich
wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
On Tue, 11 Mar 2025 15:59:53 GMT, Fernando Guallini
wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changed exception message in Artifact resolver and fixed logic in keytool
>>
In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
consolidate duplicate code across tests.
-
Commit messages:
- 8350964: Add an ArtifactResolver.fetch(clazz) method
Changes: https://git.openjdk.org/jdk/pull/23989/files
Webrev: https://webrevs.openjdk.org/?repo
On Fri, 7 Mar 2025 12:43:34 GMT, Fernando Guallini
wrote:
>> This updates the OpenSSL version that is used by test
>> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS
>> version (3.0 series).
>> There are some differences between the 1.1.x and the current OpenSSL versio
On Wed, 5 Mar 2025 20:05:53 GMT, Fernando Guallini
wrote:
>> test/jdk/sun/security/pkcs12/KeytoolOpensslInteropTest.java line 78:
>>
>>> 76: testWithOpensslCommands(opensslPath);
>>> 77: } else {
>>> 78: // since the current version of openssl is not available,
On Wed, 19 Feb 2025 17:03:02 GMT, Fernando Guallini
wrote:
>> This updates the OpenSSL version that is used by test
>> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS
>> version (3.0 series).
>> There are some differences between the 1.1.x and the current OpenSSL versi
On Wed, 19 Feb 2025 17:03:02 GMT, Fernando Guallini
wrote:
>> This updates the OpenSSL version that is used by test
>> `sun/security/pkcs12/KeytoolOpensslInteropTest.java` to the current LTS
>> version (3.0 series).
>> There are some differences between the 1.1.x and the current OpenSSL versi
On Tue, 4 Mar 2025 13:07:37 GMT, Fernando Guallini
wrote:
> The following tests are marked with @ignore (not running):
>
> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting
> the clientMode after the handshake has begun is not permitted, but this was
> failing interm
On Wed, 5 Mar 2025 00:23:51 GMT, Justin Lu wrote:
> Please review this PR which provides localization updates for resources in
> `jarsigner` and `keytool`.
> The key/vals in this PR are updated to match the changes made in the English
> source files.
> Further context is provided on the JBS iss
In this PR I removed TEST.properties files that disabled smart action tags. It
is safe to remove the entire file: the smart action tags was the only directive
in them. I verified the affected tests pass successfully.
-
Commit messages:
- 8219408: Tests should handle ${} in the view
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich wrote:
> Refactor the following to run fully in java:
> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh
> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh
test/jdk/java/security/Security/ClassLoaderDeadlock/
On Wed, 12 Feb 2025 19:28:18 GMT, Matthew Donovan wrote:
> This is a trivial PR to update the version of NSS used for pkcs11 tests.
This pull request has now been integrated.
Changeset: 0f822681
Author: Matthew Donovan
URL:
https://git.openjdk.org/jdk/com
On Thu, 20 Feb 2025 20:27:27 GMT, Weijun Wang wrote:
> The similarity between the certificate pairs is impressive! Just curious -
> why the change in issuer and owner names?
Looks like it's something between `keytool` and `openssl x509`. When i print
the certificates with openssl, the issuer a
On Thu, 20 Feb 2025 11:22:41 GMT, Mikhail Yankelevich wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed boolean array initialization
>
> test/jdk/sun/net/www/pro
s/assets/51ce8ed2-0784-44ab-96a1-9d0a2ea66aaa)
> 
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
changed boolean array initiali
This PR updates the CertificateBuilder with a new method that creates a new
instance with common fields (subject name, public key, serial number, validity,
and key uses) filled-in. One test, IPIdentities.java, is updated to show how
the method can be used to create various certificates. I attach
On Sat, 1 Feb 2025 04:20:36 GMT, Anthony Scarpino wrote:
> I need a review of this change that adds new timing controls for the initial
> server setup. On rare occasions, more so on certain architectures, the
> server may not fully start before the client tries to connect. Additional
> debug
This is a trivial PR to update the version of NSS used for pkcs11 tests.
-
Commit messages:
- 8345598: Upgrade NSS binaries for interop tests
Changes: https://git.openjdk.org/jdk/pull/23594/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23594&range=00
Issue: https://bugs
On Mon, 10 Feb 2025 17:50:21 GMT, Mikhail Yankelevich wrote:
> Refactored the runNameEquals.sh to java test
test/jdk/sun/security/krb5/Krb5NameEquals.java line 94:
> 92:
> 93: if (installationIssue) {
> 94: System.out.println("""
You should probably
On Wed, 5 Feb 2025 18:50:25 GMT, Mikhail Yankelevich wrote:
>> * fully automated the test
>> * removed the race condition
>> * client on a thread and server on a thread options are now run together
>> automatically
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> ad
On Tue, 4 Feb 2025 04:51:15 GMT, Konanki Sreenath wrote:
>> test/jdk/java/security/cert/X509Certificate/CertificateExtensions.java line
>> 29:
>>
>>> 27: * else it is incorrect
>>> 28: */
>>> 29: try {
>>
>> These try/catch blocks around the assert statements seem red
On Mon, 27 Jan 2025 12:39:45 GMT, Konanki Sreenath wrote:
> Earlier code will trigger NPE if the certificate does not contain the
> extensions or if the requested extensions does not exist. The better approach
> for hardening **getExtensionValue** here is to to check for NULL explicitly
> befo
On Fri, 31 Jan 2025 15:56:29 GMT, Mikhail Yankelevich wrote:
> Refactor test/java/security//cert/CertificateFactory/slowstream.sh to java
> test
test/jdk/java/security/cert/CertificateFactory/SlowStream.java line 52:
> 50: while (true) {
> 51: int le
On Fri, 6 Dec 2024 01:23:31 GMT, Matthew Donovan wrote:
> I was unable to reproduce the error but I suspect the error is caused by the
> server-side closing the socket as soon as the write operation is done. I
> added a read() call on the server to ensure the client initiates c
> I was unable to reproduce the error but I suspect the error is caused by the
> server-side closing the socket as soon as the write operation is done. I
> added a read() call on the server to ensure the client initiates connection
> close
Matthew Donovan has updated the
On Mon, 16 Dec 2024 14:57:36 GMT, Matthew Donovan wrote:
> In this small PR, I updated the jarsigner compatibility test to handle the
> difference in default digest algorithms between JDK versions. The previous
> default was SHA-256 but has been updated to SHA-384.
This pull reques
> In this small PR, I updated the jarsigner compatibility test to handle the
> difference in default digest algorithms between JDK versions. The previous
> default was SHA-256 but has been updated to SHA-384.
Matthew Donovan has updated the pull request incrementally with one additiona
On Mon, 16 Dec 2024 15:05:38 GMT, Weijun Wang wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated to use JarSigner.Builder.getDefaultDigestAlgorithm()
>
> test/jdk/sun/security
In this small PR, I updated the jarsigner compatibility test to handle the
difference in default digest algorithms between JDK versions. The previous
default was SHA-256 but has been updated to SHA-384.
-
Commit messages:
- 8346285: Update jarsigner compatibility test for change in
On Fri, 6 Dec 2024 18:23:48 GMT, Daniel Jeliński wrote:
>> Matthew Donovan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed read call on the server side.
>
> test/jdk/javax/net/ssl/SSLSocket/Tls13Pac
> I was unable to reproduce the error but I suspect the error is caused by the
> server-side closing the socket as soon as the write operation is done. I
> added a read() call on the server to ensure the client initiates connection
> close
Matthew Donovan has updated the
On Fri, 6 Dec 2024 01:30:09 GMT, Matthew Donovan wrote:
> I was unable to recreate the error but it is probably the same root cause as
> JDK-8337951 (https://github.com/openjdk/jdk/pull/20728).
>
> I updated the gencert command to explicitly set the start date to ensure the
>
I was unable to recreate the error but it is probably the same root cause as
JDK-8337951 (https://github.com/openjdk/jdk/pull/20728).
I updated the gencert command to explicitly set the start date to ensure the
certificate is valid.
-
Commit messages:
- 8345133: Test sun/security
I was unable to reproduce the error but I suspect the error is caused by the
server-side closing the socket as soon as the write operation is done. I added
a read() call on the server to ensure the client initiates connection close
-
Commit messages:
- 8339356: Test javax/net/ssl/S
On Thu, 7 Nov 2024 20:46:13 GMT, Weijun Wang wrote:
>> Here we have a launcher and several algorithm-specific tests. Users can
>> populate "internalProjection.json" files generated by NIST's ACVP Server
>> into the `data` directory and test them with the launcher.
>>
>> Currently, only SHA2, S
On Wed, 16 Oct 2024 18:47:44 GMT, Matthew Donovan wrote:
> In this PR, I removed hard-coded security providers and replaced them with a
> system property, test.provider.name. If the property is not specified, the
> provider originally used in the test is used:
>
t;,
> System.getProperty("test.provider.name", "SunJCE"));
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
included additional services in testing.md
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21551
t;,
> System.getProperty("test.provider.name", "SunJCE"));
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
updated testing doc per PR comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21551/files
t;,
> System.getProperty("test.provider.name", "SunJCE"));
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
added documentation for the new property
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21551
On Thu, 24 Oct 2024 09:49:39 GMT, Fernando Guallini
wrote:
>> test/jdk/com/sun/crypto/provider/KeyAgreement/SupportedDHParamGens.java line
>> 61:
>>
>>> 59:
>>> 60: static DHParameterSpec FFDHE4096_SPEC = new DHParameterSpec(
>>> 61: dhGroup4096.getPrime(), dhGroup4096.getBas
On Fri, 18 Oct 2024 08:33:36 GMT, Fernando Guallini
wrote:
> Several tests are identified to use weak/legacy algorithms. As these tests
> purpose is not to exercise weak algorithms, these are updated in this PR to
> use stronger algorithms. If the test uses a weak key, it is updated as well.
On Fri, 25 Oct 2024 12:53:04 GMT, Sean Mullan wrote:
> > I changed the name of the bug and PR. Yes there are cases where a test has
> > more than one hardcoded provider.
>
> How would that work then if the property only allows you to specify one
> provider?
The tests with multiple, hardcoded
t;,
> System.getProperty("test.provider.name", "SunJCE"));
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
On Mon, 21 Oct 2024 12:42:08 GMT, Sean Mullan wrote:
> You are changing more than SunJCE providers, so the title of this bug should
> not be specific to SunJCE. Suggest: "Replace hardcoded security providers
> with new test.provider.name system property".
>
> Are there any cases where a test h
On Thu, 24 Oct 2024 09:27:21 GMT, Fernando Guallini
wrote:
>> Several tests are identified to use weak key parameters (prime modulus,
>> private/public values) and certs with weak keys. As these tests purpose is
>> not to exercise weak keys, these are updated in this PR to use a modulus
>> wi
On Wed, 23 Oct 2024 09:17:48 GMT, Fernando Guallini
wrote:
>> Several tests are identified to use weak key parameters (prime modulus,
>> private/public values) and certs with weak keys. As these tests purpose is
>> not to exercise weak keys, these are updated in this PR to use a modulus
>> wi
t;,
> System.getProperty("test.provider.name", "SunJCE"));
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
fixed whitespace
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21551/files
- new: https
t;,
> System.getProperty("test.provider.name", "SunJCE"));
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
Updated a few more tests.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21551/files
- n
In this PR, I removed hard-coded security providers and replaced them with a
system property, test.provider.name. If the property is not specified, the
provider originally used in the test is used:
Cipher c = Cipher.getInstance("AES/GCM/NoPadding",
System.getProperty("test.provider.name", "SunJ
On Wed, 14 Aug 2024 12:22:47 GMT, Matthew Donovan wrote:
> This is a small PR to extend the AbstractServer class in
> test/jdk/javax/net/ssl/TLSCommon/interop/ to enable users to specify a
> specific interface on which to listen for incoming connections. The default
> interfac
, is
> also updated to use the interface specified in AbstractServer.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains three additional
This is a small PR to extend the AbstractServer class in
test/jdk/javax/net/ssl/TLSCommon/interop/ to enable users to specify a specific
interface on which to listen for incoming connections. The default interface is
now the loopback interface. The derived class, JdkServer, is also updated to
u
On Mon, 24 Jun 2024 12:07:49 GMT, Matthew Donovan wrote:
> In this PR, I updated the version of NSS to 3.101 and removed the test from
> the ProblemList for all platforms but linux-ppc64le (that bug is still
> outstanding.)
>
> I also updated the skipTest logic in TestDSAKeyLen
On Mon, 15 Jul 2024 13:09:23 GMT, Matthew Donovan wrote:
>> In this PR, I updated the version of NSS to 3.101 and removed the test from
>> the ProblemList for all platforms but linux-ppc64le (that bug is still
>> outstanding.)
>>
>> I also updated the skipTest
numbers as double values but that doesn't
> work when version 3.101 is later (i.e., greater) than 3.14.
Matthew Donovan has updated the pull request incrementally with one additional
commit since the last revision:
fixed copyright year
-
Changes:
- all: https://git.
On Mon, 24 Jun 2024 12:07:49 GMT, Matthew Donovan wrote:
> In this PR, I updated the version of NSS to 3.101 and removed the test from
> the ProblemList for all platforms but linux-ppc64le (that bug is still
> outstanding.)
>
> I also updated the skipTest logic in TestDSAKeyLen
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote:
> 8324841: PKCS11 tests still skip execution
This pull request has now been integrated.
Changeset: a106e522
Author: Matthew Donovan
URL:
https://git.openjdk.org/jdk/commit/a106e522f87842b6d63a77bf37a7662a4353ef9e
Stats:
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote:
> 8324841: PKCS11 tests still skip execution
Hello, I still need a reviewer for this small backport.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/19857#issuecomment-2228282469
8324841: PKCS11 tests still skip execution
-
Commit messages:
- Backport 9d4a4bd2c2a4bd16bbc80b602b15b448c52220f6
Changes: https://git.openjdk.org/jdk/pull/19857/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19857&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8324
In this PR, I updated the version of NSS to 3.101 and removed the test from the
ProblemList for all platforms but linux-ppc64le (that bug is still outstanding.)
I also updated the skipTest logic in TestDSAKeyLength.java. Prior to my change,
it compared the version numbers as double values but th
On Tue, 18 Jun 2024 12:13:13 GMT, Matthew Donovan wrote:
> In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS
> binaries are not found in a directory specified with the property
> jdk.test.lib.artifacts.nsslib-. If the property is not specified,
> the tests
In this PR, I updated PKCS11Test to throw a RuntimeException if the NSS
binaries are not found in a directory specified with the property
jdk.test.lib.artifacts.nsslib-. If the property is not specified,
the tests will throw a SkippedException.
-
Commit messages:
- 8324841: PKCS1
On Mon, 10 Jun 2024 18:54:38 GMT, Matthew Donovan wrote:
> 8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due
> to JDK-817
This pull request has now been integrated.
Changeset: 9e22b6de
Author:Matthew Donovan
URL:
https://git.openjdk.org/jdk/
8333829: ProblemList sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java due
to JDK-817
-
Commit messages:
- Backport b25476200ab8bea4f25a671d5b9351662d11c5b4
Changes: https://git.openjdk.org/jdk/pull/19636/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19636&range=0
On Mon, 10 Jun 2024 13:56:07 GMT, Matthew Donovan wrote:
> In this PR, I updated the ProblemList entry for ClientJSSEServerJSSE.java for
> all architectures.
>
> JDK-817 documents an intermittent failure which may be resolved by a fix
> in NSS: https://bugzilla.mozilla.o
In this PR, I updated the ProblemList entry for ClientJSSEServerJSSE.java for
all architectures.
JDK-817 documents an intermittent failure which may be resolved by a fix in
NSS: https://bugzilla.mozilla.org/show_bug.cgi?id=1893404
-
Commit messages:
- 8333829: ProblemList sun
On Thu, 6 Jun 2024 13:13:00 GMT, Fernando Guallini
wrote:
>> As highlighted in the bug description, The test
>> **security/Security/SynchronizedAccess.java** have some issues:
>>
>> 1. it needs to implement the sigalg, otherwise it throws
>> java.security.NoSuchAlgorithmException . Even thoug
On Mon, 3 Jun 2024 09:54:16 GMT, Fernando Guallini
wrote:
>> As highlighted in the bug description, The test
>> **security/Security/SynchronizedAccess.java** have some issues:
>>
>> 1. it needs to implement the sigalg, otherwise it throws
>> java.security.NoSuchAlgorithmException . Even thoug
On Thu, 23 May 2024 18:23:28 GMT, Sean Mullan wrote:
>> I renamed the method.
>>
>> I don't want to over-generalize the code when I don't know what we'll
>> need/want in the future. The tests in this PR just create CA and end-entity
>> certs and with a couple exceptions, the tests in this PR
tests that use
> it. These tests require significant refactoring to incorporate
> programmatically generated certificates and should be a separate task.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unr
On Thu, 4 Apr 2024 19:37:56 GMT, Matthew Donovan wrote:
> In this PR, I updated the version of the NSS libraries used in PKCS11Test to
> 3.96.
This pull request has now been integrated.
Changeset: 6cda4c59
Author:Matthew Donovan
URL:
https://git.openjdk.org/jdk/
On Thu, 4 Apr 2024 19:37:56 GMT, Matthew Donovan wrote:
> In this PR, I updated the version of the NSS libraries used in PKCS11Test to
> 3.96.
Hello,
I need a reviewer for this small, one-line PR.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/18636#issuec
On Tue, 21 May 2024 20:11:03 GMT, Sean Mullan wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
tests that use
> it. These tests require significant refactoring to incorporate
> programmatically generated certificates and should be a separate task.
Matthew Donovan has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unr
For this PR, I identified TLS tests that can fail due to hard-code certificates
expiring. I updated those tests to use certificates that are generated
programmatically. This includes adding some helper methods to the
CertificateBuilder class to create builder objects with common default values.
On Wed, 17 Apr 2024 14:13:37 GMT, Sean Coffey wrote:
>> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation
>> was introduced many years ago.
>>
>> Where "ssl" was previously a value to obtain all TLS debug traces (except
>> network type dumps, verbose data), it now pr
On Fri, 3 May 2024 11:22:51 GMT, Sean Coffey wrote:
> Using the loopback address by default may prove more reliable for some test
> configurations
>
> ran all jdk_security tests. no issues seen.
looks good to me.
-
PR Comment: https://git.openjdk.org/jdk/pull/19083#issuecomment-2
1 - 100 of 290 matches
Mail list logo
