Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v8]

2024-10-30 Thread Mat Carter
On Tue, 29 Oct 2024 19:50:46 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v4]

2024-10-30 Thread Mat Carter
On Fri, 22 Mar 2024 22:25:47 GMT, rebarbora-mckvak wrote: >> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v8]

2024-10-29 Thread Mat Carter
On Tue, 29 Oct 2024 19:52:29 GMT, rebarbora-mckvak wrote: > Wierd, I do not see those comments in github. Anyway it is fixed now. @rebarbora-mckvak - change looks good to me @wangweij - this commit addresses the two issues I highlighted, I don't have any other concerns - PR Comme

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-29 Thread Mat Carter
On Tue, 29 Oct 2024 15:34:37 GMT, Mat Carter wrote: >> @wangweij, please see the release note above. > >> @rebarbora-mckvak I've added the release note as >> https://bugs.openjdk.org/browse/JDK-8340661 last month. >> >> I didn't approve because of Mat

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v5]

2024-10-29 Thread Mat Carter
On Tue, 15 Oct 2024 08:29:28 GMT, rebarbora-mckvak wrote: >> @rebarbora-mckvak Please put the release note here and I can create it. >> Thanks. > > @wangweij, please see the release note above. > @rebarbora-mckvak I've added the release note as > https://bugs.openjdk.org/browse/JDK-8340661 las

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation [v4]

2024-08-14 Thread Mat Carter
On Fri, 19 Apr 2024 20:04:57 GMT, Weijun Wang wrote: >> @wangweij , your [comment on >> JDK-8313367](https://bugs.openjdk.org/browse/JDK-8313367?focusedId=14664542&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14664542) >> indicates you are unable to request a

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-03-13 Thread Mat Carter
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-03-13 Thread Mat Carter
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-03-04 Thread Mat Carter
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2024-01-23 Thread Mat Carter
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation

2023-12-19 Thread Mat Carter
On Thu, 16 Nov 2023 12:06:26 GMT, rebarbora-mckvak wrote: > This fixes the defect described at https://bugs.openjdk.org/browse/JDK-8313367 > > If the process does not have write permissions, the store is opened as > read-only (instead of failing). > > Please note that permissions to use a cert

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-12-04 Thread Mat Carter
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Mat Carter
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-06-01 Thread Mat Carter
On Fri, 26 May 2023 21:09:35 GMT, Mat Carter wrote: > Added ability to load keystores from SST files on Windows. Example usage: > > KeyStore keyStore = KeyStore.getInstance("Windows-SST"); > try (FileInputStream fis = new FileInputStream("mykeystore.sst")

Read only KeyStores?

2023-05-31 Thread Mat Carter
Currently on Windows to access the local machine KeyStores (Windows-MY-LOCALMACHINE and Windows-ROOT-LOCALMACHINE) you need administrator privileges. To reduce the need to grant admin privileges to Java applications, I'm proposing that we allow the application to access readonly versions of the

Re: RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-30 Thread Mat Carter
On Tue, 30 May 2023 14:32:53 GMT, Weijun Wang wrote: >> Added ability to load keystores from SST files on Windows. Example usage: >> >> KeyStore keyStore = KeyStore.getInstance("Windows-SST"); >> try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { >>keyStore.load(fis, null);

RFR: 8306688: Support Windows serialized keystores (SST files)

2023-05-26 Thread Mat Carter
Added ability to load keystores from SST files on Windows. Example usage: KeyStore keyStore = KeyStore.getInstance("Windows-SST"); try (FileInputStream fis = new FileInputStream("mykeystore.sst")) { keyStore.load(fis, null); } Note that its not limited to file streams, it can be any stream.

Integrated: 8303607: SunMSCAPI provider leaks memory and keys

2023-03-06 Thread Mat Carter
On Mon, 6 Mar 2023 21:27:07 GMT, Mat Carter wrote: > Use the correct API for freeing key handles when directed to by the output of > CryptAcquireCertificatePrivateKey [1]. > Specifically when [out] pfCallerFreeProvOrNCryptKey is true we test [out] > pdwKeySpec for the CERT_NCRYPT_K

Re: RFR: 8303607: SunMSCAPI provider leaks memory and keys

2023-03-06 Thread Mat Carter
e/JDK-8284850 Sent from Outlook From: security-dev on behalf of Mat Carter Sent: Monday, March 6, 2023 1:35 PM To: security-dev@openjdk.org Subject: RFR: 8303607: SunMSCAPI provider leaks memory and keys   [Some people who received this message don't often get email from maca...@openjdk.org.

RFR: 8303607: SunMSCAPI provider leaks memory and keys

2023-03-06 Thread Mat Carter
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- Use the correct API for freeing key handles when dir