On Wed, 30 Oct 2024 18:12:30 GMT, Matthew Donovan wrote:
>> In this PR, I removed hard-coded security providers and replaced them with a
>> system property, test.provider.name. If the property is not specified, the
>> provider originally used in the test is used:
>>
>> Cipher c = Cipher.getIns
On Fri, 8 Nov 2024 16:25:33 GMT, Goetz Lindenmaier wrote:
> Trivial fix of typo.
>
> Thanks to @RealLucy for spotting this!
Looks good. And trivial.
-
Marked as reviewed by lucy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21990#pullrequestreview-2424291232
On Tue, 23 Jan 2024 10:21:42 GMT, Goetz Lindenmaier wrote:
> I backport this to fix this issue in 22. We see it failing there in our CI.
Looks good.
-
Marked as reviewed by lucy (Reviewer).
PR Review: https://git.openjdk.org/jdk22/pull/95#pullrequestreview-1841351221
On Tue, 26 Sep 2023 07:23:20 GMT, Matthias Baesken wrote:
> We sometimes run into the following error. This especially occurs when
> running with fastdebug binaries and on Linux ppc64le machines.
> Current timeout set in the test is 1 second.
>
> Server accepting: 315357614990101
> Server accep
On Fri, 15 Sep 2023 08:21:00 GMT, Matthias Baesken wrote:
> Currently sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux
> ppc64le Ubuntu 22, it does not find the NSS libs because the new file system
> locations are not handled, unlike on Linux x86_64 .
LGTM.
Thanks for tracking dow
On Mon, 4 Sep 2023 13:09:08 GMT, Matthias Baesken wrote:
> on some slow machines, sun/security/tools/jarsigner/Warning.java runs
> sometimes into timeouts (with fastdebug binaries).
> So the current timeout of the test should be increased.
LGTM.
-
Marked as reviewed by lucy (Revie
On Thu, 12 Jan 2023 14:29:34 GMT, Lutz Schmidt wrote:
> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
> message is ciphered in multiple, small (< 16 bytes) segments, the result is
> incorrect.
>
> This is not just a band-aid fix. The issue was ta
On Mon, 27 Feb 2023 09:03:49 GMT, Lutz Schmidt wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
>> message is ciphered in multiple, small (< 16 bytes) segments, the result is
>> incorrect.
>>
>> This is not just a band-aid fix
mplete.
>
> **Reviews and comments are very much appreciated.**
>
> @backwaterred could you please run some "official" s390 tests? Thanks.
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8299
On Sat, 25 Feb 2023 07:51:24 GMT, Martin Doerr wrote:
>> Lutz Schmidt has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains four commits:
>>
>> - Merge master to resolve copyright conflict
>> - 829817:
On Mon, 20 Feb 2023 12:21:27 GMT, Lutz Schmidt wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
>> message is ciphered in multiple, small (< 16 bytes) segments, the result is
>> incorrect.
>>
>> This is not just a band-aid fix
mplete.
>
> **Reviews and comments are very much appreciated.**
>
> @backwaterred could you please run some "official" s390 tests? Thanks.
Lutz Schmidt has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains four commits
On Mon, 30 Jan 2023 12:26:57 GMT, Lutz Schmidt wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
>> message is ciphered in multiple, small (< 16 bytes) segments, the result is
>> incorrect.
>>
>> This is not just a band-aid fix
mplete.
>
> **Reviews and comments are very much appreciated.**
>
> @backwaterred could you please run some "official" s390 tests? Thanks.
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
829817: fixed typos, rem
On Mon, 23 Jan 2023 09:23:54 GMT, Martin Doerr wrote:
>> Lutz Schmidt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8299817: Update copyright
>
> test/hotspot/jtreg/compiler/codegen/aes/Test8299817.java
mplete.
>
> **Reviews and comments are very much appreciated.**
>
> @backwaterred could you please run some "official" s390 tests? Thanks.
Lutz Schmidt has updated the pull request incrementally with one additional
commit since the last revision:
8299817: Update copyright
On Thu, 12 Jan 2023 14:29:34 GMT, Lutz Schmidt wrote:
> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
> message is ciphered in multiple, small (< 16 bytes) segments, the result is
> incorrect.
>
> This is not just a band-aid fix. The issue was ta
This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a
message is ciphered in multiple, small (< 16 bytes) segments, the result is
incorrect.
This is not just a band-aid fix. The issue was taken as a chance to restructure
the code. though still complicated, It is now easier to
18 matches
Mail list logo
