On Fri, 1 Mar 2024 17:35:35 GMT, Korov wrote:
> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`,
> so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too.
>
> Removing unused parameter `cname` in `SocketPermission.authori
On Tue, 5 Mar 2024 13:37:22 GMT, Korov wrote:
>>> Seems good. If nobody disagrees such mixed patch, I will help you change
>>> the title and content of the issue.
>>
>> Have changed just now! And please wait for a formal reviewer to review this
>> path.
&g
On Thu, 7 Mar 2024 16:21:14 GMT, Daniel Fuchs wrote:
> This is used by internal whitebox test. Please revert this change.
Reverted.
> src/java.base/share/classes/java/net/SocketPermission.java line 305:
>
>> 303: private void setDeny() {
>> 304: defaultDeny = true;
>> 305: }
>
'action' must be not empty so `a.length > 0`, the check `a.length -
> 1 < 0` can be removed.
Korov has updated the pull request incrementally with one additional commit
since the last revision:
revert change
-
Changes:
- all: https://git.openjdk
On Tue, 5 Mar 2024 12:01:38 GMT, Guoxiong Li wrote:
> > Seems good. If nobody disagrees such mixed patch, I will help you change
> > the title and content of the issue.
>
> Have changed just now! And please wait for a formal reviewer to review this
> path.
Thanks so much!!!
-
PR
On Sat, 2 Mar 2024 13:00:21 GMT, Andrey Turbanov wrote:
>> Korov has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Modiy the code accordingto the review
>
> src/java.base/share/classes/java/net/SocketPermi
On Sat, 2 Mar 2024 13:02:58 GMT, Andrey Turbanov wrote:
>> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`,
>> so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too.
>>
>> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and
>> `SocketPe
'action' must be not empty so `a.length > 0`, the check `a.length -
> 1 < 0` can be removed.
Korov has updated the pull request incrementally with one additional commit
since the last revision:
Modiy the code accordingto the review
-
Changes:
- all: http
On Sat, 2 Mar 2024 11:35:29 GMT, Guoxiong Li wrote:
> > Hello @lgxbslgx , the title has been changed, Can you check if it's
> > suitable?
>
> Seems good. If nobody disagrees such mixed patch, I will help you change the
> title and content of the issue.
Thanks so much.
-
PR Comme
On Sat, 2 Mar 2024 08:54:44 GMT, Guoxiong Li wrote:
> The patch looks good. But the title of this issue may need to be adjusted,
> because you not only change the `SocketPermission.initEphemeralPorts` but
> also change other code. Or you can separate the unrelated code to another
> issue.
Hel
On Fri, 1 Mar 2024 17:56:16 GMT, Daniel Fuchs wrote:
> The proposed cleanup looks OK and reduces potential confusion - since the
> removed parameters were actually not used. However I wonder if we want to
> change this class at this time. I added the label `security` to get some
> input from s
11 matches
Mail list logo
