On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Fri, 9 May 2025 08:31:35 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 23 Apr 2025 07:54:39 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line
>> 366:
>>
>>> 364: }
>>> 365:
>>> 366: public String chooseServerAlias(String keyType,
>>
>>
On Tue, 22 Apr 2025 18:55:28 GMT, Artur Barashev wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli
On Tue, 22 Apr 2025 19:11:24 GMT, Artur Barashev wrote:
>> test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 96:
>>
>>> 94: //System.setProperty("javax.net.ssl.trustStore", KEYSTORE);
>>> 95: //System.setProperty("javax.net.ssl.trustStorePassword",
>>> PASSWORD);
On Tue, 22 Apr 2025 18:56:19 GMT, Artur Barashev wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli
On Tue, 22 Apr 2025 16:10:19 GMT, Artur Barashev wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for
>> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>>
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Cli
On Wed, 16 Apr 2025 11:20:36 GMT, Jaikiran Pai wrote:
> This brings in the CPU25_04 changes into the master branch.
Thank you Daniel for the review.
-
PR Comment: https://git.openjdk.org/jdk/pull/24683#issuecomment-2809280611
On Wed, 16 Apr 2025 11:20:36 GMT, Jaikiran Pai wrote:
> This brings in the CPU25_04 changes into the master branch.
This pull request has now been integrated.
Changeset: c6243fc2
Author: Jaikiran Pai
URL:
https://git.openjdk.org/jdk/commit/c6243fc27fafb1ff89f8610ead3acd87030ca
This brings in the CPU25_04 changes into the master branch.
-
Commit messages:
The merge commit only contains trivial merges, so no merge-specific webrevs
have been generated.
Changes: https://git.openjdk.org/jdk/pull/24683/files
Stats: 0 lines in 0 files changed: 0 ins; 0 del;
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjd
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjd
On Mon, 7 Apr 2025 12:49:45 GMT, Sean Mullan wrote:
> I suggest making this a P3 since it sounds like it would be useful to
> backport to 21.
Done - I've marked it as a P3, and I agree that this is worth backporting.
-
PR Comment: https://git.openjdk.org/jdk/pull/24475#issuecommen
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjd
Can I please get a review of this change which proposes to address the increase
in memory footprint of an application that uses signed JAR files, signed with
`SHA-384` digest algorithm? This addresses
https://bugs.openjdk.org/browse/JDK-8353787.
As noted in that issue and the linked mailing lis
On Thu, 6 Mar 2025 11:49:12 GMT, Mikhail Yankelevich
wrote:
>> Refactor the following to run fully in java:
>> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh
>> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh
>
> Mikhail Yankelevich has updated the pull requ
On Thu, 27 Feb 2025 17:49:48 GMT, Mikhail Yankelevich
wrote:
>> Refactor the following to run fully in java:
>> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh
>> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh
>
> Mikhail Yankelevich has updated the pull req
On Thu, 27 Feb 2025 16:08:09 GMT, Jaikiran Pai wrote:
> Hello Mikhail, since we are updating these tests to move away from the shell
> tests, could you also see if the deadlock.jar file which has been committed
> into the repo, can be generated dynamically within the test itself.
I
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich wrote:
> Refactor the following to run fully in java:
> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh
> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh
Hello Mikhail, since we are updating these tests to
On Sat, 22 Feb 2025 02:25:42 GMT, Bradford Wetmore wrote:
> Typo: s/ficticious/fictitious/
>
> No unit test. Check that javadoc still builds.
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23733#pullrequestreview-2634730559
On Wed, 19 Feb 2025 10:43:06 GMT, Marcono1234 wrote:
>> This change adds an API note to these methods recommending that the caller
>> should perform further validation steps on the code signers that signed the
>> JAR file, such as validating the code signer's certificate chain, and
>> determin
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Tue, 14 Jan 2025 20:29:38 GMT, Daniel Fuchs wrote:
>> There are a few places in the HttpClient code base where we close the
>> connection when some error/exception happens. This can some time trigger a
>> race condition where closing the connection in turns causes a "connection
>> closed lo
On Mon, 13 Jan 2025 16:07:45 GMT, Daniel Fuchs wrote:
> There are a few places in the HttpClient code base where we close the
> connection when some error/exception happens. This can some time trigger a
> race condition where closing the connection in turns causes a "connection
> closed locall
On Mon, 13 Jan 2025 16:07:45 GMT, Daniel Fuchs wrote:
> There are a few places in the HttpClient code base where we close the
> connection when some error/exception happens. This can some time trigger a
> race condition where closing the connection in turns causes a "connection
> closed locall
On Fri, 10 Jan 2025 17:10:03 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
On Wed, 18 Dec 2024 21:07:14 GMT, Roger Riggs wrote:
>> SM Cleanup of common test library test/lib/...:
>>
>> Remove unnecessary catches of SecurityException
>> Remove AccessController and doPrivileged from SimpleSSLContext and
>> ProcessTools.
>
> Roger Riggs has updated the pull request incre
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/bro
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/bro
On Mon, 2 Dec 2024 17:47:57 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 13 commits:
>>
>> - merge latest from master branch
>> - remove changes to
>
On Mon, 2 Dec 2024 18:54:33 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/misc/InnocuousThread.java line 31:
>>
>>> 29:
>>> 30: /**
>>> 31: * A thread that has no permissions, is not a member of any user-defined
>>
>> I think you can also remove the words "has no permis
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- merge latest from master branch
- remove permission text from InnocuousThread
- merge latest from master branch
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
Co-authored-by: Severin Gehwolf
--
On Mon, 2 Dec 2024 15:42:37 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove changes to
>> src/java.base/unix/classes/sun/security/provider/NativePRNG.java
On Mon, 2 Dec 2024 13:43:41 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- merge latest from master branch
- remove changes to
src/java.base/unix/classes/sun/security/provider/NativePRNG.jav
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Path.of() instead of Paths.get() in CgroupV2Subsystem.java
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22478/files
- n
On Mon, 2 Dec 2024 14:25:12 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove unused import
>> - replace remaining Paths.get() with Path.of() in the updated
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
remove changes to
src/java.base/unix/classes/sun/security/provider/NativePRNG.java
-
Changes:
- all: https://git.openjdk.org
On Mon, 2 Dec 2024 14:17:10 GMT, Severin Gehwolf wrote:
> cgroups changes look good. Haven't looked at the other bits.
Thank you Severin.
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java
> line 29:
>
>> 27: package jdk.internal.platform;
>> 28:
>> 29: import
On Mon, 2 Dec 2024 14:07:45 GMT, Severin Gehwolf wrote:
>> Is the catch for `UncheckedIOException` due to some previously known failure
>> resulting in the use of these APIs?
>
> Without using `Files.lines()` no `UncheckedIOException` would be thrown. Just
> `IOException` and `null` returned. T
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last revision:
- remove unused import
- replace remaining Paths.get() with Path.of() in the updated files
-
Changes:
- all: https://git.open
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java
Co-authored-by: Severin Gehwolf
--
On Mon, 2 Dec 2024 13:06:05 GMT, Severin Gehwolf wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Path.of() instead of Paths.get() in CgroupV2Subsystem.java
>
> src/java.base/linux
ced and tier testing is currently in progress.
Jaikiran Pai has updated the pull request incrementally with four additional
commits since the last revision:
- remove unnecessary space
- Path.of() instead of Paths.get()
- fix formatting of try-with-resources in CgroupSubsystemController.java
- le
On Mon, 2 Dec 2024 12:42:47 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - remove unnecessary space
>> - Path.of() instead of Paths.get()
>> - fix
Can I please get a review of this change which removes usages of
SecurityManager related APIs and some leftover related to SecurityManager
changes?
This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
changes are trivial. The
`src/java.base/linux/classes/jdk/internal/platf
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286
On Mon, 25 Nov 2024 20:06:33 GMT, Volkan Yazıcı wrote:
>> Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes
>> `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection`
>> and `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way.
>
> V
On Mon, 18 Nov 2024 13:11:26 GMT, Sean Mullan wrote:
>> Now that JEP 486 is integrated, javax.crypto and com.sun.crypto
>> implementation dependencies on System.getSecurityManager and
>> AccessController.doPrivileged can be removed.
>
> Sean Mullan has updated the pull request incrementally wit
On Fri, 15 Nov 2024 20:48:42 GMT, Sean Mullan wrote:
> Now that JEP 486 is integrated, javax.crypto and com.sun.crypto
> implementation dependencies on System.getSecurityManager and
> AccessController.doPrivileged can be removed.
Hello Sean, at the class declaration of `JceSecurity` in the
`s
On Sat, 16 Nov 2024 01:59:43 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes calls to
>> `SecurityManager` and `AccessController.doPrivileged()` from the
>> `ProxySelector` and `DefaultProxySelector` classes?
>>
>> Apart from
On Fri, 15 Nov 2024 10:31:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes calls to
> `SecurityManager` and `AccessController.doPrivileged()` from the
> `ProxySelector` and `DefaultProxySelector` classes?
>
> Apart from the trivial removing
On Fri, 15 Nov 2024 10:31:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes calls to
> `SecurityManager` and `AccessController.doPrivileged()` from the
> `ProxySelector` and `DefaultProxySelector` classes?
>
> Apart from the trivial removing
us
> `doPriveleged()` call block.
>
> No new tests have been introduced. Existing tests in tier1 and tier2 continue
> to pass with this change.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
On Fri, 15 Nov 2024 10:31:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes calls to
> `SecurityManager` and `AccessController.doPrivileged()` from the
> `ProxySelector` and `DefaultProxySelector` classes?
>
> Apart from the trivial removing
On Fri, 15 Nov 2024 14:07:10 GMT, Daniel Fuchs wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
>
On Fri, 15 Nov 2024 10:25:18 GMT, Daniel Fuchs wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> Daniel Fuchs has updated the pull request with a new target base due to a
> me
On Fri, 15 Nov 2024 10:25:18 GMT, Daniel Fuchs wrote:
>> Please find here a patch that cleans up the java.net.http module code to
>> remove permission checks and doPriviliged calls.
>> This was mostly mechanical.
>
> Daniel Fuchs has updated the pull request with a new target base due to a
> me
On Fri, 15 Nov 2024 11:26:50 GMT, Daniel Fuchs wrote:
> No CSR needed for removing those permissions. There's no visible change to
> the public APIs, and no behavior change that was not already covered by JEP
> 486 CSR, since permissions checks have now become deadcode. Or am I missing
> somet
Can I please get a review of this change which removes calls to
`SecurityManager` and `AccessController.doPrivileged()` from the
`ProxySelector` and `DefaultProxySelector` classes?
Apart from the trivial removing of those calls, the commit in this PR also
removes the `getProxySelector` and `set
On Thu, 14 Nov 2024 13:21:33 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which cleans up security manager related code in
>> `java.util.zip` and `java.util.jar`:
>>
>> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead
>> of `GetPropertyAction::privilegedGetProp
On Mon, 11 Nov 2024 12:34:44 GMT, Shaojin Wen wrote:
> 8343925 Feedback PR #21593 test/jdk/java/util/BitSet/HugeToString.java crash,
>
> I can't reproduce the problem on a MacBook M1 Max, but I agree that more
> testing is needed, so let's roll it back first.
I have verified that this backout
On Wed, 30 Oct 2024 16:17:20 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1798:
>>
>>> 1796:
>>> metaVersions.computeIfAbsent(hashCode, _ -> new BitSet()).set(version);
>>> 1797: } catch (Ex
On Fri, 18 Oct 2024 13:59:32 GMT, Eirik Bjørsnøs wrote:
>> Please review this PR which speeds up `JarFile::getEntry` lookup
>> significantly for multi-release JAR files.
>>
>> The changes in this PR are motivated by the following insights:
>>
>> * `META-INF/versions/` is sparsely populated.
>>
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote:
> This brings in CPU24_10 changes into master branch.
This pull request has now been integrated.
Changeset: cf5bb127
Author: Jaikiran Pai
URL:
https://git.openjdk.org/jdk/commit/cf5bb12731b0eefe53b99281453e40493ddafbe4
St
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote:
> This brings in CPU24_10 changes into master branch.
Thank you Alan and Daniel for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/21533#issuecomment-2416550126
> This brings in CPU24_10 changes into master branch.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase.
-
Changes:
- all: https://git.openjdk.org/
This brings in CPU24_10 changes into master branch.
-
Commit messages:
- 8335713: Enhance vectorization analysis
- 8332644: Improve graph optimizations
- 8331446: Improve deserialization support
- 8307383: Enhance DTLS connections
- 8311208: Improve CDS Support
- 8328544: Improv
On Sat, 12 Oct 2024 01:59:29 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList sun/security/tools/keytool/GenKeyPairSigner.java.
Looks OK to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21481#pullrequestreview-2363716720
On Tue, 8 Oct 2024 15:28:17 GMT, Jan Lahoda wrote:
> Currently, running `java` without any parameters will lead to an output that
> is a full `--help`, which is over 100 lines (on my computer at least), and it
> feels overwhelming. And many people might actually want to run JShell/REPL,
> not
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates code and tests in `java.base` to
>> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH`
>> when referring to the JVM's maximum array size implementation limit.
>> Currentl
On Tue, 1 Oct 2024 05:39:09 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which updates code and tests in `java.base` to
>> consistently use `jdk.internal.util.ArraySupport.SOFT_MAX_ARRAY_LENGTH`
>> when referring to the JVM's maximum array size implementation limit.
>> Currentl
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
This pull request has now been integrated.
Changeset: 90d3a64b
Author: Jaikiran Pai
URL:
https://git.openjdk.org
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Thank you all for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/21108#issuecomment-2364052197
Can I please get a review of this trivial typo fix in `JarFile` class' javadoc?
-
Commit messages:
- 8340537: Typo in javadoc of java.util.jar.JarFile
Changes: https://git.openjdk.org/jdk/pull/21108/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21108&range=00
Issue: htt
On Tue, 10 Sep 2024 09:46:14 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change which replaces the usages of
> `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-83
On Wed, 11 Sep 2024 09:03:58 GMT, Alexey Ivanov wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update JImageToolTest too
>
> test/jdk/java/beans/Introspector/Test5102804.java line
deprecated and removed as part of
> https://bugs.openjdk.org/browse/JDK-8286851.
>
> There are some more tests remaining in client-libs area which too require a
> similar change. I'll be creating a separate JBS issue and PR for that.
Jaikiran Pai has updated the pull request i
deprecated and removed as part of
> https://bugs.openjdk.org/browse/JDK-8286851.
>
> There are some more tests remaining in client-libs area which too require a
> similar change. I'll be creating a separate JBS issue and PR for that.
Jaikiran Pai has updated the pull request i
Can I please get a review of this trivial change which replaces the usages of
`-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
outdated and support for them will soon be deprecated and removed as par
On Tue, 3 Sep 2024 13:07:47 GMT, Fernando Guallini
wrote:
> The test javax/net/ssl/DTLS/DTLSRehandshakeTest.java runs multiple scenarios,
> generating a large amount of logging as a result. Since Jtreg truncates the
> output when it becomes too large, the logs are often not useful for debuggin
On Mon, 26 Aug 2024 12:24:30 GMT, Julian Waters wrote:
> If no objections are raised by tomorrow morning I'll proceed with integration
I've run this PR against latest mainline in our CI for tier1, tier2 and tier3
and there were no failures. So yes, I think you can go ahead with the
integration
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Mon, 24 Jun 2024 12:07:49 GMT, Matthew Donovan wrote:
> In this PR, I updated the version of NSS to 3.101 and removed the test from
> the ProblemList for all platforms but linux-ppc64le (that bug is still
> outstanding.)
>
> I also updated the skipTest logic in TestDSAKeyLength.java. Prior
On Mon, 24 Jun 2024 12:31:20 GMT, Matthew Donovan wrote:
> 8324841: PKCS11 tests still skip execution
This is a clean backport of a test-only fix. Looks good to me for JDK 23.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19857#pullrequestrev
On Sat, 29 Jun 2024 18:24:46 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
>> to `ZipEntry.externalFileAttributes`.
>>
>> This field was introduced in
>> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
>>
On Sat, 29 Jun 2024 18:24:46 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
>> to `ZipEntry.externalFileAttributes`.
>>
>> This field was introduced in
>> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
>>
On Thu, 23 May 2024 09:11:33 GMT, Daniel Fuchs wrote:
>> This is one of these tests that is not really fixable if any other process
>> that might open a socket runs concurrently with it on the same machine:
>> nothing can guarantee that if you open a socket, close it, then open a new
>> socket
On Fri, 17 May 2024 13:38:25 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Thu, 16 May 2024 11:47:13 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/sun/launcher/resources/launcher.properties line
>> 72:
>>
>>> 70: \ by code in modules for which native access is not
>>> explicitly enabled.\n\
>>> 71: \ is one of "
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Wed, 15 May 2024 16:08:17 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Fri, 8 Mar 2024 09:34:05 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which suggests we rename `ZipEntry.extraAttributes`
>> to `ZipEntry.externalFileAttributes`.
>>
>> This field was introduced in
>> [JDK-8218021](https://bugs.openjdk.org/browse/JDK-8218021), originally under
>>
1 - 100 of 244 matches
Mail list logo
