On Mon, 10 Mar 2025 17:57:42 GMT, Artur Barashev wrote:
>> These resources files are in Java classes. If converted to properties files,
>> the localized versions can use UTF-8 encoding directly.
>>
>> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java
>> ./src/java.base/sha
On Fri, 7 Feb 2025 21:15:36 GMT, Leonid Mesnik wrote:
> The fix add remaining classes to the testlibrary jar and fix some warnings in
> security-related classes.
make/test/BuildTestLib.gmk line 61:
> 59:
> 60: ifeq ($(call isTargetOs, linux), false)
> 61: EXCLUDE_DIRS := jdk/test/lib/cont
On Wed, 23 Oct 2024 14:46:37 GMT, Fernando Guallini
wrote:
> The test sun/security/pkcs11/Provider/RequiredMechCheck.java extends
> sun/security/pkcs11/PKCS11Test.java, which sets up a PKCS11Provider
> configured with NSS config files located in the source tree directory
> (sun/security/pkcs1
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote:
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main change
On Fri, 7 Jun 2024 12:37:48 GMT, Julian Waters wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> test/jdk/java/rmi
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19537#pull
On Mon, 13 May 2024 11:47:38 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Mon, 4 Mar 2024 13:52:13 GMT, Jan Lahoda wrote:
> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
> automatically granted the native access. I am working on an upgrade of JLine
> inside the `jdk.internal.le` module, and I would like to replace the current
> native
On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Thu, 15 Feb 2024 12:26:11 GMT, Magnus Ihse Bursie wrote:
>> Since jcheck only checks file in a commit, there is a possibility of us
>> getting files in the repository that would not be accepted by jcheck. This
>> can happen when extending the set of files checked by jcheck, or if jcheck
>>
On Fri, 9 Feb 2024 13:42:02 GMT, Magnus Ihse Bursie wrote:
>> This is an attempt to finally implement the idea brought forward in
>> JDK-8295729: Properties files is essentially source code. It should have
>> the same whitespace checks as all other source code, so we don't get
>> spurious tra
On Fri, 2 Feb 2024 23:36:41 GMT, Joe Darcy wrote:
> After the "this-escape" lint warning was added to javac (JDK-8015831), the
> base module was not updated to be able to compile with this warning enabled.
> This PR makes the necessary changes to allow the base module to build with
> the warni
On Tue, 16 Jan 2024 16:31:32 GMT, Henry Jen wrote:
> CPU24_01 fixes.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/83#pullrequestreview-1826185706
On Tue, 16 Jan 2024 19:05:44 GMT, Henry Jen wrote:
>> CPU24_01 fixes.
>
> Henry Jen has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight additiona
On Mon, 30 Oct 2023 17:54:13 GMT, Volker Simonis wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>> This do
On Tue, 24 Oct 2023 19:58:58 GMT, Matthew Donovan wrote:
>> Hello,
>>
>> In this PR I removed NSS tests from the ProblemList and updated NssTest to
>> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
>> to NSS libraries installed on the test system. The tests can st
On Fri, 20 Oct 2023 19:18:47 GMT, Matthew Donovan wrote:
> Hello,
>
> In this PR I removed NSS tests from the ProblemList and updated NssTest to
> use Sqlite databases. I also removed code in PKCS11Test.java that falls back
> to NSS libraries installed on the test system. The tests can still b
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in.
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in.
On Tue, 5 Sep 2023 23:12:51 GMT, Chris Plummer wrote:
> I wonder if this is the right thing to do for the hprof files. I believe they
> originated from some hprof tools that we no longer ship. 3rd parties might
> choose to integrate them into their own tools.
Do you think I should revert them?
There are a number of files in the `test` directory that have an incorrect
copyright header, which includes the "classpath" exception text. This patch
removes that text from all test files that I could find it in. I did this using
a combination of `sed` and `grep`. Reviewing this patch is probab
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
The patch is leaving exactly one newline at the end of the file.
-
PR Comment: https://git.
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 10:19:38 GMT, Magnus Ihse Bursie wrote:
> After JDK-8294281, it is now possible to disable warnings for individual
> files instead for whole libraries. I used this opportunity to go through all
> disabled warnings in the security native libraries.
>
> Any warnings that were
On Mon, 17 Oct 2022 17:16:21 GMT, Alexey Semenyuk wrote:
> The change looks harmless. Howevere I don't understand how searching for the
> standard Windows libs can then become frustrating.
I believe this is part of the effort for
https://bugs.openjdk.org/browse/JDK-8288293.
-
PR:
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure pla
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
Thank you! Since I enabled visible whitespace
34 matches
Mail list logo
