Re: RFR: 8341964: Add mechanism to disable different parts of TLS cipher suite [v5]

2024-11-07 Thread David Schlosnagle
On Thu, 7 Nov 2024 22:13:04 GMT, Artur Barashev wrote: >> The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to >> disable algorithms that affect both the key exchange and authentication >> parts of a TLS cipher suite. For example, if you add "RSA" to the >> jdk.tls.disabl

Re: RFR: 8341964: Add mechanism to disable different parts of TLS cipher suite

2024-11-05 Thread David Schlosnagle
On Fri, 1 Nov 2024 18:06:30 GMT, Artur Barashev wrote: > The current syntax of the jdk.tls.disabledAlgorithms makes it difficult to > disable algorithms that affect both the key exchange and authentication parts > of a TLS cipher suite. For example, if you add "RSA" to the > jdk.tls.disabledAl

Re: RFR: 8330108: Increase CipherInputStream buffer size

2024-04-12 Thread David Schlosnagle
On Fri, 12 Apr 2024 15:34:01 GMT, Oli Gillespie wrote: > Increase buffer size in CipherInputStream from 512 bytes to 8192 bytes. > > I have seen applications where this small buffer size significantly reduces > throughput, and I've even seen applications which use reflection to modify > the bu

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey [v2]

2023-05-17 Thread David Schlosnagle
On Tue, 16 May 2023 09:18:57 GMT, Aleksey Shipilev wrote: >> One of our services has a hot path with AES/GCM cipher reuse. The JDK code >> reinitializes the session key on that path, and >> [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up >> prominently there. >> >> Fixing

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey [v2]

2023-05-16 Thread David Schlosnagle
On Tue, 16 May 2023 09:28:11 GMT, Aleksey Shipilev wrote: >> True, let me try that! > > New commit implements this, with even more performance benefits. Excellent, thanks! - PR Review Comment: https://git.openjdk.org/jdk/pull/13996#discussion_r1195043072

Re: RFR: 8308118: Avoid multiarray allocations in AESCrypt.makeSessionKey

2023-05-15 Thread David Schlosnagle
On Mon, 15 May 2023 19:59:13 GMT, Aleksey Shipilev wrote: > One of our services has a hot path with AES/GCM cipher reuse. The JDK code > reinitializes the session key on that path, and > [JDK-8308105](https://bugs.openjdk.org/browse/JDK-8308105) shows up > prominently there. While > [JDK-8308

Re: RFR: 8302017: Allocate BadPaddingException only if it will be thrown

2023-02-24 Thread David Schlosnagle
On Thu, 23 Feb 2023 18:15:35 GMT, Ahmed Muhsin wrote: > This change will move the instantiation of BadPaddingException into the > branch of the if statement where it is thrown. This will decrease the > overhead of calling `unpadV15` and `unpadOAEP`. Please see the associated > work item for p

Re: RFR: 8298381: Improve handling of session tickets for multiple SSLContexts [v2]

2022-12-20 Thread David Schlosnagle
On Tue, 20 Dec 2022 23:50:15 GMT, Volker Simonis wrote: >> Currently, TLS session tickets introduced by >> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018) in JDK 13 (i.e. >> `SessionTicketExtension$StatelessKey`) are generated in the class >> `SessionTicketExtension` and they use a

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v7]

2022-10-31 Thread David Schlosnagle
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of evalu

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-31 Thread David Schlosnagle
On Fri, 28 Oct 2022 20:04:18 GMT, Rémi Forax wrote: >> But it's an implementation details, BTW i wonder if the limitation is still >> valid, i know that John has changed the implementation of the BSM in that >> area. > > Anyway, i think you are right, this can be public If this is a public int

Re: RFR: 8292681: Add JMH for ProtectionDomain

2022-08-23 Thread David Schlosnagle
On Fri, 19 Aug 2022 18:48:10 GMT, Eric Caspole wrote: > Add a JMH for ProtectionDomain related to current work on JDK-8292375. Also, > add the InMemoryJavaCompiler to the JMH jar, to generate the classes needed > for this test and will be useful for future class loading JMH too. test/micro/org

Re: RFR: 8288568: Reduce runtime of java.security microbenchmarks [v2]

2022-07-19 Thread David Schlosnagle
On Fri, 17 Jun 2022 12:24:50 GMT, Claes Redestad wrote: >> - Reduce forks, iteration, runtime to reduce runtime while maintaining high >> data quality on typical benchmarking hosts. >> >> Reduces runtime from estimated 10+ hours to 54 minutes. > > Claes Redestad has updated the pull request inc