Integrated: 8319651: Several network tests ignore vm flags when start java process

2024-02-20 Thread Darragh Clarke
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/j

Re: RFR: 8319651: Several network tests ignore vm flags when start java process [v2]

2024-02-16 Thread Darragh Clarke
t/URLConnection/6212146/TestDriver.java` have been set to > use `@require vm.flagless` because they both use `sh` commands. > > I've ran these changes against tiers 1-3 and everything seems stable Darragh Clarke has updated the pull request incrementally with two additional commits sin

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-16 Thread Darragh Clarke
On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke wrote: > Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/j

Re: RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-12 Thread Darragh Clarke
On Fri, 9 Feb 2024 12:48:48 GMT, Daniel Fuchs wrote: >> Currently these tests ignore vm flags, In most cases I've updated them to >> use `ProcessTools.createTestJavaProcessBuilder` this usually required some >> cleanup also. >> >> `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.j

RFR: 8319651: Several network tests ignore vm flags when start java process

2024-02-09 Thread Darragh Clarke
Currently these tests ignore vm flags, In most cases I've updated them to use `ProcessTools.createTestJavaProcessBuilder` this usually required some cleanup also. `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and `test/jdk/java/net/URLConnection/6212146/TestDriver.java` ha

Integrated: 7065228: To interpret case-insensitive string locale independently

2023-05-22 Thread Darragh Clarke
On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke wrote: > Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-22 Thread Darragh Clarke
On Fri, 19 May 2023 11:24:30 GMT, Michael McMahon wrote: > Seems like a useful change and I can see how issues could arise if strings > were stored somewhere after being upper/lower cased and then reused in a > different locale. > > Is it correct to say that the assumption is these strings are

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-17 Thread Darragh Clarke
On Wed, 17 May 2023 10:41:57 GMT, Daniel Jeliński wrote: >> Darragh Clarke has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update >> src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthe

Re: RFR: 7065228: To interpret case-insensitive string locale independently [v2]

2023-05-17 Thread Darragh Clarke
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io > files to specify `Locale.ROOT` to ensure that case conversion issues don't > occur, > > I didn't add any new tests but ran tier 1-3 with no issues Darragh Clarke has updated the pull reque

RFR: 7065228: To interpret case-insensitive string locale independently

2023-05-16 Thread Darragh Clarke
Updated instances of `toLowerCase` and `toUpperCase` in several net and io files to specify `Locale.ROOT` to ensure that case conversion issues don't occur, I didn't add any new tests but ran tier 1-3 with no issues - Commit messages: - added some case conversions missed previousl