Integrated: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Daniel D . Daugherty
On Sat, 12 Oct 2024 01:59:29 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList sun/security/tools/keytool/GenKeyPairSigner.java. This pull request has now been integrated. Changeset: 2e1c1936 Author: Daniel D. Daugherty URL: https://git.openjdk.org/jdk/com

Re: RFR: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Daniel D . Daugherty
On Sat, 12 Oct 2024 02:04:56 GMT, Jaikiran Pai wrote: >> A trivial fix to ProblemList >> sun/security/tools/keytool/GenKeyPairSigner.java. > > Looks OK to me. @jaikiran - Thanks for the fast review! Especially for a Friday night... I'm holding off on integrating until I see if it repros in the

RFR: 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java

2024-10-11 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/security/tools/keytool/GenKeyPairSigner.java. - Commit messages: - 8342003: ProblemList sun/security/tools/keytool/GenKeyPairSigner.java Changes: https://git.openjdk.org/jdk/pull/21481/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21481&ra

Re: RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

Integrated: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java

2023-06-06 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and windows-x64. The test is already ProblemListed on linux-all. - Commit messages: - 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java Changes: https://git.openj

Integrated: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java

2023-06-06 Thread Daniel D . Daugherty
On Tue, 6 Jun 2023 22:01:10 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and > windows-x64. > > The test is already ProblemListed on linux-all. This pull request has now been integra

Re: Integrated: 8309570: ProblemList sun/security/pkcs11/Signature/TestRSAKeyLength.java

2023-06-06 Thread Daniel D . Daugherty
On Tue, 6 Jun 2023 22:05:22 GMT, Jonathan Gibbons wrote: >> A trivial fix to ProblemList >> sun/security/pkcs11/Signature/TestRSAKeyLength.java on macosx-x64 and >> windows-x64. >> >> The test is already ProblemListed on linux-all. > > Marked as reviewed by jjg (Reviewer). @jonathan-gibbons a

Integrated: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 20:49:26 GMT, Daniel D. Daugherty wrote: > Trivial fixes to ProblemList a few tests: > - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList > jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 > - [JDK-8307490](https://bugs.openjdk.or

Re: RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
On Thu, 4 May 2023 21:21:38 GMT, Joe Darcy wrote: >> Trivial fixes to ProblemList a few tests: >> - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList >> jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 >> - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) Pro

RFR: 8307489: ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64

2023-05-04 Thread Daniel D . Daugherty
Trivial fixes to ProblemList a few tests: - [JDK-8307489](https://bugs.openjdk.org/browse/JDK-8307489) ProblemList jdk/incubator/vector/LoadJsvmlTest.java on windows-x64 - [JDK-8307490](https://bugs.openjdk.org/browse/JDK-8307490) ProblemList sun/security/pkcs11/Cipher/TestKATForGCM.java on linux

Re: RFR: 8294985: SSLEngine throws IAE during parsing of X500Principal [v2]

2023-04-28 Thread Daniel D . Daugherty
On Fri, 14 Apr 2023 19:03:16 GMT, Kevin Driver wrote: >> Fixes: [JDK-8294985](https://bugs.openjdk.org/browse/JDK-8294985) > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > updated copyright Try this: "/issue JDK-8294985" (I

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library [v2]

2023-03-20 Thread Daniel D . Daugherty
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung wrote: >> `ModuleInfoWriter` is not used by the runtime. Move it to the test library >> as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the >> test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >>

Re: RFR: 8301189: validate-source fails after JDK-8298873

2023-01-26 Thread Daniel D . Daugherty
On Thu, 26 Jan 2023 19:06:40 GMT, Matthew Donovan wrote: > fixed copyright header Thumbs up. This is a trivial fix. The file is also missing an EOL on the last line. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.org/jdk/pull/12232

Re: RFR: 8298274: Problem list TestSPISigned on Windows

2022-12-07 Thread Daniel D . Daugherty
On Wed, 7 Dec 2022 14:41:03 GMT, Severin Gehwolf wrote: > The test is failing on Windows. Problem list it until it can get properly > analyzed and fixed. Thumbs up. This is a trivial fix. Your ProblemList entry is properly formed. Please go ahead and integrate. - Marked as review

Re: RFR: 8296675: Exclude linux-aarch64 in NSS tests

2022-11-09 Thread Daniel D . Daugherty
On Wed, 9 Nov 2022 16:01:33 GMT, Weijun Wang wrote: > The NSS tests do not work fine on linux-aarch64 now. Disable them at the > moment. Thumbs up. This is a trivial fix. Do we know if these tests will also fail on linux-x64 OL9? - Marked as reviewed by dcubed (Reviewer). PR: ht

Re: RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread Daniel D . Daugherty
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release > date). > > Thanks. Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.org/jdk/pull/9581

Integrated: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. This pull request has now been integrated. Changeset: 9c19d89c Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/9c19d89c9c564e436732c5f7851f4960fb5d783c Stats: 504 li

Re: RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. Mach5 Tier1 passed. - PR: https://git.openjdk.org/jdk/pull/9578

RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
Merge jdk19 -> jdk20. - Commit messages: - Merge - 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update - 8278274: Update nroff pages in JDK 19 before RC - 8287916: Address the inconsistency between the constant array and pool size - 8285407: Improve Xalan