Re: RFR: 8293810: Remove granting of RuntimePermission("stopThread") from tests

2022-10-06 Thread Chris Hegarty
On Wed, 5 Oct 2022 15:01:15 GMT, Alan Bateman wrote: > This is a test only change to remove the granting of > RuntimePermission("stopThread") from the tests. With Thread.stop changed to > throw UOE it means there is nothing that requires this permission. LGTM - Marked as reviewed

Re: RFR: 8289768: Clean up unused code [v3]

2022-07-11 Thread Chris Hegarty
On Fri, 8 Jul 2022 07:08:46 GMT, Daniel JeliƄski wrote: >> This patch removes many unused variables and one unused label reported by >> the compilers when relevant warnings are enabled. >> >> The unused code was found by compiling after removing `unused` from the list >> of disabled warnings

Re: RFR: 8286389: Address possibly lossy conversions in jdk.crypto.ec

2022-06-17 Thread Chris Hegarty
On Fri, 17 Jun 2022 16:05:38 GMT, Ryan Ernst wrote: > Applied required casts in jdk.crypto.ec for the upcoming warning. > Verified by cherry-picking @asotona's patch. Looks good to me. I'm happy to sponsor this change, once a reviewer from the security area has had a chance to take a look. ---

Re: RFR: 8286395: Address possibly lossy conversions in java.security.jgss

2022-06-17 Thread Chris Hegarty
On Fri, 17 Jun 2022 16:09:41 GMT, Ryan Ernst wrote: > Applied required casts in java.security.jgss for the upcoming warning. > Verified by cherry-picking @asotona's patch. Looks good to me. I'm happy to sponsor this change, once a reviewer from the security area has had a chance to take a look.