Re: RFR: 8296507: GCM using more memory than necessary with in-place operations [v7]

2022-12-08 Thread Carter Kozak
On Thu, 8 Dec 2022 18:24:03 GMT, Andrew Haley wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - editor screwed up >> - why won't this merge hell stop 2 >> - why won't this merge hell stop 3 > > What benchma

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations

2022-11-17 Thread Carter Kozak
On Thu, 17 Nov 2022 18:24:07 GMT, Anthony Scarpino wrote: > Looking at this, it's not related to the same in-place issues. This is a > result of the combined intrinsics requirement . Maybe some better tuning can > be done, but I think this is unavoidable. I can consider this in a future PR Th

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations

2022-11-16 Thread Carter Kozak
On Sun, 13 Nov 2022 02:54:10 GMT, Anthony Scarpino wrote: > I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > m

Re: RFR: 8296507: GCM using more memory than necessary with in-place operations

2022-11-16 Thread Carter Kozak
On Sun, 13 Nov 2022 02:54:10 GMT, Anthony Scarpino wrote: > I would like a review of an update to the GCM code. A recent report showed > that GCM memory usage for TLS was very large. This was a result of in-place > buffers, which TLS uses, and how the code handled the combined intrinsic > m

Re: TLS Performance Regression in JDK18+

2022-11-07 Thread Carter Kozak
(or resource utilization depending on the GC) across an application, especially one that's already allocating heavily. > I have to see if I can change the code path without hurting the > decryption performance gains from the AVX512 intrinsic. That would be fantastic, thank you! Thanks, Carter Kozak

Re: TLS Performance Regression in JDK18+

2022-11-07 Thread Carter Kozak
Following up, were you able to run the benchmark across openjdk releases? If so, can you confirm whether your observations matched my own? I really appreciate your help looking into this! Thanks, Carter Kozak

Re: TLS Performance Regression in JDK18+

2022-11-02 Thread Carter Kozak
erformance' that will use your JAVA_HOME envvar. Best, Carter Kozak

TLS Performance Regression in JDK18+

2022-10-31 Thread Carter Kozak
s are located here: https://github.com/carterkozak/java-crypto-allocation-performance/tree/develop/jmh-results I'm sorry if this has already been reported or is otherwise already being tracked. Please let me know if additional information would be helpful. Best, Carter Kozak

Re: Clogged pipes: 50x throughput degradation with large Cipher writes

2022-10-27 Thread Carter Kozak
besides a benchmark? Yes! The benchmark is the result of investigation into a performance problem in production, where we confirmed our profiling results, implemented a fix, and confirmed the benchmarking improvements were relevant in the original production scenario. Carter Kozak

Re: Clogged pipes: 50x throughput degradation with large Cipher writes

2022-10-27 Thread Carter Kozak
rify. You said JSSE, does this actually happen in TLS usage - how > big are your TLS Records? Isn’t there a 16k limit anyway? I'm sorry, I confused initialisms, I believe JCE is more accurate. I can test TLS, but that's not the scenario where this was problematic in production. Carter Kozak

Clogged pipes: 50x throughput degradation with large Cipher writes

2022-10-26 Thread Carter Kozak
. Is there a solution which allows us to get the best of both worlds? Thanks, Carter Kozak