On Wed, 16 Apr 2025 19:22:51 GMT, Vladimir Ivanov wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed asserts.
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 717:
>
>> 715: desc_len = (int)strlen(_c
On Thu, 17 Apr 2025 09:40:02 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 717:
>>
>>> 715: desc_len = (int)strlen(_cpu_desc);
>>> 716: snprintf(_cpu_desc + desc_len, CPU_DETAILED_DESC_BUF_SIZE -
>>> desc_len, " %s", _features_string);
>>> 717: fprintf(
On Tue, 15 Apr 2025 18:18:36 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/register_aarch64.hpp line 509:
> 507: }
> 508:
> 509: // convenience methods
On Mon, 14 Apr 2025 12:26:09 GMT, Ferenc Rakoczi wrote:
>> @ferakocz Hi Ferenc. Thank you for adjusting the code as requested and even
>> more so for the extra clean-ups you added which I very much appreciate.
>>
>> I have added suggestions for some extra/modified commenting to clarify
>> cert
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5684:
> 5682: VSeq<2> vs5(vs3[1], del
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5661:
> 5659: // load 16 zetas
> 5660: vs
On Tue, 15 Apr 2025 15:09:16 GMT, Ferenc Rakoczi wrote:
>> @adinn Hi, Andrew,
>> I think I addressed all of your comment improvement comments, in most cases
>> I just changed them as you suggested. Thanks a lot for the thorough review!
>
>> @ferakocz
>>
>> Hi Ferenc,
>>
>> Sorry, but I still
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5690:
> 5688: kyber_montmul32(vs1, vs3, vc,
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5665:
> 5663: vs_ld2_post(vs_back(vs1), __ T8H,
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5590:
> 5588: __ add(tmpAddr, coeffs, 0);
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
@ferakocz Hi Ferenc. Thank you for adjusting the code as requested and even
more so for the extra clean-ups yo
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/register_aarch64.hpp line 510:
> 508:
> 509: // convenience methods for spli
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5933:
> 5931: vs_ld3_post(vin, __ T16B, con
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5300:
> 5298: // level 5
> 5299: vs_ldpq(
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Code rearrange, some renaming, fixing comments
> - Changes suggested by Andrew Dinn.
src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5278:
> 5276: // level 4
> 5277: vs_ldpq(
On Sun, 23 Mar 2025 17:00:43 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request with a new ta
On Tue, 4 Mar 2025 22:04:26 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request with a new tar
On Fri, 21 Mar 2025 13:59:10 GMT, Andrew Dinn wrote:
>> Ferenc Rakoczi has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Fixed mismerge.
>> - Merged master.
>> -
On Tue, 4 Mar 2025 11:11:44 GMT, Ferenc Rakoczi wrote:
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+5000))
>
>> Oops. sorry - cut and paste error -- the new setting should be
>>
>> ```
>> do_arch_blob(compiler, 55000 ZGC_ONLY(+50
updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 13 commits:
>
> - Merged master.
> - Added more comments, mainly as suggested by Andrew Dinn
> - Changed aarch64-asmtest.py as suggested by Bhavana-Kilambi
> - A
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Added more comments, mainly as suggested by Andrew Dinn
> - Changed aarch64-asmtest.py as suggested by Bhavana-Kilambi
Oops. sorry - cut and paste error -- the new setting should be
d
On Fri, 21 Feb 2025 10:23:37 GMT, Ferenc Rakoczi wrote:
>> Hi. Here is the test result of our CI.
>>
>> ### copyright year
>>
>> the following files should update the copyright year to 2025.
>>
>>
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp
>> src/hotspot/cpu/aarch64/stubRoutines_aarch64
updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Added more comments, mainly as suggested by Andrew Dinn
> - Changed aarch64-asmtest.py as suggested by Bhavana-Kilambi
Ok, still good
-
Marked as reviewed by
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
Marked as reviewed by a
On Thu, 20 Feb 2025 17:22:25 GMT, Ferenc Rakoczi wrote:
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 2618:
>>
>>> 2616: INSN(smaxp, 0, 0b101001, false); // accepted arrangements: T8B,
>>> T16B, T4H, T8H, T2S, T4S
>>> 2617: INSN(sminp, 0, 0b101011, false); // accepted arrangements
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
I raised [JDK-8350589](h
On Fri, 21 Feb 2025 10:23:37 GMT, Ferenc Rakoczi wrote:
>> Hi. Here is the test result of our CI.
>>
>> ### copyright year
>>
>> the following files should update the copyright year to 2025.
>>
>>
>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp
>> src/hotspot/cpu/aarch64/stubRoutines_aarch64
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
Please add comment
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
src/hotspot/cpu/aarch64/st
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
src/hotspot/cpu/aarch64/st
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
src/hotspot/cpu/aarch64/st
updated the pull request incrementally with four
> additional commits since the last revision:
>
> - Accepting suggested change from Andrew Dinn
> - Added comments suggested by Andrew Dinn
> - Fixed copyright years
> - renaming a couple of functions
src/hotspot/cpu/aarch64/st
On Mon, 24 Feb 2025 07:41:58 GMT, Hao Sun wrote:
>> @shqking, I changed the copyright years, but I don't really understand how
>> the aarch64-specific code can overflow buffers on other architectures. As
>> far as I understand, Instruction_aarch64 should not have been there in a ppc
>> build.
On Tue, 4 Feb 2025 18:57:28 GMT, Ferenc Rakoczi wrote:
>>> @ferakocz I'm afraid you lucked out on getting your change committed before
>>> my reorganization of the stub generation code. If you are unsure of how to
>>> do the merge so your new stub is declared and generated following the new
>>
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Thu, 6 Feb 2025 18:47:54 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request in
On Tue, 4 Feb 2025 18:57:28 GMT, Ferenc Rakoczi wrote:
>>> @ferakocz I'm afraid you lucked out on getting your change committed before
>>> my reorganization of the stub generation code. If you are unsure of how to
>>> do the merge so your new stub is declared and generated following the new
>>
On Mon, 3 Feb 2025 18:11:51 GMT, Ferenc Rakoczi wrote:
>> @ferakocz I'm afraid you lucked out on getting your change committed before
>> my reorganization of the stub generation code. If you are unsure of how to
>> do the merge so your new stub is declared and generated following the new
>> mo
On Thu, 30 Jan 2025 16:14:27 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-DSA algorithms (key generation, document signing, signature verification)
>> can be approximately doubled.
>
> Ferenc Rakoczi has updated the pull request i
ys to address security concerns and we will
continue to do so as Java evolves.
regards,
Andrew Dinn
---
gards,
Andrew Dinn
---
On Fri, 2 Jun 2023 09:58:59 GMT, Andrew Dinn wrote:
>> Yes, of course, you are right that 0<= U_2 < 6 at the point where that
>> second multiply by 5 occurs (i.e. after the loop).
>>
>> I believe it is safe to use the same optimization inside the loop for
>&g
On Fri, 2 Jun 2023 09:51:57 GMT, Andrew Dinn wrote:
>>> This comment and the next one both need correcting. They mention U_0HI and
>>> U_1HI and, as the previous comment says, those registers are dead.
>>>
>>> What actually happens here is best summarized a
On Thu, 1 Jun 2023 16:06:40 GMT, Andrew Haley wrote:
>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7135:
>>
>>> 7133: regs = (regs.remaining() + U_0HI + U_1HI).begin();
>>> 7134:
>>> 7135: // U_2:U_1:U_0 += (U_1HI >> 2)
>>
>> This comment and the next one both need corr
On Thu, 1 Jun 2023 16:16:32 GMT, Andrew Haley wrote:
>> This provides a solid speedup of about 3-4x over the Java implementation.
>>
>> I have a vectorized version of this which uses a bunch of tricks to speed it
>> up, but it's complex and can still be improved. We're getting close to ramp
>>
On Wed, 24 May 2023 16:17:14 GMT, Andrew Haley wrote:
>> This provides a solid speedup of about 3-4x over the Java implementation.
>>
>> I have a vectorized version of this which uses a bunch of tricks to speed it
>> up, but it's complex and can still be improved. We're getting close to ramp
>
47 matches
Mail list logo
