On Mon, 12 May 2025 19:42:15 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request with a new target base due to a
> merge or a rebase. The incremen
On Fri, 9 May 2025 15:37:44 GMT, Ben Perez wrote:
> Added custom multi array allocation function to improve performance
Are you planning to include a micro and sample results?
-
PR Comment: https://git.openjdk.org/jdk/pull/25151#issuecomment-2867062412
On Thu, 8 May 2025 16:43:10 GMT, Leo Korinth wrote:
>> This change tries to add timeout to individual testcases so that I am able
>> to run them with a timeout factor of 1 in the future (JDK-8260555).
>>
>> The first commit changes the timeout factor to 0.7, so that I can run tests
>> and test
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote:
>> Document preconditions on certain `JavaLangAccess` methods that use
>> operations either unsafe and/or without range checks.
>
> Volkan Yazici has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 15 Apr 2025 07:46:52 GMT, Alan Bateman wrote:
>> Hi, this is a proposal to fix 8352728.
>>
>> The main idea is to replace
>> [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(
On Fri, 25 Apr 2025 14:26:43 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Sat, 5 Apr 2025 02:36:43 GMT, Francisco Ferrari Bihurriet
wrote:
> Hi, this is a proposal to fix 8352728.
>
> The main idea is to replace
> [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOp
On Sun, 13 Apr 2025 20:01:28 GMT, Weijun Wang wrote:
> I remember the implies method of the file permission class depends on whether
> this system property is set. Although file permission is no longer used in
> access control check the class and the method are still there.
Right, and I wasn't
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote:
> The JavaIOFilePermissionAccess interface is removed from SharedSecrets and
> its implementation (FilePermCompat.java) used by the test is moved to java.io
> FilePermission where cross package access is not needed.
> The test FilePermission
On Fri, 11 Apr 2025 11:30:54 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/HttpURLConnection.java line 617:
>>
>>> 615: * {@link java.security.AllPermission}.
>>> 616: */
>>> 617: @Deprecated(since = "25")
>>
>> can this (and all other getPermission methods) be
On Sat, 5 Apr 2025 02:36:43 GMT, Francisco Ferrari Bihurriet
wrote:
> Hi, this is a proposal to fix 8352728.
>
> The main idea is to replace
> [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOp
On Tue, 8 Apr 2025 21:03:18 GMT, Chen Liang wrote:
>> Oh, I didn't know that. I've built this with JDK 24 as the boot JDK and see
>> no problem.
>
> I think the dependency is in the CreateSymbols tool or something
Yes, we've had issues with boot cycle builds at least, Jan has the details and
I
On Mon, 7 Apr 2025 18:40:35 GMT, Roger Riggs wrote:
>> Now that the Security Manager is permanently disabled, the following
>> permission classes in the core libraries area can be deprecated for removal
>> as they are no longer useful: FilePermission, LinkPermission,
>> LoggingPermission, Prop
On Fri, 4 Apr 2025 19:22:46 GMT, Roger Riggs wrote:
>> Now that the Security Manager is permanently disabled, the following
>> permission classes in the core libraries area can be deprecated for removal
>> as they are no longer useful: FilePermission, LinkPermission,
>> LoggingPermission, Prop
On Mon, 10 Mar 2025 18:11:23 GMT, Per Minborg wrote:
> Implement JEP 502.
>
> The PR passes tier1-tier3 tests.
src/jdk.unsupported/share/classes/sun/misc/Unsafe.java line 983:
> 981:
> 982: @ForceInline
> 983: private static void assertNotTrusted(Field f) {
I don't think this can be
On Sun, 9 Feb 2025 05:02:07 GMT, Hai-May Chao wrote:
> The jarsigner -verify command currently performs verification by reading from
> JarFile to navigate the central directory (CEN) headers. It is now enhanced
> to include cross-validation of entries between JarFile (CEN-based) and
> JarInput
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to mostly add missing `@serial` javadoc
>> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the
>> javadoc `-serialwarn` option in the JDK doc build, which has been disabled
>> since
On Wed, 22 Jan 2025 16:59:04 GMT, Aleksey Shipilev wrote:
> `Reference.waitForReferenceProcessing` is in internal API, which should go
> away with [JDK-8344332](https://bugs.openjdk.org/browse/JDK-8344332). There
> is single use of that internal API in the tests, the last use of which was
> re
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds the `final` modifier to non-subclassable
> classes in `java.base`.
>
> The classes were identified using an automated analysis. See CSR for details.
>
> Besides simply adding the `final` access modifier,
On Wed, 8 Jan 2025 19:41:42 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to add missing `@serial` javadoc tags in
> module `java.base`. This is a sub-task of [JDK-8286931] to allow us to
> re-enable the javadoc `-serialwarn` option in the JDK doc build, which has
> been disab
On Fri, 6 Dec 2024 21:15:23 GMT, Kevin Driver wrote:
> A regression was introduced by
> [JDK-8338383](https://bugs.openjdk.org/browse/JDK-8338383). Remove the forced
> static eager initialization.
Would it be possible to create some follow-up issues to re-visit the class
initialisers and the
On Fri, 6 Dec 2024 10:55:08 GMT, Prasadrao Koppula wrote:
> > Would it possible to list down the API entry points where you want map the
> > InputStream back to its source? I assume methods such as
> > KeyStore.getInstance(File file, ..) are not a concern, is it the
> > load(InputStream,passwo
On Wed, 27 Nov 2024 14:39:31 GMT, Prasadrao Koppula
wrote:
>> Using SharedSecrets, I attempted to expose FileInputStream::path
>> information. After implementing the fix, I validated the startup performance
>> tests. Observed no consistent pattern of performance drops or gains, can
>> disrega
On Tue, 3 Dec 2024 14:45:22 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove an obsolete comment r
On Mon, 2 Dec 2024 22:18:33 GMT, Sean Mullan wrote:
> A few additional changes should be made to the API specs for these classes .
> These changes are documenting behavior of other APIs that has already been
> approved as part of JEP 486, so I don't think a CSR is necessary, but
> opinions on
On Tue, 3 Dec 2024 06:12:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 22:51:55 GMT, Roger Riggs wrote:
>> Remove sun/security/action/GetPropertyAction.java and all uses.
>>
>> Dependent on PR#22418
>
> Roger Riggs has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 15 commits:
>
> -
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java line 710:
> 708:
> 709: static {
> 710: Properties props = GetPrope
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes usages of
>> SecurityManager related APIs and some leftover related to SecurityManager
>> changes?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
>>
On Mon, 2 Dec 2024 18:48:27 GMT, Sean Mullan wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 13 commits:
>>
>> - merge latest from master branch
>> - remove changes to
>> src/java.base/unix/classes/sun/se
On Mon, 2 Dec 2024 18:12:55 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>>
>> This should cover most of the remaining cl
On Mon, 2 Dec 2024 12:13:57 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which removes usages of
> SecurityManager related APIs and some leftover related to SecurityManager
> changes?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these
> change
On Thu, 14 Nov 2024 01:35:10 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Serviceability area modules. The test is described in
>> this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.
On Thu, 28 Nov 2024 17:26:04 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>>
>> This should cover most of the remaining c
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
On Thu, 28 Nov 2024 13:58:58 GMT, Aleksei Efimov wrote:
>> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
>> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
>> `jdk.naming.dns` modules.
>>
>> One noteworthy change: The `java.naming.rmi.security.manager
On Wed, 27 Nov 2024 14:39:21 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security.KeyStore` and
>> `Identity` API and impl dependencies on `System.getSecurityManager`,
>> `AccessController.doPrivileged` and `AccessControlContext` can be removed.
>>
>> Most of the cha
On Thu, 28 Nov 2024 00:17:43 GMT, Aleksei Efimov wrote:
> The proposed change cleans-up `SecurityManager`, `doPriviledged`, and
> `AccessController` usages from `java.naming`, `jdk.naming.rmi` and
> `jdk.naming.dns` modules.
>
> One noteworthy change: The `java.naming.rmi.security.manager` JND
On Wed, 27 Nov 2024 19:59:24 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, `java.security` and `sun.security`
>> implementation dependencies on `System.getSecurityManager` and
>> `AccessController.doPrivileged` can be removed.
>>
>> This should cover most of the remaining c
On Tue, 26 Nov 2024 13:28:14 GMT, Sean Mullan wrote:
> The Serial Data section of
> `javax.security.auth.Subject.SecureSet.writeObject()` should be removed as it
> no longer does a security check now that the Security Manager is permanently
> disabled.
Marked as reviewed by alanb (Reviewer).
On Mon, 25 Nov 2024 20:33:49 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `javax.security` package
>> implementation dependencies on `System.getSecurityManager`,
>> `AccessController.doPrivileged` and `AccessControlContext` can be removed.
>>
>> Most of the changes are
On Mon, 25 Nov 2024 19:55:46 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
On Mon, 25 Nov 2024 19:22:51 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
On Mon, 25 Nov 2024 18:51:48 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
On Mon, 25 Nov 2024 18:51:48 GMT, Brian Burkhalter wrote:
>> Make the memory used by internal temporary direct buffers not count towards
>> the upper limit on direct buffer memory.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revisi
On Mon, 25 Nov 2024 17:40:12 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, the `javax.security` package
> implementation dependencies on `System.getSecurityManager`,
> `AccessController.doPrivileged` and `AccessControlContext` can be removed.
>
> Most of the changes are strai
On Mon, 25 Nov 2024 17:40:12 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, the `javax.security` package
> implementation dependencies on `System.getSecurityManager`,
> `AccessController.doPrivileged` and `AccessControlContext` can be removed.
>
> Most of the changes are strai
On Mon, 25 Nov 2024 17:21:31 GMT, Brian Burkhalter wrote:
> At present the explicit deallocation uses the cleaner:
Right but if we change this then you should find the "temporary" field goes
away as it will be different deallocator.
-
PR Comment: https://git.openjdk.org/jdk/pull/2
On Thu, 14 Nov 2024 21:34:08 GMT, Larry Cable wrote:
> c.f:
> [https://bugs.openjdk.org/browse/JDK-8339420](https://bugs.openjdk.org/browse/JDK-8339420)
>
> Summary
> ---
>
> Add `jcmd Thread.vthread_summary` to print summary information that is
> useful when trying to diagnose issues wi
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote:
> This PR proposes to use `StaticProperty.javaHome()` instead of
> `System.getPropoerty("java.home")` in some internal classes.
Marked as reviewed by alanb (Reviewer).
Updated change looks okay. The CDS method is only invoked at dump time so
On Mon, 18 Nov 2024 17:52:04 GMT, Per Minborg wrote:
> This PR proposes to use `StaticProperty.javaHome()` instead of
> `System.getPropoerty("java.home")` in some internal classes.
src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java line 52:
> 50:
> 51: private static
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote:
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
While you are there, can you also look into not creating a Cleaner for the
temporary direct buffers? They are expli
On Thu, 21 Nov 2024 22:36:22 GMT, Sean Mullan wrote:
> Specify that the access control context parameters of
> `Subject.doAsPrivileged` are ignored. This spec update was missed as part of
> JEP 486.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/
On Tue, 19 Nov 2024 16:53:27 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
On Tue, 19 Nov 2024 16:21:11 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `jdk.sctp` module.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
On Tue, 19 Nov 2024 10:48:37 GMT, Eirik Bjørsnøs wrote:
> Please review this trivial cleanup of an unused import of
> `AccessControlContext ` in `JavaLangAccess`.
>
> This was left over after #22035 removed
> `JavaLangAccess::newThreadWithAcc(Runnable, AccessControlContext)`.
>
> Verificatio
On Mon, 18 Nov 2024 21:56:12 GMT, Brian Burkhalter wrote:
>> Expunge the use of the `SecurityManager`, `AccessController`, and the like
>> from the `java.io` package.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 834
On Tue, 19 Nov 2024 01:17:55 GMT, Brian Burkhalter wrote:
> Expunge the use of the `SecurityManager`, `AccessController`, and the like
> from the `jdk.sctp` module.
Marked as reviewed by alanb (Reviewer).
src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpNet.java line 94:
> 92: set =
On Thu, 14 Nov 2024 14:42:30 GMT, Alan Bateman wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More obsolete code. Fix trace_class_resolution (doesn't throw exception -
>>
On Thu, 14 Nov 2024 14:03:50 GMT, Coleen Phillimore wrote:
>> Remove Hotspot code that passes protection_domain around class loading so
>> that checkPackageAccess can be called and the result stored. With the
>> removal of the Security Manager in JEP 486, this code no longer does
>> anything.
On Thu, 14 Nov 2024 13:20:23 GMT, Alan Bateman wrote:
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>>
>> I think this is obsolete too.
>
>> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>>
>> I think this is obsolete t
On Thu, 14 Nov 2024 13:07:55 GMT, Coleen Phillimore wrote:
> hotspot/share/include/jvm.h:JVM_GetClassContext(JNIEnv *env);
>
> I think this is obsolete too.
As part of the JEP 486 work, I changed SecurityManager::getClassContext to use
StackWalker, the native method that called into JVM_GetCla
On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which cleans up security manager related code in
> `java.util.zip` and `java.util.jar`:
>
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of
> `GetPropertyAction::privilegedGetProperty`
On Wed, 13 Nov 2024 11:42:11 GMT, Coleen Phillimore wrote:
> Remove Hotspot code that passes protection_domain around class loading so
> that checkPackageAccess can be called and the result stored. With the
> removal of the Security Manager in JEP 486, this code no longer does anything.
>
> T
On Thu, 14 Nov 2024 06:16:56 GMT, David Holmes wrote:
> To be fair I'm unclear what role PD still plays on the JDK side and would not
> be surprised if it is destined for removal at some point.
PD is not deprecated as PD::getCodeSource is widely used. It may be that an
alternative means is in
On Tue, 12 Nov 2024 10:41:48 GMT, Alan Bateman wrote:
> Removes the SecurityManager usage from Thread + friends.
>
> In Thread, the getContextClassLoader method is no longer caller-sensitive
> method.
>
> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.acce
On Tue, 12 Nov 2024 22:08:42 GMT, Roger Riggs wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 227 commits:
>>
>> - Merge branch 'master' i
On Tue, 12 Nov 2024 19:06:31 GMT, Daniel Fuchs wrote:
> The proposed changes look reasonable to me. Good simplification of the code.
> I had some uncertainty about the JNDI changes but I couldn't find any place
> in JNDI where a Subject would be extracted from the ACC associated with the
> cre
f newThreadWithAcc is removed from
> com.sun.jndi.ldap.VersionHelper. There will be further work on the
> java.naming module to remove usage of SM, the change here is specific to the
> usage of ewThreadWithAcc.
Alan Bateman has updated the pull request with a new target base due to a merge
f newThreadWithAcc is removed from
> com.sun.jndi.ldap.VersionHelper. There will be further work on the
> java.naming module to remove usage of SM, the change here is specific to the
> usage of ewThreadWithAcc.
Alan Bateman has updated the pull request with a new target base due to a merge
f newThreadWithAcc is removed from
> com.sun.jndi.ldap.VersionHelper. There will be further work on the
> java.naming module to remove usage of SM, the change here is specific to the
> usage of ewThreadWithAcc.
Alan Bateman has updated the pull request with a new target base due to a merge
Removes the SecurityManager usage from Thread + friends.
In Thread, the getContextClassLoader method is no longer caller-sensitive
method.
JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no longer
exported to java.naming. The usage of newThreadWithAcc is removed from
com.
On Mon, 11 Nov 2024 12:34:44 GMT, Shaojin Wen wrote:
> 8343925 Feedback PR #21593 test/jdk/java/util/BitSet/HugeToString.java crash,
>
> I can't reproduce the problem on a MacBook M1 Max, but I agree that more
> testing is needed, so let's roll it back first.
Thanks for the BACKOUT, looks rig
On Mon, 11 Nov 2024 12:34:44 GMT, Shaojin Wen wrote:
> 8343925 Feedback PR #21593 test/jdk/java/util/BitSet/HugeToString.java crash,
>
> I can't reproduce the problem on a MacBook M1 Max, but I agree that more
> testing is needed, so let's roll it back first.
Changes in this area need to be v
On Fri, 8 Nov 2024 16:08:58 GMT, Kevin Driver wrote:
> JDK-8343684: timeout value not required and is prone to issues with different
> hardware/threading models
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21987#pullrequestreview-2424342186
On Sun, 3 Nov 2024 11:25:13 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/lang/System.java line 1364:
>>
>>> 1362: *
>>> 1363: * It is the responsibility of the provider of
>>> 1364: * the concrete {@code LoggerFinder} implementation to ensure that
>>
>> This is s
On Sat, 2 Nov 2024 22:18:09 GMT, ExE Boss wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 200 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Modify three RMI tests
On Mon, 28 Oct 2024 19:16:26 GMT, Brent Christian wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 175 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Specify that pa
On Thu, 24 Oct 2024 11:32:27 GMT, Coleen Phillimore wrote:
>> Right, although you might have to wait until there is more cleanup in the
>> JDK code before they disappear completely. To clarify, most uses of
>> privileged actions are only done when a SecurityManager is set but there
>> some cas
On Wed, 23 Oct 2024 19:15:01 GMT, Coleen Phillimore wrote:
>> This tracing skips ClassLoader frames, you'll continue to see these when
>> using Class.forName.
>
> but you won't see access_controller_klass or priviledged_action_klass frames,
> so no need to skip them? Not sure why you'd want to
On Wed, 23 Oct 2024 12:44:53 GMT, Coleen Phillimore wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 21:20:59 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Mon, 21 Oct 2024 17:20:15 GMT, Sean Mullan wrote:
> > There are a couple of micro benchmarks in test/micro that fork with
> > `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be
> > examined.
>
> Fixed, will be in next drop. There are a couple of other micro tests that
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 16 Oct 2024 20:14:07 GMT, Sean Mullan wrote:
>> We've had logging library maintainers on the core-libs-dev several times in
>> the last 7+ years so I hope there is good awareness of StackWalker.
>> SM.getClassContext is legacy, shouldn't be any reason to use it in 2024.
>
> Ok, I'll als
On Wed, 16 Oct 2024 15:31:49 GMT, ExE Boss wrote:
>> SecurityManager::getClassContext hasn't been needed since JDK 9 but we
>> decided to keep the implementation in case there are older versions of
>> logging libraries that extend SecurityManager so they can call this method.
>> What we have c
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote:
> This brings in CPU24_10 changes into master branch.
Discussed with Jai to confirm testing. All good.
-
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21533#pullrequestreview-2372116298
On Tue, 15 Oct 2024 18:57:11 GMT, Phil Race wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main chan
On Tue, 15 Oct 2024 22:16:27 GMT, Sean Mullan wrote:
>> src/java.desktop/share/classes/java/awt/Robot.java line 433:
>>
>>> 431: * then a {@code SecurityException} may be thrown,
>>> 432: * or the content of the returned {@code Color} is undefined.
>>> 433: *
>>
>> This text sho
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 1006:
> 1004:
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote:
> Adds a JFR event for socket connect operations.
>
> Existing tests TestSocketEvents and TestSocketChannelEvents modified to also
> check for connect events.
src/java.base/share/classes/sun/nio/ch/NioSocketImpl.java line 624:
> 622:
On Tue, 15 Oct 2024 22:15:45 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/lang/SecurityManager.java line 72:
>>
>>> 70: private static class StackWalkerHolder {
>>> 71: static final StackWalker STACK_WALKER =
>>> 72:
>>> StackWalker.getInstance(StackWalker
On Tue, 15 Oct 2024 14:27:13 GMT, Daniel Fuchs wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main c
On Thu, 10 Oct 2024 17:02:00 GMT, Alan Bateman wrote:
>> Andrew Haley has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix javadoc
>
> src/java.base/share/classes/java/lang/ScopedValue.java line 163:
1 - 100 of 371 matches
Mail list logo
